From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05319C47082 for ; Mon, 24 May 2021 01:08:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC4E161185 for ; Mon, 24 May 2021 01:08:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232190AbhEXBJt (ORCPT ); Sun, 23 May 2021 21:09:49 -0400 Received: from mga03.intel.com ([134.134.136.65]:31729 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232181AbhEXBJr (ORCPT ); Sun, 23 May 2021 21:09:47 -0400 IronPort-SDR: BIzFKj052T5Nek5R6ozwgSoctpj8DILReCrFgGjilsmzIW0rEDjWY1ZiNHttxyaRMMtlMpsRMc Z+nIrjQVEBWg== X-IronPort-AV: E=McAfee;i="6200,9189,9993"; a="201877554" X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="201877554" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2021 18:08:17 -0700 IronPort-SDR: c2jwz1Hgpn3It494k7ri9oMB2oith5OTFoaGsEyDBB1cWhYgPcfE2qWxwPDlZvoJHtzfFLHpsi 1CphJh4+2CSw== X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="475598439" Received: from yjin15-mobl1.ccr.corp.intel.com (HELO [10.238.4.82]) ([10.238.4.82]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2021 18:08:15 -0700 Subject: Re: [PATCH 1/4] perf vendor events: Add core event list for Icelake Server To: Arnaldo Carvalho de Melo , Ian Rogers Cc: Jiri Olsa , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , LKML , Andi Kleen , Kan Liang , "Jin, Yao" References: <20210510012438.6293-1-yao.jin@linux.intel.com> <20210510012438.6293-2-yao.jin@linux.intel.com> From: "Jin, Yao" Message-ID: Date: Mon, 24 May 2021 09:08:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On 5/22/2021 3:41 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, May 20, 2021 at 09:08:37AM -0700, Ian Rogers escreveu: >> On Sun, May 9, 2021 at 6:26 PM Jin Yao wrote: >>> Add JSON core events for Icelake Server to perf. >>> >>> Based on JSON list v1.04 >>> https://download.01.org/perfmon/ICX/ >>> >>> Signed-off-by: Jin Yao >>> Reviewed-by: Andi Kleen >> Acked-by: Ian Rogers > ⬢[acme@toolbox perf]$ am > Applying: perf vendor events: Add core event list for Icelake Server > error: corrupt patch at line 2771 > Patch failed at 0001 perf vendor events: Add core event list for Icelake Server > hint: Use 'git am --show-current-patch=diff' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > ⬢[acme@toolbox perf]$ > ⬢[acme@toolbox perf]$ git diff > ⬢[acme@toolbox perf]$ git am --abort > ⬢[acme@toolbox perf]$ patch -p1 < ~/wb/1.patch > patching file tools/perf/pmu-events/arch/x86/icelakex/cache.json > patching file tools/perf/pmu-events/arch/x86/icelakex/floating-point.json > patching file tools/perf/pmu-events/arch/x86/icelakex/frontend.json > patching file tools/perf/pmu-events/arch/x86/icelakex/memory.json > patching file tools/perf/pmu-events/arch/x86/icelakex/other.json > patching file tools/perf/pmu-events/arch/x86/icelakex/pipeline.json > patch: **** malformed patch at line 1927: less than MAX. The reset value to the counter is not clocked immediately so the overflow status bit will flip 'high (1)' and generate another PMI (if enabled) after which the reset value gets clocked into the counter. Therefore, software will get the interrupt, read the overflow status bit '1 for bit 34 while the counter value is less than MAX. Software should ignore this case.", > > ⬢[acme@toolbox perf]$ > > Please check. > > - Arnaldo > Could you pull the top 4 patches from "https://github.com/yaoj/icx-events.git"? perf vendor events: Update event list for Icelake Client perf vendor events: Add metrics for Icelake Server perf vendor events: Add uncore event list for Icelake Server perf vendor events: Add core event list for Icelake Server The patch is too big and it's possibly corrupted by mailing system. Thanks Jin Yao