mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Clément Léger" <cleger@rivosinc.com>
To: Alexandre Ghiti <alex@ghiti.fr>,
	Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: kernel test robot <lkp@intel.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] riscv: Make sure toolchain supports zba before using zba instructions
Date: Fri, 28 Mar 2025 14:02:08 +0100	[thread overview]
Message-ID: <c0f425ec-6c76-45b2-b1bc-8d9be028a878@rivosinc.com> (raw)
In-Reply-To: <26afad1a-bee0-498b-8213-aea87167dedd@ghiti.fr>



On 28/03/2025 14:00, Alexandre Ghiti wrote:
> On 28/03/2025 13:51, Clément Léger wrote:
>>
>> On 28/03/2025 12:54, Alexandre Ghiti wrote:
>>> Old toolchain like gcc 8.5.0 does not support zba, so we must check that
>>> the toolchain supports this extension before using it in the kernel.
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202503281836.8pntHm6I-
>>> lkp@intel.com/
>>> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
>>> ---
>>>   arch/riscv/Kconfig                     | 8 ++++++++
>>>   arch/riscv/include/asm/runtime-const.h | 5 +++--
>>>   2 files changed, 11 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>>> index 0d8def968a7e..ae6303f15b28 100644
>>> --- a/arch/riscv/Kconfig
>>> +++ b/arch/riscv/Kconfig
>>> @@ -735,6 +735,14 @@ config TOOLCHAIN_HAS_VECTOR_CRYPTO
>>>       def_bool $(as-instr, .option arch$(comma) +v$(comma) +zvkb)
>>>       depends on AS_HAS_OPTION_ARCH
>>>   +config TOOLCHAIN_HAS_ZBA
>>> +    bool
>>> +    default y
>>> +    depends on !64BIT || $(cc-option,-mabi=lp64 -march=rv64ima_zba)
>>> +    depends on !32BIT || $(cc-option,-mabi=ilp32 -march=rv32ima_zba)
>>> +    depends on LLD_VERSION >= 150000 || LD_VERSION >= 23900
>>> +    depends on AS_HAS_OPTION_ARCH
>>> +
>>>   config RISCV_ISA_ZBA
>> Hi Alex,
>>
>> Why not add a "depends on TOOLCHAIN_HAS_ZBA" here so you don't have to
>> check for that config option when using CONFIG_RISCV_ISA_ZBA ? This is
>> done like that for ZBB and ZBC.
> 
> 
> Actually Conor changed that for Zbb in https://lore.kernel.org/
> lkml/20241024-aspire-rectify-9982da6943e5@spud/T/
> #m89d45ba3cbc6c2f953516c0e9977fecf397809b0 which is queued for 6.15.
> 
> Zba is also used in BPF, so we should not require that the toolchain
> supports zba but instead just that the platform supports it.

Indeed, makes sense !

Thanks,

Clément

> 
> Thanks,
> 
> Alex
> 
> 
>>
>> Thanks,
>>
>> Clément
>>
>>>       bool "Zba extension support for bit manipulation instructions"
>>>       default y
>>> diff --git a/arch/riscv/include/asm/runtime-const.h b/arch/riscv/
>>> include/asm/runtime-const.h
>>> index ea2e49c7149c..c07d049fdd5d 100644
>>> --- a/arch/riscv/include/asm/runtime-const.h
>>> +++ b/arch/riscv/include/asm/runtime-const.h
>>> @@ -77,7 +77,8 @@
>>>       ".long 1b - .\n\t"                    \
>>>       ".popsection"                        \
>>>   -#if defined(CONFIG_RISCV_ISA_ZBA) && defined(CONFIG_RISCV_ISA_ZBKB)
>>> +#if defined(CONFIG_RISCV_ISA_ZBA) &&
>>> defined(CONFIG_TOOLCHAIN_HAS_ZBA)    \
>>> +    && defined(CONFIG_RISCV_ISA_ZBKB)
>>
>>>   #define runtime_const_ptr(sym)                        \
>>>   ({                                    \
>>>       typeof(sym) __ret, __tmp;                    \
>>> @@ -93,7 +94,7 @@
>>>           : [__ret] "=r" (__ret), [__tmp] "=r" (__tmp));        \
>>>       __ret;                                \
>>>   })
>>> -#elif defined(CONFIG_RISCV_ISA_ZBA)
>>> +#elif defined(CONFIG_RISCV_ISA_ZBA) &&
>>> defined(CONFIG_TOOLCHAIN_HAS_ZBA)
>>>   #define runtime_const_ptr(sym)                        \
>>>   ({                                    \
>>>       typeof(sym) __ret, __tmp;                    \


  reply	other threads:[~2025-03-28 13:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 11:54 Alexandre Ghiti
2025-03-28 12:51 ` Clément Léger
2025-03-28 13:00   ` Alexandre Ghiti
2025-03-28 13:02     ` Clément Léger [this message]
2025-04-03 16:20 ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0f425ec-6c76-45b2-b1bc-8d9be028a878@rivosinc.com \
    --to=cleger@rivosinc.com \
    --cc=alex@ghiti.fr \
    --cc=alexghiti@rivosinc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®