mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	airlied@redhat.com, airlied@linux.ie, daniel@ffwll.ch
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ast: potential dereference of null pointer
Date: Mon, 13 Dec 2021 10:59:05 +0100	[thread overview]
Message-ID: <c1006921-19b4-4cd4-2522-4d83af575ff7@suse.de> (raw)
In-Reply-To: <20211213053912.2167066-1-jiasheng@iscas.ac.cn>


[-- Attachment #1.1: Type: text/plain, Size: 1440 bytes --]

Hi,

thanks for the patch.

Am 13.12.21 um 06:39 schrieb Jiasheng Jiang:
> he return value of kzalloc() needs to be checked.

'The'

> To avoid use of null pointer '&ast_state->base' in case of the
> failure of alloc.
> 
> Fixes: f0adbc382b8b ("drm/ast: Allocate initial CRTC state of the correct size")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>   drivers/gpu/drm/ast/ast_mode.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 36d9575aa27b..67f8e3f90ea2 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -1120,7 +1120,8 @@ static void ast_crtc_reset(struct drm_crtc *crtc)
>   	if (crtc->state)
>   		crtc->funcs->atomic_destroy_state(crtc, crtc->state);
>   
> -	__drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
> +	if (ast_state)
> +		__drm_atomic_helper_crtc_reset(crtc, &ast_state->base);

If ast_state is NULL, __drm_atomic_helper_crtc_reset() has to be called 
with a state of NULL. Otherwise the reset might leave the dangling 
pointer in the CRTC's state field.

Best regards
Thomas

>   }
>   
>   static struct drm_crtc_state *
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2021-12-13 10:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13  5:39 Jiasheng Jiang
2021-12-13  9:59 ` Thomas Zimmermann [this message]
2021-12-14  1:37 Jiasheng Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1006921-19b4-4cd4-2522-4d83af575ff7@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jiasheng@iscas.ac.cn \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®