From: Randy Dunlap <rdunlap@infradead.org>
To: Tomasz Figa <tfiga@chromium.org>, linux-kbuild@vger.kernel.org
Cc: Nicolas Schier <n.schier@avm.de>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kernel@vger.kernel.org,
Jesse Taube <Mr.Bossman075@gmail.com>
Subject: Re: [PATCH v2] kconfig: menuconfig: Make hidden options show with different color
Date: Wed, 28 Feb 2024 21:40:04 -0800 [thread overview]
Message-ID: <c1025094-d9aa-4f4c-bb8f-a486f9953bec@infradead.org> (raw)
In-Reply-To: <20240228060006.13274-1-tfiga@chromium.org>
Hi,
On 2/27/24 22:00, Tomasz Figa wrote:
> When hidden options are toggled on (using 'z'), the number of options
> on the screen can be overwhelming and may make it hard to distinguish
> between available and hidden ones. Make them easier to distinguish by
> displaying the hidden one with a different color (COLOR_YELLOW for color
> themes and A_DIM for mono).
> Signed-off-by: Tomasz Figa <tfiga@chromium.org>
> ---
> scripts/kconfig/lxdialog/dialog.h | 5 +++++
> scripts/kconfig/lxdialog/menubox.c | 12 ++++++++----
> scripts/kconfig/lxdialog/util.c | 19 +++++++++++++++++++
> scripts/kconfig/mconf.c | 18 ++++++++++++++++++
> 4 files changed, 50 insertions(+), 4 deletions(-)
> Changes from v1:
> (https://patchwork.kernel.org/project/linux-kbuild/patch/20231228054630.3595093-1-tfiga@chromium.org/)
> * Replaced A_DIM for color themes with COLOR_YELLOW, because the former
> has no effect to black text on some commonly used terminals, e.g.
> gnome-terminal, foot. Reported by Masahiro Yamada and Nicolas Schier.
> I ended up with COLOR_YELLOW, as it seems to look comparatively dim
> with mutliple light and dark color themes in Chromium hterm and
> gnome-terminal.
I guess COLOR_YELLOW is a relative thing, i.e., it depends on the term's
current color scheme in my testing.
With rxvt (with a beige/khaki background), I do see yellow.
With xfce4-terminal (with amber/orange foreground on black background,
i.e., my default from days of amber monochrome displays ;), the "yellow"
comes out as a faded/washed out/dim orange. But still readable.
Anyway, this looks useful to me.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
thanks.
--
#Randy
next prev parent reply other threads:[~2024-02-29 5:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 6:00 Tomasz Figa
2024-02-28 7:36 ` Nicolas Schier
2024-02-29 1:58 ` Masahiro Yamada
2024-02-29 5:40 ` Randy Dunlap [this message]
2024-03-05 7:49 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1025094-d9aa-4f4c-bb8f-a486f9953bec@infradead.org \
--to=rdunlap@infradead.org \
--cc=Mr.Bossman075@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=n.schier@avm.de \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®