From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: qcom: audioreach: Add support for VI Sense module
Date: Fri, 29 Aug 2025 08:45:30 +0200 [thread overview]
Message-ID: <c103da1f-b4ef-4f2f-8648-dda636094bde@linaro.org> (raw)
In-Reply-To: <6a4a601b-937e-441f-80a7-3f733fc86445@oss.qualcomm.com>
On 22/08/2025 12:55, Srinivas Kandagatla wrote:
>> +
>> + pkt = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
>> + if (IS_ERR(pkt))
>> + return PTR_ERR(pkt);
>> +
>> + p = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
>> +
>> + op_cfg = p;
>> + param_data = &op_cfg->param_data;
>> + param_data->module_instance_id = module->instance_id;
>> + param_data->error_code = 0;
>> + param_data->param_id = PARAM_ID_SP_VI_OP_MODE_CFG;
>> + param_data->param_size = op_sz - APM_MODULE_PARAM_DATA_SIZE;
>> +
>> + op_cfg->cfg.num_channels = num_channels;
>> + op_cfg->cfg.operation_mode = PARAM_ID_SP_VI_OP_MODE_CALIBRATION;
>> + op_cfg->cfg.quick_calibration = 1;
>> + /*
>> + * op_cfg->cfg.r0_t0_selection should be set only for normal mode, keep
>> + * as 0 for calibration
>
> How do we move from calibration to a normal mode?
The same as in previous patch - this should be normal mode.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-29 6:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 14:16 [PATCH 1/2] ASoC: qcom: audioreach: Add support for Speaker Protection module Krzysztof Kozlowski
2025-08-21 14:16 ` [PATCH 2/2] ASoC: qcom: audioreach: Add support for VI Sense module Krzysztof Kozlowski
2025-08-22 10:55 ` Srinivas Kandagatla
2025-08-29 6:45 ` Krzysztof Kozlowski [this message]
2025-09-03 9:34 ` Konrad Dybcio
2025-08-22 10:39 ` [PATCH 1/2] ASoC: qcom: audioreach: Add support for Speaker Protection module Srinivas Kandagatla
2025-08-29 6:44 ` Krzysztof Kozlowski
2025-09-03 9:31 ` Konrad Dybcio
2025-09-03 10:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c103da1f-b4ef-4f2f-8648-dda636094bde@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®