From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Sean Christopherson <seanjc@google.com>,
Dongli Zhang <dongli.zhang@oracle.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Jim Mattson <jmattson@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 00/10] KVM: x86/pmu: Optimize triggering of emulated events
Date: Thu, 16 Nov 2023 17:37:11 +0100 [thread overview]
Message-ID: <c10bd6c4-9701-4888-8277-851c5ac76beb@virtuozzo.com> (raw)
In-Reply-To: <ZU5Euc29B_UjiUot@google.com>
On 10.11.2023 15:56, Sean Christopherson wrote:
> On Thu, Nov 09, 2023, Dongli Zhang wrote:
>> Hi Sean,
>>
>> On 11/9/23 18:28, Sean Christopherson wrote:
>>> base-commit: ef1883475d4a24d8eaebb84175ed46206a688103
>> May I have a silly question?
>>
>> May I have the tree that the commit is the base? I do not find it in kvm-x86.
>>
>> https://github.com/kvm-x86/linux/commit/ef1883475d4a24d8eaebb84175ed46206a688103
> It's kvm-x86/next (which I failed to explicitly call out), plus two PMU series
> as mentioned in the cover letter.
>
> https://lore.kernel.org/all/20231103230541.352265-1-seanjc@google.com
> https://lore.kernel.org/all/20231110021306.1269082-1-seanjc@google.com
Hi Sean,
i have tested my testcase on your patchset, results look impressive, thank you for your work!
Note, for AMD node PMU totally disabled case gave a bit worse results on kvm-next kernel vs stock
latest mainstream.
The difference is tiny though.
*AMD node*: CPU: AMD Zen 3 (three!): AMD EPYC 7443P 24-Core Processor
-----------------------------------------------------------------------------------------
| Kernel | CPUID rate |
-----------------------------------------------------------------------------------------
| stock ms 6.6.0+ (commit 305230142ae0) | 1360250 |
| stock ms 6.6.0+ + kvm.enable_pmu=0 | 1542894 (+13.4%) |
| kvm-next ms 6.6.0+ + patches from Sean + kvm.enable_pmu=1 | 1498864 |
| kvm-next ms 6.6.0+ + patches from Sean + kvm.enable_pmu=0 | 1526396 (+1.84%) |
-----------------------------------------------------------------------------------------
*Intel node*: CPU: Intel(R) Xeon(R) E-2136 CPU @ 3.30GHz
-----------------------------------------------------------------------------------------
| Kernel | CPUID rate |
-----------------------------------------------------------------------------------------
| stock ms 6.6.0+ | 1431608 |
| stock ms 6.6.0+ + kvm.enable_pmu=0 | 1553839 (+8.5%) |
| kvm-next ms 6.6.0+ + patches from Sean + kvm.enable_pmu=1 | 1559365 |
| kvm-next ms 6.6.0+ + patches from Sean + kvm.enable_pmu=0 | 1582281 (+1.5%) |
-----------------------------------------------------------------------------------------
Note: in order to disable PMU completely i used "kvm" module "enable_pmu=0" option
(not used KVM_PMU_CAP_DISABLEthis time).
Hope that helps.
--
Best regards,
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
next prev parent reply other threads:[~2023-11-16 16:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 2:28 Sean Christopherson
2023-11-10 2:28 ` [PATCH 01/10] KVM: x86/pmu: Zero out PMU metadata on AMD if PMU is disabled Sean Christopherson
2023-11-10 2:28 ` [PATCH 02/10] KVM: x86/pmu: Add common define to capture fixed counters offset Sean Christopherson
2023-11-10 2:28 ` [PATCH 03/10] KVM: x86/pmu: Move pmc_idx => pmc translation helper to common code Sean Christopherson
2023-11-10 2:28 ` [PATCH 04/10] KVM: x86/pmu: Snapshot and clear reprogramming bitmap before reprogramming Sean Christopherson
2023-11-10 2:28 ` [PATCH 05/10] KVM: x86/pmu: Add macros to iterate over all PMCs given a bitmap Sean Christopherson
2023-11-10 2:28 ` [PATCH 06/10] KVM: x86/pmu: Process only enabled PMCs when emulating events in software Sean Christopherson
2023-11-10 2:28 ` [PATCH 07/10] KVM: x86/pmu: Snapshot event selectors that KVM emulates " Sean Christopherson
2023-11-10 2:28 ` [PATCH 08/10] KVM: x86/pmu: Expand the comment about what bits are check emulating events Sean Christopherson
2023-11-10 2:28 ` [PATCH 09/10] KVM: x86/pmu: Check eventsel first when emulating (branch) insns retired Sean Christopherson
2023-11-10 2:28 ` [PATCH 10/10] KVM: x86/pmu: Avoid CPL lookup if PMC enabline for USER and KERNEL is the same Sean Christopherson
2023-11-10 6:37 ` [PATCH 00/10] KVM: x86/pmu: Optimize triggering of emulated events Dongli Zhang
2023-11-10 14:56 ` Sean Christopherson
2023-11-16 16:37 ` Konstantin Khorenko [this message]
2024-02-03 0:11 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c10bd6c4-9701-4888-8277-851c5ac76beb@virtuozzo.com \
--to=khorenko@virtuozzo.com \
--cc=dongli.zhang@oracle.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®