From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F703C4332F for ; Thu, 15 Dec 2022 17:17:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229971AbiLORQz (ORCPT ); Thu, 15 Dec 2022 12:16:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbiLORQu (ORCPT ); Thu, 15 Dec 2022 12:16:50 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7C5B7FAE9 for ; Thu, 15 Dec 2022 09:16:49 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8CAB5FEC; Thu, 15 Dec 2022 09:17:29 -0800 (PST) Received: from [10.57.88.90] (unknown [10.57.88.90]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6F673F5A1; Thu, 15 Dec 2022 09:16:47 -0800 (PST) Message-ID: Date: Thu, 15 Dec 2022 17:16:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] iommu/renesas: Support riscv compile Content-Language: en-GB To: guoren@kernel.org, palmer@dabbelt.com, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, iommu@lists.linux.dev, Guo Ren , kernel test robot References: <20221215073212.1966823-1-guoren@kernel.org> From: Robin Murphy In-Reply-To: <20221215073212.1966823-1-guoren@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-12-15 07:32, guoren@kernel.org wrote: > From: Guo Ren > > After riscv selects ARCH_RENESAS, we need to add ARM64 || ARM > dependency here. This effectively removes all the extra COMPILE_TEST coverage we've been enjoying. FWIW I prefer Geert's suggestion to separate the real functional dependency from implicit assumptions about ARCH_RENESAS, with something like: depends on ARCH_RENESAS || COMPILE_TEST depends on !GENERIC_ATOMIC64 #for IOMMU_IO_PGTABLE_LPAE Thanks, Robin. > Reported-by: kernel test robot > Signed-off-by: Guo Ren > Signed-off-by: Guo Ren > --- > drivers/iommu/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index dc5f7a156ff5..746b95b9f345 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG > > config IPMMU_VMSA > bool "Renesas VMSA-compatible IPMMU" > + depends on ARM64 || ARM > depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64) > select IOMMU_API > select IOMMU_IO_PGTABLE_LPAE