From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA06C7619A for ; Wed, 5 Apr 2023 05:43:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236386AbjDEFm7 (ORCPT ); Wed, 5 Apr 2023 01:42:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232835AbjDEFm5 (ORCPT ); Wed, 5 Apr 2023 01:42:57 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 563D73AA5 for ; Tue, 4 Apr 2023 22:42:56 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id cn12so138294394edb.4 for ; Tue, 04 Apr 2023 22:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680673375; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2K0AK0sGSq/zsYIcb4gwqrtW+FVk7SlY1SeSzCW9Y78=; b=CDig9UWn2FHcGl7WX8sn9pQBAjqV9zNTwmXcjp3HMFYakZlP5xUex1pjuZnJgFeM+w 2AXOwWXxbuRBJdgMMu+iFMW3z4alMw5B8mcF3XQAxIJa0vMuBKV89IKrUVAhmdjLp0lE 7qXG6m+9oBn+H5By2QSaCzQqlsggbIrhmrsms9tJeCj0HLz2HtSGaev/GtwMZ90suWNO yqy0GuWoS2QpbSSI9TFi14BLadCr1IBcSmRNQeHWRwtSlC0X0JGURCg9hc9xNK8BOQfX BVci0ZTHFu20BOgUa0DV2VWd6VZpfveSRhtxtkswRI5wBq/bl5tBUFvDj64CgH0fyV7d Y5Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680673375; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2K0AK0sGSq/zsYIcb4gwqrtW+FVk7SlY1SeSzCW9Y78=; b=zRXpUM7IqSaMZCkhtqe8AccQBcVmXhKIjtsjwVPhy3ey2b8SbdenDntUuYsdQ4mZVJ II4MTArb1rBfhW2KYy4bFU6MHoGtiSylCTu7ICau0RgIeugBU1whCc5FY88ksRHCXNpO D8arDF7QnTJtEOhhllx7S1IGY4EXxOMwU0/pAPKy5Qtrp/5P6ULuPEKxK5JGmkGCT2Dz KLt6oem3mB0muCzUW6XgrAQVhVzFWysCD5Rfat0sU5mETjlYormIZMeLsu7oYM53hZ6T +Ku2pWOl/AnBA/olCF+8vc+dSH6W7LSur3mWY0gfIWrxEqzRH/Ecqu+73Xhqv+KvxqQh E5xQ== X-Gm-Message-State: AAQBX9fOkr5WhbNPsqEpbK5IXynZbx4DMhG3Ql1ovYHFIwCcQMZUH25j 4JznOXj9ec4xNvzE54X8xntUKg== X-Google-Smtp-Source: AKy350bNv83HafLK+q09N2ueHnZ3s8USo8+70Ki/AAqyULFwQ6xhlGO2nm29uF0SpDrJYH3DJ8FuEg== X-Received: by 2002:a17:906:f853:b0:931:8e8c:2db5 with SMTP id ks19-20020a170906f85300b009318e8c2db5mr1846024ejb.69.1680673374874; Tue, 04 Apr 2023 22:42:54 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:3f:6b2:54cd:498e? ([2a02:810d:15c0:828:3f:6b2:54cd:498e]) by smtp.gmail.com with ESMTPSA id jg9-20020a170907970900b00947ae870e78sm6489740ejc.203.2023.04.04.22.42.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 22:42:54 -0700 (PDT) Message-ID: Date: Wed, 5 Apr 2023 07:42:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/3] spi: s3c64xx: support spi polling mode using devicetree Content-Language: en-US To: Jaewon Kim , Andi Shyti , Alim Akhtar , Mark Brown , Rob Herring Cc: linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chanho Park References: <20230404060011.108561-1-jaewon02.kim@samsung.com> <20230404060011.108561-2-jaewon02.kim@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20230404060011.108561-2-jaewon02.kim@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2023 08:00, Jaewon Kim wrote: > This patch adds new 'samsung,spi-polling' property to support polling mode. Do not use "This commit/patch", but imperative mood. See: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 Also, binding should be before its usage. > In some environments, polling mode is required even if DMA is supported. Why? What are these environments? You need to explain all this in commit msg. > Changed it to support not only with quick but also optinally with typo: optionally > devicetree. > Best regards, Krzysztof