From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 919B8ECAAD8 for ; Tue, 20 Sep 2022 13:32:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230096AbiITNcO (ORCPT ); Tue, 20 Sep 2022 09:32:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229828AbiITNcK (ORCPT ); Tue, 20 Sep 2022 09:32:10 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 322814F6BF for ; Tue, 20 Sep 2022 06:32:06 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id d12-20020a05600c3acc00b003b4c12e47f3so1662000wms.4 for ; Tue, 20 Sep 2022 06:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date; bh=g5jWZ2WFsY/FBmA+o1CluBEPsaJX+nCuG4k+tTP6m98=; b=ahZuUmZPGV5kDEbozZYj/AQZKifnavG29tNgalSvlzR5TcLPGh1dSvBuu0oEwJWkK8 eGDqMvolNTe8QT2zuxZLn6S8pQpToMAWOV0m8ATNCMc7S8AGPU1V+Nk9sOBew7VWMUyU uyigES993TtvKSZyAtdJjZeeQgrmza0ncNlYvvp0MfYTlSzYNBY01YZQgI3nWKhxpdx+ ERvibhp7HoUL1OgkpSyB15LJyXRTO8O3vtlG9UK9CjReqCffygYnKc+JJ0drJVY3SdCi v7biwIIurbVya/n8QT6NsrszkTIdWIO2jENz5ysO8svMiWV8zedM1M3aENtrta9MV24m hYrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=g5jWZ2WFsY/FBmA+o1CluBEPsaJX+nCuG4k+tTP6m98=; b=CcF3D193cbiQiB5q2WAFkOvVAja1onTD4LnoDWBC/0z3106s9yHZ8evZA10z7bPP8X SaYDpMzMdq6QQI9Xbv2v9NADODPhLBsfMmgG5HdLk4x+U5AELmv2JK0R/kYheW3TDKdm 3/hOYq1t7fiPD9Dvmf94SlJVMvDSanoAc/u6Fg3INkdb7CHfclx0aqPlzAw+2uzbABOQ ZvJHAk9Gy62rbzr1XSpAUvLWG4/fW6LrzPJ7DK6Uwy1rYFgWx4YTLiU95SEUALoYoHaP 1c8Je0C0aEuJng+N3cHGLrdg3PztUY9S+DVxvcSkdEi5dcvvdFTIYlajFcqtA8GCm3AZ kgOQ== X-Gm-Message-State: ACrzQf0hFBU718YtVUWPw4ndGEeAVnxwLDtinoRQ8AKAGXeX3inSQNRE r05dhCeGeejN0c14qIUQ1VwHhA== X-Google-Smtp-Source: AMsMyM5QtgXayw9Vbt5bQUfay84AiUJaO/gk8txKtCJ6f5cE6M/XeIOV5ivdcHiSum4QLXKloFZ0JA== X-Received: by 2002:a05:600c:43d3:b0:3b3:2f1c:f01c with SMTP id f19-20020a05600c43d300b003b32f1cf01cmr2465695wmn.152.1663680724742; Tue, 20 Sep 2022 06:32:04 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:7e10:f0f:43b2:9b5e? ([2a01:e0a:982:cbb0:7e10:f0f:43b2:9b5e]) by smtp.gmail.com with ESMTPSA id e24-20020adfa458000000b002252ec781f7sm80983wra.8.2022.09.20.06.32.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 06:32:04 -0700 (PDT) Message-ID: Date: Tue, 20 Sep 2022 15:32:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH -next] slimbus: qcom-ngd: Add error handling in of_qcom_slim_ngd_register Content-Language: en-US To: Lin Yujun , agross@kernel.org, bjorn.andersson@linaro.org, konrad.dybcio@somainline.org, srinivas.kandagatla@linaro.org, gregkh@linuxfoundation.org, vkoul@kernel.org Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20220914031953.94061-1-linyujun809@huawei.com> From: Neil Armstrong Organization: Linaro In-Reply-To: <20220914031953.94061-1-linyujun809@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/09/2022 05:19, Lin Yujun wrote: > No error handling is performed when platform_device_add() > return fails. Refer to the error handling of driver_set_override(), > add error handling for platform_device_add(). > > Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") > Signed-off-by: Lin Yujun > --- > drivers/slimbus/qcom-ngd-ctrl.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c > index 0aa8408464ad..fb591990ddad 100644 > --- a/drivers/slimbus/qcom-ngd-ctrl.c > +++ b/drivers/slimbus/qcom-ngd-ctrl.c > @@ -1470,7 +1470,13 @@ static int of_qcom_slim_ngd_register(struct device *parent, > ngd->pdev->dev.of_node = node; > ctrl->ngd = ngd; > > - platform_device_add(ngd->pdev); > + ret = platform_device_add(ngd->pdev); > + if (ret) { > + platform_device_put(ngd->pdev); > + kfree(ngd); > + of_node_put(node); > + return ret; > + } > ngd->base = ctrl->base + ngd->id * data->offset + > (ngd->id - 1) * data->size; > Reviewed-by: Neil Armstrong