From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933983AbdJREqW (ORCPT ); Wed, 18 Oct 2017 00:46:22 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49098 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932717AbdJREqU (ORCPT ); Wed, 18 Oct 2017 00:46:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7C2216079E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [RFC PATCH v4 6/8] drm/bridge/analogix: Do not use device's drvdata To: "'Jeffy Chen'" Cc: Jingoo Han , linux-kernel@vger.kernel.org, heiko@sntech.de, "'David Airlie'" , rjw@rjwysocki.net, dri-devel@lists.freedesktop.org, "'Andrzej Hajda'" , "'Laurent Pinchart'" , "'Marek Szyprowski'" , linux-samsung-soc@vger.kernel.org, "'Joonyoung Shim'" , briannorris@chromium.org, "'Krzysztof Kozlowski'" , linux-rockchip@lists.infradead.org, "'Kukjin Kim'" , "'Daniel Vetter'" , "'Caesar Wang'" , "'Inki Dae'" , broonie@kernel.org, seanpaul@chromium.org, "'Vincent Abriou'" , linux-arm-kernel@lists.infradead.org, "'Mark Yao'" , "'zain wang'" , "'Tomeu Vizoso'" , dmitry.torokhov@gmail.com, "'Seung-Woo Kim'" , dianders@chromium.org, tfiga@chromium.org, "'Kyungmin Park'" References: <20171017101624.12506-1-jeffy.chen@rock-chips.com> <20171017101624.12506-7-jeffy.chen@rock-chips.com> <000101d347a1$cd216160$67642420$@gmail.com> From: Archit Taneja Message-ID: Date: Wed, 18 Oct 2017 10:16:08 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <000101d347a1$cd216160$67642420$@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/18/2017 05:13 AM, Jingoo Han wrote: > On Tuesday, October 17, 2017 6:16 AM, Jeffy Chen wrote: >> >> From: Tomasz Figa >> >> The driver that instantiates the bridge should own the drvdata, as all >> driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also >> owned by its driver struct. Moreover, storing two different pointer >> types in driver data depending on driver initialization status is barely >> a good practice and in fact has led to many bugs in this driver. >> >> Let's clean up this mess and change Analogix entry points to simply >> accept some opaque struct pointer, adjusting their users at the same >> time to avoid breaking the compilation. >> >> Signed-off-by: Tomasz Figa >> Signed-off-by: Jeffy Chen >> Reviewed-by: Andrzej Hajda > This depends on previous patches of the series. I guess it would be easier to queue this to drm-misc as a part of the eDP support series. For that: Acked-by: Archit Taneja > Acked-by: Jingoo Han > > Best regards, > Jingoo Han > >> --- >> >> Changes in v4: None >> Changes in v3: None >> Changes in v2: None >> >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 50 +++++++++-------- >> ----- >> drivers/gpu/drm/exynos/exynos_dp.c | 26 ++++++----- >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 47 > +++++++++++------- >> -- >> include/drm/bridge/analogix_dp.h | 19 ++++---- >> 4 files changed, 73 insertions(+), 69 deletions(-) >> > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project