From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E93D73FD159 for ; Thu, 9 Jul 2026 09:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783587736; cv=none; b=Kh/bicyF47QSvnjFGhaSQE9hBTs3oDS5Ht5dyDRqhNlFAWmolamDiUcE4UEXug4fOOntfEDYbMlusOUdfS4oA4LO2kxfyobfx8PBxsLTHI9XZ2rkyEON5p9ktyRASiRIWFT7qrjpfI3nxI3/RrR1tlVc0/gEas9p8IOZyy/qrBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783587736; c=relaxed/simple; bh=wA81xsBNTy6unQfj6IY1O6fqGPGEKdjYscAzKj9ls0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oEB76WQ9Br7qAySiLNRbardkxTNQPnHSRI65FvieDLK6MZPeKlv8Y8ZqA5Lho3aBpMezg03rAx0zn+4wIfBtqseEZOVmJp/hBYGFVOIpw1+EY1IbUP+gU9AeZpxbu/N6q8QkdFaqD/gwkY12zkO+m1lrc6GlzXL1BZxoaDveMs4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AulfuAlm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CAjt51Pp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AulfuAlm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CAjt51Pp" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66960EAr931865 for ; Thu, 9 Jul 2026 09:02:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EOoqpkxalQnGgn2rNAM92KHFKF9kGa/rlb46Hia6Qak=; b=AulfuAlmG2nMc/yj QmLRWmYJZcbVBduUxmvmp/+QQOfbcw1XNli9D1qps4BTCWRJV+YgY+Z6/tA7Swpl YZdtE0exoFj6K8e+VJ1sfaEFl7/M4plsnVAvPX4Yoll8azBclSgTe1K7Zbp9h4Sa ztEjjJkSwy0Uxdx7NxiJqgZFvFPeW/49I2iy4ycArnnVmwQN9hGf+9HKy7VHEfaO DkdP5XTNJ/SRuEERvwY3TdRWwvKCF3r5aS+CPCbJcE/Y/KztnemFrKM9pALTWyVM 332VS3PU2dYPIoDjpnFc/bqMpAkS2Ibh/DWKWciZQlb7HhAmpWh9Wr3EKt0iATwE MOHVcA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9sqsbbm8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Jul 2026 09:02:13 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-388b404eae6so2678285a91.0 for ; Thu, 09 Jul 2026 02:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783587733; x=1784192533; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EOoqpkxalQnGgn2rNAM92KHFKF9kGa/rlb46Hia6Qak=; b=CAjt51PpFLsFB6/7TjVdjaW1296gHIFXOMOwdlUCl8VoNmE+dcUV8b4+naVEg75zk7 ZZBuo/C/VD5PpF9iya4+TJEjhYv7YQ9kfUo9HskhP6u12kG3mPDIW7dFFqCqUHlAbh5Y LHgEno3ivy9n+ZbfGfzX6SrndDZMz2566+qxfGmV3z2EYG+3sPDD37MmKODH3fg+ulZW RlJ8K44lILfRo+5ud7HCn387bqMCPt8k3XXvO2DqGf1VHeYhTFm4xzrYraLtmyzVS4Hm ddPq7pqJBtXO7VnolUJxMwuZs3Vx2xWYuc2Sg/TpHUWPcdSC0c95qgQCHVlOviRsewGu ++iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783587733; x=1784192533; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EOoqpkxalQnGgn2rNAM92KHFKF9kGa/rlb46Hia6Qak=; b=k1uivjB9HJF/SHIJrLECwiWIIGMcprCRcCvdlBe35YiZ+dwmsnJCQZQuhyu70gXdSE ClVhIiGiGf5FCFsvJOvIyTC9ObjFkx2aLHMvEzJXnGDytiBX6oVyVgTda3JySGYvndP1 S72GpuRver5gjghySl5UdRF06586xfQ+X2e4NZb4HOsXx29/5QZ5QEVoKH5iUXJIGRvk HU6Bo9pTz7jwyeujauc2oXjom3N7jtN+/JJ80WgarF9Bqp6eukfXz6geIRxuOYUP9jIZ OjSDi5h8QIfrPuzXvIH5QPm77/ReczHFN/nyg1Po90yJ9b2aEZW7F8wSFdcLb8Cw1bPH KQrg== X-Forwarded-Encrypted: i=1; AHgh+RqVe523f/VK47X7idopQHeH1HaaKZQZ89x2JM62p9GWFjvWiRDS5xYKlLwg3PAo4f9HCElYIoK/rITFB5w=@vger.kernel.org X-Gm-Message-State: AOJu0YxXq2lGGEHiJ303AATP4tS+VrS1Vq7jgPVGZxdWmgVUugaW67VQ nT/Bn0p7uU+ATGVWHJxTQTfnkPyXCIA8fWcVR4vxtw9OwtQcmZxNEfwESDmk+G+F32ctCCyovby xZHU91NeqWO/2n6wqmwac5Dw2nYJNabyzIhP4YIwTuADrtqPX+tIbqVq5OlMeE2Wg4H4= X-Gm-Gg: AfdE7ckynzzzQ5UHbVrKek6m0xlgbLwVW1J1T0RlUBnJqJjyXwl+2XUTthFPzZW8iZc 643A7FBKyq1XjT6M/Xn5HNevM6dfBbHtunqLf414cfmSvW2ZCtB9BYZ1lr151fZUHB8k1tOj1NR AXiQI/0L6raX/ZDDwRRTZcoaAUz88rWwtASJ1q/Ily9B1T7Zxc9xfvmfa1CcoukyRJ8mDMiIIiI 5jTezoKSu7fGr1LCuMpA98/I05xZMp45xMFJaYslORW9rEGgVrKG8snvweWHyGvRfRNNL3266c4 pJmKZjJBOPhsafYz9miWBs7iOR4FJ9MbPzwqcgTT4Qxqsts/W3ma8uul/5EnbGfeNrxMOemceAU M7rXz56VJP+MR6rIQTGRrRQ0pM5/Fo1dvGXsefU0dv3pd+F3Nl4TSz8EVweyO89T66D3DsWev9p 1P X-Received: by 2002:a17:90a:d2d0:b0:36d:689a:cb27 with SMTP id 98e67ed59e1d1-38941cc7844mr6222198a91.24.1783587732736; Thu, 09 Jul 2026 02:02:12 -0700 (PDT) X-Received: by 2002:a17:90a:d2d0:b0:36d:689a:cb27 with SMTP id 98e67ed59e1d1-38941cc7844mr6222140a91.24.1783587732151; Thu, 09 Jul 2026 02:02:12 -0700 (PDT) Received: from [10.133.33.179] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a57dc53a0sm823440a91.9.2026.07.09.02.02.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 02:02:10 -0700 (PDT) Message-ID: Date: Thu, 9 Jul 2026 17:02:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/5] dt-bindings: arm: coresight-tnoc: Drop arm,primecell to bind on platform bus To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20260707-fix-tracenoc-probe-issue-v5-0-bf733ed9ebd0@oss.qualcomm.com> <20260707-fix-tracenoc-probe-issue-v5-1-bf733ed9ebd0@oss.qualcomm.com> <20260709-versed-marvellous-pigeon-22e2ba@quoll> <02baada9-3f87-4e60-a469-44af5ebe1afe@kernel.org> Content-Language: en-US From: Jie Gan In-Reply-To: <02baada9-3f87-4e60-a469-44af5ebe1afe@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA5MDA4NSBTYWx0ZWRfXzQJzDGGJLm6m K6abPgLBfdmDYM+GT/ccLo31pfP+YkWI4phYG307Eb9h+++72iiULpzT5QDHAj2rLZ7GB4j74wu TQOhboiX6JcJ3bdKCnCM7DKJuGDn1/Q= X-Proofpoint-GUID: TDlpGWJZN5lGPf9huey9O7SKt1vkFvu1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA5MDA4NSBTYWx0ZWRfX+za34MRt/qbT Pu8u2HmI4/lLd9EEYYSrTTSRCoAhnpJR89C+lNyfy6v9R69MpG9x7ueIP1xh65iN2tlxUMfzK5Z kmUDL2aK+5NN3M9laRfn05K+WsQ72c9OyDs0GyqB29pc1fJHSkqTQJIR0mitBTbIKtgzP3+hyUE eW3bSZ9DMi5JUE4MP5rDjPCq5Ws2YUh5bbclJUz36zzCp31/+nBm0iq7FD4Z9nlww1A3R7qFCRL K0+TbDlyMU+t8/7bOvo+ZgOqw29It5RjCKRBfHmqpmi02P2G/lYv7M4oVC7b69RpDOUy+pTaerZ tX6+SazmA+ehX8qiZCNZ4U0clXPaaXh8RgI5o6upfZzeBaegWb7dAHmp/Lu0NkopW7uMNFzzHm7 7sy7ir51oIoCmx5o8tCefsyvyCWvSpDCLt3kFiXh3MeTg6hpN935leCkTS7mcivheAlIPcoU/6P TQyAi9Gug738oCa7d+g== X-Authority-Analysis: v=2.4 cv=Sv2gLvO0 c=1 sm=1 tr=0 ts=6a4f6395 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=Zyal9cr7WW2U8Oh0dT0A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: TDlpGWJZN5lGPf9huey9O7SKt1vkFvu1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_01,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607090085 On 7/9/2026 4:46 PM, Krzysztof Kozlowski wrote: > On 09/07/2026 10:34, Jie Gan wrote: >> >> >> On 7/9/2026 3:59 PM, Krzysztof Kozlowski wrote: >>> On Tue, Jul 07, 2026 at 05:08:49PM +0800, Jie Gan wrote: >>>> The TNOC compatible previously required the two-string AMBA form >>>> "qcom,coresight-tnoc", "arm,primecell", which forces the device onto the >>>> AMBA bus. >>>> >>>> Change the compatible to a single "qcom,coresight-tnoc" string with no >>>> "arm,primecell" entry, so the device is created on the platform bus and >>>> bound by the platform driver through its compatible string. >>> >>> I asked already: this is not a valid reason. References to Linux >>> structures are not correct here. If this is your reason, then answer is: >>> fix drivers, by renaming or doing whatever is necessary to platform bus >>> to behave like amba bus. >> >> The issue is that we are not allowed to introduce a DT property to >> bypass the AMBA bus validation, which reads the Component ID (CID) > > It is the first time "bypass the AMBU bus validation" appears in this > patch. You do not see that as a problem? > > Again, third time and the last: describe the actual hardware and the > actual problem coming from the hardware. Understood, will focus on describe the hardware and the hardware issue. Commit message description updated like below: The Aggregator TraceNoC hardware exposes CID registers, but the Component ID value read from those registers is 0 instead of a valid AMBA Component ID. As a result, the device cannot be identified by the AMBA bus and is not discovered as an AMBA device. Since the hardware does not provide a valid AMBA identification, describe the Aggregator TraceNoC using a dedicated compatible string and bind it to the existing platform driver. Thanks, Jie > > Best regards, > Krzysztof