From: "Andrew F. Davis" <afd@ti.com>
To: zhong jiang <zhongjiang@huawei.com>, <sumit.semwal@linaro.org>,
<benjamin.gaignard@linaro.org>
Cc: <lmark@codeaurora.org>, <labbott@redhat.com>,
<Brian.Starkey@arm.com>, <john.stultz@linaro.org>,
<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static
Date: Mon, 16 Dec 2019 08:01:14 -0500 [thread overview]
Message-ID: <c1244a5f-b82a-baee-262a-7241531036ad@ti.com> (raw)
In-Reply-To: <1576490904-18069-1-git-send-email-zhongjiang@huawei.com>
On 12/16/19 5:08 AM, zhong jiang wrote:
> Fix the following sparse warning.
>
> drivers/gpu/drm/ast/ast_main.c:391:22: warning: symbol 'ast_mode_config_mode_valid' was not declared. Should it be static?
>
The patch looks valid, but this commit message does not seem to match..
Andrew
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/dma-buf/dma-heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
> index 4f04d10..da2090e 100644
> --- a/drivers/dma-buf/dma-heap.c
> +++ b/drivers/dma-buf/dma-heap.c
> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
> return 0;
> }
>
> -unsigned int dma_heap_ioctl_cmds[] = {
> +static unsigned int dma_heap_ioctl_cmds[] = {
> DMA_HEAP_IOC_ALLOC,
> };
>
>
next prev parent reply other threads:[~2019-12-16 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 10:08 zhong jiang
2019-12-16 13:01 ` Andrew F. Davis [this message]
2019-12-16 13:36 ` zhong jiang
2019-12-16 13:38 ` [PATCH v2] " zhong jiang
2019-12-16 13:45 ` Andrew F. Davis
2019-12-16 21:13 ` John Stultz
2019-12-17 2:26 ` zhong jiang
2019-12-17 17:08 ` Sumit Semwal
2019-12-17 19:08 [PATCH] " Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1244a5f-b82a-baee-262a-7241531036ad@ti.com \
--to=afd@ti.com \
--cc=Brian.Starkey@arm.com \
--cc=benjamin.gaignard@linaro.org \
--cc=john.stultz@linaro.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=sumit.semwal@linaro.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®