From: Danilo Krummrich <dakr@redhat.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Boris Brezillon" <boris.brezillon@collabora.com>
Cc: intel-xe@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Oak Zeng <oak.zeng@intel.com>, Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Francois Dugast <francois.dugast@intel.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] Documentation/gpu: VM_BIND locking document
Date: Thu, 16 Nov 2023 15:02:17 +0100 [thread overview]
Message-ID: <c129fa94-6456-4746-9477-737a0fb61f96@redhat.com> (raw)
In-Reply-To: <0850281b667c4b88163dab60737dbc945ad742fd.camel@linux.intel.com>
On 11/16/23 12:48, Thomas Hellström wrote:
<snip>
>>> +Locks used and locking orders
>>> +=============================
>>> +
>>> +One of the benefits of VM_BIND is that local GEM objects share the
>>> gpu_vm's
>>> +dma_resv object and hence the dma_resv lock. So even with a huge
>>> +number of local GEM objects, only one lock is needed to make the
>>> exec
>>> +sequence atomic.
>>> +
>>> +The following locks and locking orders are used:
>>> +
>>> +* The ``gpu_vm->lock`` (optionally an rwsem). Protects how the
>>> gpu_vm is
>>> + partitioned into gpu_vmas. It can also protect the gpu_vm's list
>>> of
>>> + userptr gpu_vmas. With a CPU mm analogy this would correspond to
>>> the
>>> + mmap_lock.
>>
>> I don't see any drm_gpuvm::lock field in Danilo's latest patchset,
>> so,
>> unless I missed one version, and this lock is actually provided by
>> drm_gpuvm, I would mention this is a driver-specific lock. This
>> comment
>> applies to all the locks you describe here actually (mention which
>> ones
>> are provided by drm_gpuvm, and which ones are driver-specific).
>
> These will be needed also by gpuvm when implementing userptr vmas, so I
> can mention that drm_gpuvm is currently lacking a userptr
> implementation, so "the locks described below are to be considered
> driver-specific for now"
Since Xe already implements userptr support, are you guys maybe interested
in extending drm_gpuvm accordingly? :-)
next prev parent reply other threads:[~2023-11-16 14:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 12:49 Thomas Hellström
2023-11-15 15:11 ` Danilo Krummrich
2023-11-15 16:04 ` Thomas Hellström
2023-11-15 17:02 ` Danilo Krummrich
2023-11-15 17:18 ` Thomas Hellström
2023-11-16 9:48 ` Boris Brezillon
2023-11-16 11:48 ` Thomas Hellström
2023-11-16 13:27 ` Boris Brezillon
2023-11-16 13:53 ` Thomas Hellström
2023-11-16 14:47 ` Boris Brezillon
2023-11-16 15:01 ` Thomas Hellström
2023-11-21 8:41 ` Thomas Hellström
2023-11-16 14:02 ` Danilo Krummrich [this message]
2023-11-16 14:09 ` Thomas Hellström
2023-11-16 13:13 ` Bagas Sanjaya
2023-11-17 8:33 ` Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c129fa94-6456-4746-9477-737a0fb61f96@redhat.com \
--to=dakr@redhat.com \
--cc=boris.brezillon@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=oak.zeng@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®