mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>,
	dmaengine@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
	Vinod Koul <vkoul@kernel.org>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: fix a reference leak in __dma_async_device_channel_register()
Date: Mon, 29 Dec 2025 17:30:25 +0100	[thread overview]
Message-ID: <c12a697a-e777-42c5-8354-af8e3fba04d1@web.de> (raw)
In-Reply-To: <20251222040834.975443-1-lihaoxiang@isrc.iscas.ac.cn>

…
> +++ b/drivers/dma/dmaengine.c
…
> @@ -1102,6 +1103,7 @@ static int __dma_async_device_channel_register(struct dma_device *device,
>  	else
>  		dev_set_name(&chan->dev->device, "%s", name);
>  	rc = device_register(&chan->dev->device);
> +	dev_registered = true;
>  	if (rc)
>  		goto err_out_ida;
>  	chan->client_count = 0;
…

I find the additional variable assignment still questionable at this source code place.

Regards,
Markus

      reply	other threads:[~2025-12-29 16:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-22  4:08 Haoxiang Li
2025-12-29 16:30 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c12a697a-e777-42c5-8354-af8e3fba04d1@web.de \
    --to=markus.elfring@web.de \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=lihaoxiang@isrc.iscas.ac.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®