From: "Matias Bjørling" <mb@lightnvm.io>
To: "Javier González" <jg@lightnvm.io>, "Rakesh Pandit" <rakesh@tuxera.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lightnvm: propagate pblk_init return to userspace
Date: Fri, 21 Apr 2017 20:11:31 +0200 [thread overview]
Message-ID: <c12bf1b4-3629-7c71-31fd-55468bcee3da@lightnvm.io> (raw)
In-Reply-To: <F1FB4E37-23D4-4E6B-9310-78FA4699556C@lightnvm.io>
On 04/21/2017 05:07 PM, Javier González wrote:
>> On 20 Apr 2017, at 20.23, Rakesh Pandit <rakesh@tuxera.com> wrote:
>>
>> From userspace calling ioctl(NVM_DEV_CREATE) was returning ENOMEM for
>> invalid arguments even though pblk (pblk_init) was returning correctly
>> -EINVAL to nvm_create_tgt inside core. This patch propagates the
>> correct return value to userspace.
>>
>> Because pblk was introduced recently this only needs to go in 4.12.
>>
>> Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
>> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
>>
>
> Looks good.
>
> Reviewed-by: Javier González <javier@cnexlabs.com>
>
> Javier
>
Jens, would you pick this up as well? :)
next prev parent reply other threads:[~2017-04-21 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 18:23 Rakesh Pandit
2017-04-21 15:07 ` Javier González
2017-04-21 18:11 ` Matias Bjørling [this message]
2017-04-21 18:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c12bf1b4-3629-7c71-31fd-55468bcee3da@lightnvm.io \
--to=mb@lightnvm.io \
--cc=jg@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rakesh@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®