From: Markus Elfring <Markus.Elfring@web.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Aditya Pakki <pakki001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
kernel-janitors@vger.kernel.org
Cc: Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [v3] thunderbolt: Fix to check the return value of kmemdup
Date: Fri, 11 Oct 2019 16:13:22 +0200 [thread overview]
Message-ID: <c12d7c9c-8212-ba9b-252f-7dbb61698550@web.de> (raw)
In-Reply-To: <20191011133557.GF2819@lahna.fi.intel.com>
>> This source code analysis approach points out that the implementation
>> of the function “icm_handle_event” contains still an unchecked call
>> of the function “kmemdup”.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/thunderbolt/icm.c?id=3cdb9446a117d5d63af823bde6fe6babc312e77b#n1627
>> https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/thunderbolt/icm.c#L1627
>
> Right it misses that.
Thanks for your quick feedback.
> Feel free to send a patch fixing it ;-) Or I can do that myself.
Would you like to reconsider also the addition of the function call
“tb_sw_warn(sw, "cannot allocate memory for switch\n")”?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=9e208aa06c2109b45eec6be049a8e47034748c20#n878
Regards,
Markus
next prev parent reply other threads:[~2019-10-11 14:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 21:25 [PATCH v3] " Aditya Pakki
2019-03-27 14:36 ` Mukesh Ojha
2019-03-28 8:35 ` Mika Westerberg
2019-10-11 13:00 ` [v3] " Markus Elfring
2019-10-11 13:35 ` Mika Westerberg
2019-10-11 14:13 ` Markus Elfring [this message]
2019-10-11 14:42 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c12d7c9c-8212-ba9b-252f-7dbb61698550@web.de \
--to=markus.elfring@web.de \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®