From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751252AbdAPUs1 (ORCPT ); Mon, 16 Jan 2017 15:48:27 -0500 Received: from mail-lf0-f42.google.com ([209.85.215.42]:36756 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbdAPUsZ (ORCPT ); Mon, 16 Jan 2017 15:48:25 -0500 Subject: Re: [PATCH] net: constify mdiobb_ops structures To: Bhumika Goyal , julia.lawall@lip6.fr, pantelis.antoniou@gmail.com, vbordug@ru.mvista.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org References: <1484330546-16569-1-git-send-email-bhumirks@gmail.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Mon, 16 Jan 2017 23:48:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1484330546-16569-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 01/13/2017 09:02 PM, Bhumika Goyal wrote: > Declare mdiobb_ops structures as const as they are only stored in the > ops field of mdiobb_ctrl structures. This field is of type const, so > mdiobb_ops structures having this property can be declared const too. > Done using Coccinelle: [...] > Signed-off-by: Bhumika Goyal [...] > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 92d7692..1b0acd1 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -171,7 +171,7 @@ static int ravb_get_mdio_data(struct mdiobb_ctrl *ctrl) > } > > /* MDIO bus control struct */ > -static struct mdiobb_ops bb_ops = { > +static const struct mdiobb_ops bb_ops = { > .owner = THIS_MODULE, > .set_mdc = ravb_set_mdc, > .set_mdio_dir = ravb_set_mdio_dir, > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > index 00fafab..6ef5dd8 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -1052,7 +1052,7 @@ static void sh_mdc_ctrl(struct mdiobb_ctrl *ctrl, int bit) > } > > /* mdio bus control struct */ > -static struct mdiobb_ops bb_ops = { > +static const struct mdiobb_ops bb_ops = { > .owner = THIS_MODULE, > .set_mdc = sh_mdc_ctrl, > .set_mdio_dir = sh_mmd_ctrl, [...] For the above 2 drivers: Acked-by: Sergei Shtylyov MBR, Sergei