From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC03C433FE for ; Tue, 1 Mar 2022 11:23:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234273AbiCALYe (ORCPT ); Tue, 1 Mar 2022 06:24:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233337AbiCALYa (ORCPT ); Tue, 1 Mar 2022 06:24:30 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E151D92842; Tue, 1 Mar 2022 03:23:49 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB7B8ED1; Tue, 1 Mar 2022 03:23:49 -0800 (PST) Received: from [10.57.39.47] (unknown [10.57.39.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 373963F73D; Tue, 1 Mar 2022 03:23:48 -0800 (PST) Message-ID: Date: Tue, 1 Mar 2022 11:23:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] mmc: host: dw-mmc-rockchip: avoid logspam when cd-broken Content-Language: en-GB To: Peter Geis , Jaehoon Chung , Ulf Hansson , Heiko Stuebner Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220228223642.1136229-1-pgwipeout@gmail.com> From: Robin Murphy In-Reply-To: <20220228223642.1136229-1-pgwipeout@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-02-28 22:36, Peter Geis wrote: > The dw_mmc-rockchip driver drops a large amound of logspam constantly > when the cd-broken flag is enabled. > Set the warning to be debug ratelimited in this case. Isn't this just papering over some fundamental problem with the clock? If it's failing to set the expected rate for communicating with a card, then presumably that's an issue for correct operation in general? The fact that polling for a card makes a lot more of that communication happen seems unrelated :/ Robin. > Signed-off-by: Peter Geis > --- > drivers/mmc/host/dw_mmc-rockchip.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c > index 95d0ec0f5f3a..d0ebf0afa42a 100644 > --- a/drivers/mmc/host/dw_mmc-rockchip.c > +++ b/drivers/mmc/host/dw_mmc-rockchip.c > @@ -50,8 +50,13 @@ static void dw_mci_rk3288_set_ios(struct dw_mci *host, struct mmc_ios *ios) > cclkin = ios->clock * RK3288_CLKGEN_DIV; > > ret = clk_set_rate(host->ciu_clk, cclkin); > - if (ret) > - dev_warn(host->dev, "failed to set rate %uHz\n", ios->clock); > + if (ret) { > + /* this screams when card detection is broken */ > + if (host->slot->mmc->caps & MMC_CAP_NEEDS_POLL) > + dev_dbg_ratelimited(host->dev, "failed to set rate %uHz\n", ios->clock); > + else > + dev_warn(host->dev, "failed to set rate %uHz\n", ios->clock); > + } > > bus_hz = clk_get_rate(host->ciu_clk) / RK3288_CLKGEN_DIV; > if (bus_hz != host->bus_hz) {