From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.174 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793542444; b=r+VdfTmdckcXiXhRlsiQzJWn1USWBTY1QU8wB9RJSk7+XhTop1jh29yDBQksNjfllBrG Z8rfSZfIDgs0tb/n6jRi7wY0EwnxQxat3NALP1IdqK+fottMiQU9qTSTTS0C967xZwSVX hBt3rMsCD0ODR9xzwqvh5xAUJZg0B98pUjfsimjjQODxsj2SgPn3C1l6P3rLs3pHS98kI cdAvvsIP57ETtMD9citSoFT1LSRV7v5TiyzBPMhfEV4Ka60cEmwyvbRvLUJsj+4YvSiol hlrSv9a87dpjra5uMngpokV0FRvnFy0hTku5n70TFGMiXBZgWtQjI9cab0zWSyNjetQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793542444; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=908fhrM1HlZfTYgmWBBmx3EXBJTSRYE/1Nc7g2kDk98=; b=ujv0zn2B1BZipkE5fuUAF5LLnaPALBevWc4i7wldt4OvIZC6NLE9woFjq9Zf0hzF8a4F wBezlGjZvppNzCNtQX+LVevRUkRraEkka8rf4SvrK5ww6OQFJN5PFS2mMYMLcExIs50tB QlobEEY9dd/DZOjIXTm+OCPeMG7y58o7KQtKmlC2u6BlBNIhbz8OL80PsP4nCx4YWDYUH e09yg0Mmxb8tJW8BNsALnhIZiMNhyyXrTLRfzs+mYzBPJlzDBxXfhaUmnWOFVOJJvScMA yKTUXPvNJcTrXNVHXbCBbvAOxQVDso/s0tMR5iYOVKEZnsVuPNQ8pLuFF7h8h9PtifA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=SOBq+xfr; arc=none smtp.remote-ip=91.218.175.174 Received: from mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D09FA606A324 for ; Sun, 1 Nov 2026 14:14:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D09FA606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=SOBq+xfr X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=cYMHJdYJyH2hnxqe0M9Ky2nfXrZcnOvPqcgoIDJjcvI=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793542441; v=1; x=1794147241; b=SOBq+xfraJJp8nTTBpTv50QeDYHVixvYawFSkryoSeO9lxAoWZZsWP45cXImuCjYTZSCDQE4 FoqyVqo2Y0Q7Oa3xEfp7ix9qetMW+9Og3dDrTLCbZpjUwVenP+Zo1pwm4zK0p7z3u6ut/85Pf0x 0S/bBBs7WuU/RI9kY8PMan0A= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id a05e464f0524c77c; Sun, 01 Nov 2026 14:14:00 +0000 X-Mizu-Trace-ID: a05e464f0524c77c X-Migadu-Flow: FLOW_OUT Message-ID: Date: Sun, 1 Nov 2026 14:14:00 +0000 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/14] drm/tidss: oldi: Fix cleanup on a failed init To: Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Nishanth Menon , Vignesh Raghavendra , Swamil Jain , Devarsh Thakkar , Louis Chauvet Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20261029-beagley-ai-display-v4-0-dc7f2b532478@ideasonboard.com> <20261029-beagley-ai-display-v4-9-dc7f2b532478@ideasonboard.com> Content-Language: en-US From: Aradhya Bhatia In-Reply-To: <20261029-beagley-ai-display-v4-9-dc7f2b532478@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Tomi, On 29/10/26 10:18, Tomi Valkeinen wrote: > tidss_oldi_init() registers a bridge for each OLDI TX in turn. If a later > OLDI TX fails, the bridges registered for the earlier ones are not > removed. > > Fix this by calling tidss_oldi_deinit() in the error path. > > Fixes: 7246e0929945 ("drm/tidss: Add OLDI bridge support") > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/tidss/tidss_oldi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tidss/tidss_oldi.c b/drivers/gpu/drm/tidss/tidss_oldi.c > index 506507e83112..7344d86e1f13 100644 > --- a/drivers/gpu/drm/tidss/tidss_oldi.c > +++ b/drivers/gpu/drm/tidss/tidss_oldi.c > @@ -638,5 +638,6 @@ int tidss_oldi_init(struct tidss_device *tidss) > err_put_node: > of_node_put(child); > of_node_put(oldi_parent); > + tidss_oldi_deinit(tidss); > return ret; > } > Since tidss_probe() (in tidss_drv.c) calls tidss_oldi_init(), it also calls tidss_oldi_deinit() in its error exit path. I think this patch is not required. -- Regards Aradhya