From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010041.outbound.protection.outlook.com [52.101.56.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A235330B04 for ; Tue, 20 Jan 2026 03:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.41 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768880052; cv=fail; b=JDqjPcXXM3JTRLhZCjI6mAbaK3/tXoChVQZ+Rsq8UDUBvwRAbf0NMsyJpyX+LzzZ5+YhivbRzhEbpyGYg36XHqeqNRQVuzXTmM/hKWRWZo+RkopZkHyENRxdnVqatJd6BwY9kczy9HCXcTCOhyBuknY/b+706dc6XFcBVBDyZgY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768880052; c=relaxed/simple; bh=gQEq3hT/qo+Up5HSLikpTdZweuQ/L0gzTvsSkIabZxQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=sba/D1Nod39w6TroCUIpWxVVRXie7jfmcxIUHv/l+hTkrAi28NbABf4P0xlZE/yoAOYIsotzxjaRIE2Xqo+XCwIQDny+6t6OAY3abPXXqVEaOgnBNB0aTsYX2DU54m2mO5ztTQw4i3H6LjLmenX/dWLnHzvgybjBIvwcZt6l0Vg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=gM9RUg5H; arc=fail smtp.client-ip=52.101.56.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="gM9RUg5H" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lGywj/LvnWPSHYQi92FjayaqNkgHfDsfl0JbMaaIqErEHXwn2m+3fyFx09YZOXrweOabBMWTRbqLSHqxZ9kX1E3FoDrgblVHlHc4DFZcTf1kJ7qnMB74mnwYavB1PcXhlWhEneR55vMwEOpfHWLazLxzXx2MJ17p8CbVAnUUd0UpeTUlqY7UN5ItGtJJa2AACKXn3hEs5uprOFM1pbUgYW9wF0PcszGFplwBPD6jWu3o2EponqqM7awLZGaV29tp1ymkEi3cpisRnJX4Rs/v9JTvSKRXuu4NTPDfKNlz0/nU3NtNdZ6p0F6tTyDeyBVr28peYj5vwJeCg0y/2O70sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FvC/HP37X3KwTbUWn5upxUGuj19GaMeUspyho7UuRJ8=; b=iU8bnkBAqzbfLtbKKWcgSenXYbonzZ+tYL7hP1iP97och4xUuhB3Erx8MsNOe8kKrBzJ8yBWmJW2l2ExWp+PaUThHnurBDP03AhYzLSdhZKS8rbgHL46t7X3dbYGMj+sMbEyPhlQy3Hss90iF9PqdHzGyWVBFPnzMyqHzzMeU74v/dKgEQ95FSGiGF/xTy26DyoS4bAWgOmM+d6Q10qQZdOf0gHTCdWuKvYAGQITw7KafvhbIJ1yKJx3TvLRkLjq00Aq5YFLNz8sxweA3lCxL5qmGi96lXZUUC/dKugMeKpHEjsWlCoIvahAed6PlK8cjaP0IMBnbS9T1haEe7QITA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=huawei.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FvC/HP37X3KwTbUWn5upxUGuj19GaMeUspyho7UuRJ8=; b=gM9RUg5HZb16yXFkhUiNunp210hfaN9eu965PPw9p6y58jSz5lfMz6jHb8I4BrlwotBmU2ldFgtdx0rKBTm8+ZDvGbcthPFFQN1jTiss9QlIdgOLfa8DjmhP8Htonmp4biBFMfWNNiA2XzD/im8TBtca4Iao2814zv/VtN4GKEk= Received: from PH3PEPF0000409F.namprd05.prod.outlook.com (2603:10b6:518:1::4f) by LV8PR12MB9619.namprd12.prod.outlook.com (2603:10b6:408:2a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.12; Tue, 20 Jan 2026 03:34:05 +0000 Received: from SJ1PEPF000023D9.namprd21.prod.outlook.com (2a01:111:f403:c902::13) by PH3PEPF0000409F.outlook.office365.com (2603:1036:903:49::3) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.8 via Frontend Transport; Tue, 20 Jan 2026 03:34:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF000023D9.mail.protection.outlook.com (10.167.244.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.0 via Frontend Transport; Tue, 20 Jan 2026 03:34:04 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 19 Jan 2026 21:34:00 -0600 Received: from [10.136.37.139] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 19 Jan 2026 21:33:57 -0600 Message-ID: Date: Tue, 20 Jan 2026 09:03:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched: Re-evaluate scheduling when migrating queued tasks out of throttled cgroups To: Zicheng Qu , , , , , , , , , , , , CC: , References: <20260119133008.161216-1-quzicheng@huawei.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260119133008.161216-1-quzicheng@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D9:EE_|LV8PR12MB9619:EE_ X-MS-Office365-Filtering-Correlation-Id: 768307fd-e925-4bcd-9ea2-08de57d4c29f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|82310400026|36860700013|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a3lIek1PRGdmM0dVNnA0UDF5Y0NkbXM1VklVdm5OY2krcGpxQ1VoWTcwaHl2?= =?utf-8?B?NnFQRGgvbTY3VHhNVS9JZFZkL3FEMmh5YWh3SGlRSUxnTXNuU1laR3FiRFJR?= =?utf-8?B?ZVlUZXVDVFFFUHZNSk1Jb2ZLenp1bkNGQzVUU0dMbkFEZ1RFYlBRK1RhZ2JO?= =?utf-8?B?SlpGM2FHSjA3NU9lK2YyT0VESzBXUTlIN3Q1eE04WWJ6Z0xiY2VuenNjZHdn?= =?utf-8?B?dS9YamdFT1RGbEE0ZHZrWnBMWi80SFNqUnhpRzZHbkNYMnJac1RyRjBSUnF2?= =?utf-8?B?MGxyUVArUzJrdEwwbzA4S2RYb1drRXlNQjNsUkF6eXA5YmNDSkhxSStEWXdi?= =?utf-8?B?STRLQ3RKZkJlc0Q4dTMrMGFXTXBrMVNpbEFoRkJHVFBaaGQxQ0FDTjRGbjFW?= =?utf-8?B?Q0Q0ektRVWl1b1FiWFpGS0Y3cVVyK1ZySExlVTFMMkczU1dwc1lOT1NsOXJG?= =?utf-8?B?V3J3VytwTkxGUDdIN2gySTlwMkU2U09VejlHa05YZlFqdGZCZFpzUHd1R3ZV?= =?utf-8?B?eFZnaVJZUlBPMW1JWXdBaWxKWTlCb3dxTENnMWZkbHoyWCsvRjZTK3dYY3hP?= =?utf-8?B?OUhrclg1citlUXdUZU1yY3VyNDlUS3V6RmlOdzRERWd1eTlJc2ovNlJHY2Rh?= =?utf-8?B?MzRRRmRyejROaDV2OUlPY29ZbzB6cFd4YVE5bnhMMHJGbm85NTFPMjh6emts?= =?utf-8?B?TWJsM0ovRzV1RWdSQlh2bmtHOEFKMWl4aTVrVHJnOW1GeXBhVnptejNSdkwx?= =?utf-8?B?NHpPc2wwMCtBSDdJYnhpVjF5OVcxN3A2dW9rREROdGxlYUVjMjlNZnRTanFS?= =?utf-8?B?bkszaXJ3TjBUcWg3SVgwR3VFL0VpRFRtMCtJSGhxaW9rYTM1eTJJcnZ5U2pm?= =?utf-8?B?TEV3NFBxY0g0QkVMWE5UYkp2eURBNm1qWkpkUTU5b0xuS2RDbHBySEpLekVN?= =?utf-8?B?MWEvKzIyL3VOVSs2WjUxNlQyT08xZk9ERGEzTytWL2tGcXJPNXBrUDhIcTQw?= =?utf-8?B?MTlJWlNWenZBVFIwYTdIUGZoemJXRlJadUV0VFJtRWw3WDh6Y3hlSzB6Y0Fq?= =?utf-8?B?R1JoSGF3UzlwTDRHSEFEd3liSVFYV3RrRWEyd2g4SzZTa3dINUxWSndEbFpQ?= =?utf-8?B?alZUTmw1ZlN3TkwvTGlpd3VvZXdYeUNVZXZwL2NoVHVVSlFIK3lRaXNNVWN6?= =?utf-8?B?WWFlM1lFekxOb3NvSDhUUzJHaUNxV2VCb1BCeDNDb20xUGs5OXFJVm03NTVW?= =?utf-8?B?WWdNbTA2ZDdOS211dnJRYnpuQXBFdCtVZkVpbVM0eGRjNVRFRmVUY29WM2Vv?= =?utf-8?B?aDBiLy8xaHRyZTdBNzBDYW9QNjlMN1R2SHM0ZzR3YmxTOWpXRWpIa3h3VE95?= =?utf-8?B?SXp2UFdmYVF6K3hNc1lSbUFJa3M1MXE5UHNrY3ZHd0kyc2huUWRFWFpYTWNl?= =?utf-8?B?VXZEUmZTZHVwbWsySGxQVWdnM01jRUhPOFV2U0U0bkdZYkZOYU85MFUyeDhO?= =?utf-8?B?TjB1dStIalZNdEE5M3VyMDkwTXF5VHdQZ3dLem1obDdCVnBidEFwT0F1TmlK?= =?utf-8?B?c2NXRHppbENkRnM4dFBydUl1QlZKYzUwYStiNHVhb3ZkM2lCQ016ZTkxUkZD?= =?utf-8?B?RjFVSm84bWI5dzIvVzFmc1E3c05WQWRsRWZoeXVhdXZmOElhSkh2RWxBODRi?= =?utf-8?B?VXlDc2w3SnJZTTV0cnpORjBYdVZWSDJxcU9sd2R6aTQ4RkR5aFRPakVoVDRO?= =?utf-8?B?eCtFdTQ0VHZtaUZjOGpsdjBjL253U1pBL2s1WnlDaXFGUGdHd0RWekc1NStT?= =?utf-8?B?SVozRDJSeVhJRFBXTi9vOUJlUG1KUjdLV0RDZUNpUVNaVlFnUFNJb1dDdSs5?= =?utf-8?B?ZzkvMU9salVUNllrWUdKVCtLZklrTWo2MmhEZDZhR3cyTEpiNVJTZzJmK3Aw?= =?utf-8?B?L292dHRPL1YzejA2TmR0eExKSDdNcVpFSENCeXo0UWZHRzN6bU5aT1hXQ1I3?= =?utf-8?B?cHRQOGtqUm1sS1Zqam01UVdnY0p3a3g4TlBnNmR1OTdNeFYrRSs5Y2tOTlI3?= =?utf-8?B?aWZaa1J6VnBiVEY5OG90bUl4N3BuOHFtZEVFSXdNbnlWZzhCejB0SU5hR2Vq?= =?utf-8?B?d3hMcFFvKzdobjUyeUtFMnV3WmhjVi8yT0h5MXdsOFMwRzl6S2dIMXp2NnBy?= =?utf-8?B?SWEvOXRMZ2xWa2pZSVNXaHVqZTA4TlVQYjdxMmR0Z2pkSk8zWkJsRHJLR3I4?= =?utf-8?Q?MVkre1GrIgF98BkUePZ+hQr2h4upCpVJRUlcaav0qs=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(82310400026)(36860700013)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2026 03:34:04.1856 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 768307fd-e925-4bcd-9ea2-08de57d4c29f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D9.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9619 Hello Zicheng, On 1/19/2026 7:00 PM, Zicheng Qu wrote: > @@ -9120,12 +9121,16 @@ void sched_move_task(struct task_struct *tsk, bool for_autogroup) > sched_change_group(tsk); > if (!for_autogroup) > scx_cgroup_move_task(tsk); > + if (scope->queued) > + queued = true; nit. This can just be "queued = scope->queued" Other than that, this fix looks good. Feel free to include: Reviewed-by: K Prateek Nayak > if (scope->running) > resched = true; > } > > if (resched) > resched_curr(rq); > + else if (queued) > + wakeup_preempt(rq, tsk, 0); > > __balance_callbacks(rq, &rq_guard.rf); > } -- Thanks and Regards, Prateek