From: Guenter Roeck <linux@roeck-us.net>
To: Naresh Solanki <naresh.solanki@9elements.com>,
Jean Delvare <jdelvare@suse.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus/core): Generalize pmbus status flag map
Date: Wed, 18 Jan 2023 08:24:18 -0800 [thread overview]
Message-ID: <c136cef0-273c-4018-238c-6901da86b2d8@roeck-us.net> (raw)
In-Reply-To: <e20695a6-0c48-4131-cf7d-111f727f07e6@9elements.com>
On 1/18/23 06:36, Naresh Solanki wrote:
> Hi Guenter,
>
> On 18-01-2023 07:13 pm, Guenter Roeck wrote:
>> On 1/18/23 03:15, Naresh Solanki wrote:
>>> Move the PMBus status flag map (pmbus_regulator_status_flag_map)
>>> outside of the regulator #if block and update the associated
>>> variable/struct name to reflect a generic PMBus status. Also retain
>>> the regulator error flag for use in determining regulator specific error.
>>>
>>> This will make the PMBus status flag map more versatile and easier to
>>> incorporate into different contexts and functions.
>>>
>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>
>> Sorry, I don't see the point of moving a structure including
>> regulator error codes outside regulator code.
> I'm working on adding pmbus irq handler.
> Since irq handler is regulator independent, this change is needed.
>
Please submit the necessary patches together. I can not accept patches
introducing structural changes like this without use case.
Thanks,
Guenter
prev parent reply other threads:[~2023-01-18 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 11:15 Naresh Solanki
2023-01-18 13:43 ` Guenter Roeck
2023-01-18 14:36 ` Naresh Solanki
2023-01-18 16:24 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c136cef0-273c-4018-238c-6901da86b2d8@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®