mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Souvik Banerjee <souvik1997@gmail.com>
Cc: Eric Biggers <ebiggers@google.com>,
	"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Shaohua Li <shli@fb.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blktrace: fix comment in blktrace_api.h
Date: Fri, 30 Mar 2018 14:17:07 -0600	[thread overview]
Message-ID: <c13a34d5-9e4f-6c57-2b56-63dcb6c9ae27@kernel.dk> (raw)
In-Reply-To: <20180330193243.26044-1-souvik1997@gmail.com>

On 3/30/18 1:32 PM, Souvik Banerjee wrote:
> The `__u64 time` field of the blk_io_trace struct refers to
> the time in nanoseconds, not in microseconds. It is set in
> __blk_add_trace, which does the following:
> 
>     t->time = ktime_to_ns(ktime_get());
> 
> ktime_to_ns returns ktime_t in nanoseconds, not microseconds.

Thanks, applied. Back way back when it used to be in microseconds, iirc,
I'm guessing the comment dates to back then.

-- 
Jens Axboe

      reply	other threads:[~2018-03-30 20:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30 19:32 Souvik Banerjee
2018-03-30 20:17 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c13a34d5-9e4f-6c57-2b56-63dcb6c9ae27@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=ebiggers@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=rostedt@goodmis.org \
    --cc=shli@fb.com \
    --cc=souvik1997@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®