From: Lars-Peter Clausen <lars@metafoo.de>
To: Alexandru Tachici <tachicialex@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jic23@kernel.org
Subject: Re: [PATCH v3 3/4] iio: accel: adxl372: add additional events ABIs
Date: Wed, 18 Mar 2020 11:15:52 +0100 [thread overview]
Message-ID: <c140a2ab-2da8-2c56-3ab6-193bb52a46cb@metafoo.de> (raw)
In-Reply-To: <20200318110958.8621-4-alexandru.tachici@analog.com>
On 3/18/20 12:09 PM, Alexandru Tachici wrote:
> Adxl372 uses the standard event interface. The additional
> ABIs aim to explain to the user that the values set in
> ./events/thresh_falling_period and ./events/thresh_rising_period
> control the state of the device, not just the events timings.
>
Hi,
I'm not convinced this is a good idea. Since this is non-standard ABI
the user would likely have to consult the documentation to figure out
what this means. So we might as well document in the documentation that
for peak mode the thresholds are configured through the event API.
- Lars
next prev parent reply other threads:[~2020-03-18 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 11:09 [PATCH v3 0/6] iio: accel: adxl372: add peak mode Alexandru Tachici
2020-03-18 11:09 ` [PATCH v3 1/4] iio: accel: adxl372: Add support for FIFO " Alexandru Tachici
2020-03-18 10:10 ` Lars-Peter Clausen
2020-03-22 15:54 ` Jonathan Cameron
2020-03-18 11:09 ` [PATCH v3 2/4] iio: accel: adxl372: add event interface Alexandru Tachici
2020-03-18 10:06 ` Lars-Peter Clausen
2020-03-18 11:09 ` [PATCH v3 3/4] iio: accel: adxl372: add additional events ABIs Alexandru Tachici
2020-03-18 10:15 ` Lars-Peter Clausen [this message]
2020-03-18 11:09 ` [PATCH v3 4/4] iio: accel: adxl372: Update sysfs docs Alexandru Tachici
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c140a2ab-2da8-2c56-3ab6-193bb52a46cb@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tachicialex@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®