From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 439142D060C for ; Tue, 27 Jan 2026 03:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769483018; cv=none; b=YCRg7+33OAZXLI1zDN+LyEY4kACTbasSoO3HO5zwM/zGBlf5LTA/0SVKw7N3RvIDdPfyJeHv56jmp4HU1GuYj1lKWOJ29oBWyjdSZXxk56eo8YcNw4qTkx3M2FMFukObyxkDYXQSJaxGc6i5W5+k2D6Lnk+li8cEET/rv3cB9bI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769483018; c=relaxed/simple; bh=syYL5VtEW+c/TcVWBtxlN6YnmRdtpQNmgJWhYxG0Grg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dj7+jWvWJWLCo4lwRp2ehcmz9F3o1XzMlwASZhXiu+wHkOzQmvqwO2D9KMUKA2Q5PUSyAOSvib1RaXd0+ttV4wtTIRvOAYjhqDJO6n9nOtVxEYQhLPlGj6vlsFrsoztDakEDHhhZQXWtw11HmKDJZq0aBOqWLn75Zs+RYcUWq8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a8gc2ohD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hMgxIrCk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a8gc2ohD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hMgxIrCk" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60QKgL5H2880242 for ; Tue, 27 Jan 2026 03:03:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QdW4mzL5aTNRFJ61i5C454TjCOALyCkxZNzJk0cSbXQ=; b=a8gc2ohDbTCBWL/y fb2amVhZMcgeDXLTtnY0wNOnIg1cBkWk4lwGvXsRi6tglaxj1BY03xKbVKEEdB7+ 4m1jyMzmjtRskH8hpQfyOWHHAQZJWNAPUq/BJyMtDU/uFgjVThnhjqq7DR4lI7wD bak8tqIjmDZk2UvM9Sof7A6lMLco+GtDaByVZsVVYweY34UZFwo6AqTNuAbJ3yD/ UeqQTDZoFDuPg5AFOGRWkZx9y0kXtsvL21+ScGxB3TVJaOJaVmnYhdYbYNjqSOr/ VT34RUtEgYxIRaBrcx7H+9aYnZzjh+dxgHRPbiaYM/x8EOQZeQrj90Gq62ocusDL 0M21/A== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxffs0unr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 03:03:36 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a7701b6353so51620215ad.3 for ; Mon, 26 Jan 2026 19:03:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769483015; x=1770087815; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QdW4mzL5aTNRFJ61i5C454TjCOALyCkxZNzJk0cSbXQ=; b=hMgxIrCkJ219Rotxt249kDDy5qMAs8jO65S5MNCKhwo4IKTChHmZNVNjQ5zZFXQ9rF DCCodBibqdgnqLgO2xHvRrOb3imKQ/NNojKcC2fm5UUr+96pDEr7RcwDkB/JQAb5tGnT l+4/tnCp5c48phHjcESL9zQGMTL0SYVUZ/qd+t/rQtiDrHcKurkmETSo0Xtf+yqCiSBa C+PDGThk4xmqpBy+6uQgrwEPo5es//1Z2JOgFVginY/LAr9RI83taJ+DJUerLy+ZVGiF QtRyjcAPJ5Yi+Bp/c3a35ghJuaPu+8+7geFce3mObUOoEqec6m9wdqu54O1OflR0qGuw +rdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769483015; x=1770087815; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QdW4mzL5aTNRFJ61i5C454TjCOALyCkxZNzJk0cSbXQ=; b=j0hnPY+TVBMzf6Cj2LM38FxsT8Q0+lqQ/021UDEIPQOykkt20iywpSVIX7PlI2jp7r ++NgtjrkPX413b/+h6qSAOgpocPrEHjkv95sUNDj/gDRKlVdMCpkMVcFlCgsG7Hvts2C YpHXyENvLSeyOW8IFfvrQpvriEG4+zcGNc1V+nDiJ40jkQwLf9b8CwV5/ddLDIsPEpI3 B050TClheyNxhv7C/26rtSEqOVbM0qXHDCbqRb2trT6YWf1b9cVSN3nNotMMiWTwsfRJ J3m29DkOV863KX7Io3Vm7QhWegK8qTdH1xei4gFxfF4zgZ37Ier2GW3WO2+KjwnJ6R5c lZJQ== X-Gm-Message-State: AOJu0Yx6F3xw+a3NJN+oTg0acjLrtH96nn7dUrLpb1PYp8siKmwgTjdw xUEyp/2kIw9x9VIWQ1xQvJ25C7blinzQqkpheHSf4NBbuEifMKAn+OiRuW4W7C1431x4usE83sN qdW1/9oe70mLLPLfR9IAt6QwneNbs96R4XNdmf/T0aqFvWeqMmaZR+PKYotrj3lNtkh8= X-Gm-Gg: AZuq6aLK7qfs+0yKYLZc6e36c83ixU8JZsAy/GJrw7tncfHfil6BrfySBDSEJfJDXiy Jamt8unweXSC0hWBTK37IceBQMzMFSevIhyH8S355lQDtb+p+PlkzkuICVmETccXzYE22JqvCnj QiKv9LEq03qnHuC/2H5LGD1I6OAxOewLsJdUjTJVRNDuuzZOjoxi/XGVUnqilwgpsrQeHJv1+6x DD1WP3ucEB/ZV/Jd4Xwy0JVswEYEl0fag35D4Vb5veexUeb3XweiiTpu5fraYa0uyUls/m1I+JI PxTlGtKfJpXZLpgWKfJQg+cawvYgMSnqP7+VymPQnYjKj2OE//wXChUEGI12iwJmofkm0v1EqVA 0ov3uI+fifVdn3D83Sjtv2vbd7dSv/sXNas9dDv0= X-Received: by 2002:a05:6a21:1507:b0:350:2251:59f with SMTP id adf61e73a8af0-38ec63ea717mr112682637.38.1769483015079; Mon, 26 Jan 2026 19:03:35 -0800 (PST) X-Received: by 2002:a05:6a21:1507:b0:350:2251:59f with SMTP id adf61e73a8af0-38ec63ea717mr112649637.38.1769483014576; Mon, 26 Jan 2026 19:03:34 -0800 (PST) Received: from [10.239.133.242] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c635a425254sm9558200a12.29.2026.01.26.19.03.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 19:03:34 -0800 (PST) Message-ID: Date: Tue, 27 Jan 2026 11:02:30 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 6/7] qcom-tgu: Add timer/counter functionality for TGU To: Konrad Dybcio , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20260109021141.3778421-1-songwei.chai@oss.qualcomm.com> <20260109021141.3778421-7-songwei.chai@oss.qualcomm.com> <05637034-19f0-42cd-9352-3daf80ae4a1d@oss.qualcomm.com> Content-Language: en-US From: Songwei Chai In-Reply-To: <05637034-19f0-42cd-9352-3daf80ae4a1d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: EDDVVqRdRd0PD5gQWrKPAwLpOmrjkU6I X-Authority-Analysis: v=2.4 cv=YpcChoYX c=1 sm=1 tr=0 ts=69782b08 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=5nTtrOYU0cHVv66wLwoA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: EDDVVqRdRd0PD5gQWrKPAwLpOmrjkU6I X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDAyNCBTYWx0ZWRfX5A0wzZSl1ks5 5dAGOMn+9mzdvZz0xDE1j25LK12U42ac29ZcH4EGsVIrJTMuHppbM7k4VL3CwyqCnFKj9Xm2ffD GA0v0NMNgWsjw7iEm9DT/6juQuWT8CNbeHDhGEZRXoFSSHQmLzmu68/BFukbuVMRj163+3iC3Gm bSwEFJNkJMkhL1ayHZsZImcvEkVwmFh2h1wpMQmHYEC/1nCARSGYcdsvweu2AOIJ3pQK95kcjnz PjU+AjXGK4zPMqPXscPXfyP1G1k/GM36txHctel1Y1XAyzDrR5IMx0sbdC1iBzIDzg3GqVjmgfc Jlgajrvqk2IIzI6laNNm9FUc4ZUuBicfPV4+AIfJUJcgfiLb7L3XdaMRy0UYbLKCa1zJWrYexe2 bKH8t99sQgqAHq4VGaflh3GkwaK3lKYDdyJTSok0nguxTv0Ine1pO57XKYK9WazlJSIzFXaXApH 6C1P+g6r8I8513nhUbg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-27_01,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270024 On 1/13/2026 7:19 PM, Konrad Dybcio wrote: > On 1/9/26 3:11 AM, Songwei Chai wrote: >> Add counter and timer node for each step which could be >> programed if they are to be utilized in trigger event/sequence. >> >> Signed-off-by: Songwei Chai >> --- > > [...] > >> +static void tgu_set_timer_counter(struct tgu_drvdata *drvdata) >> +{ >> + int num_timers, num_counters; >> + u32 devid2; >> + >> + devid2 = readl(drvdata->base + CORESIGHT_DEVID2); >> + >> + if (TGU_DEVID2_TIMER0(devid2) && TGU_DEVID2_TIMER1(devid2)) >> + num_timers = 2; >> + else if (TGU_DEVID2_TIMER0(devid2) || TGU_DEVID2_TIMER1(devid2)) >> + num_timers = 1; >> + else >> + num_timers = 0; >> + >> + if (TGU_DEVID2_COUNTER0(devid2) && TGU_DEVID2_COUNTER1(devid2)) >> + num_counters = 2; >> + else if (TGU_DEVID2_COUNTER0(devid2) || TGU_DEVID2_COUNTER1(devid2)) >> + num_counters = 1; >> + else >> + num_counters = 0; >> + >> + drvdata->max_timer = num_timers; >> + drvdata->max_counter = num_counters; > > int num_timers = 0, num_counters = 0 > > if (TGU_DEVID2_TIMER0(devid2)) > num_timers++ > > if (TGU_DEVID2_TIMER1(devid2)) > num_timers++ > > etc. > > unless you want to guard against a case where TIMER0 reports as absent > and TIMER1 as present and you consider that invalid (I don't know) Based on the current documentation and the hardware we have encountered so far, this case - "TIMER1 present, TIMER0 absent" does not occur. > > [...] > >> + timer_size = drvdata->max_step * drvdata->max_timer * >> + sizeof(*(drvdata->value_table->timer)); >> + >> + timer = devm_kzalloc(dev, timer_size, GFP_KERNEL); >> + >> + if (!timer) > > stray \n sure. > >> + return -ENOMEM; >> + >> + drvdata->value_table->timer = timer; >> + >> + counter_size = drvdata->max_step * drvdata->max_counter * >> + sizeof(*(drvdata->value_table->counter)); >> + >> + counter = devm_kzalloc(dev, counter_size, GFP_KERNEL); > > devm_kcalloc, perhaps? Agreed. Using devm_kcalloc() makes the intent clearer and safer here > >> + >> + if (!counter) > > stray \n sure. > >> + return -ENOMEM; >> + >> + drvdata->value_table->counter = counter; >> + >> drvdata->enable = false; >> >> pm_runtime_put(&adev->dev); >> diff --git a/drivers/hwtracing/qcom/tgu.h b/drivers/hwtracing/qcom/tgu.h >> index 8c92e88d7e2c..94708750b02d 100644 >> --- a/drivers/hwtracing/qcom/tgu.h >> +++ b/drivers/hwtracing/qcom/tgu.h >> @@ -11,11 +11,17 @@ >> #define TGU_LAR 0xfb0 >> #define TGU_UNLOCK_OFFSET 0xc5acce55 >> #define TGU_DEVID 0xfc8 >> +#define CORESIGHT_DEVID2 0xfc0 >> >> #define BMVAL(val, lsb, msb) ((val & GENMASK(msb, lsb)) >> lsb) > > This is NIH FIELD_GET() > ok, will try to use "FIELD_GET". > [...] > >> static inline void TGU_LOCK(void __iomem *addr) >> @@ -197,6 +247,8 @@ static inline void TGU_UNLOCK(void __iomem *addr) >> * @max_step: Maximum step size >> * @max_condition_decode: Maximum number of condition_decode >> * @max_condition_select: Maximum number of condition_select >> + * @max_timer: Maximum number of timers >> + * @max_counter: Maximum number of counters >> * >> * This structure defines the data associated with a TGU device, >> * including its base address, device pointers, clock, spinlock for >> @@ -213,6 +265,8 @@ struct tgu_drvdata { >> int max_step; >> int max_condition_decode; >> int max_condition_select; >> + int max_timer; >> + int max_counter; > > num_timers, num_counters definitely fits better here > uhh.. yeah. > Konrad