From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Conor.Dooley@microchip.com, Daire.McNamara@microchip.com,
a.zummo@towertech.it, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: mpfs: Use devm_clk_get_enabled() helper
Date: Wed, 24 Aug 2022 15:25:30 +0200 [thread overview]
Message-ID: <c14607d5-337c-3e75-2b95-720553f40282@wanadoo.fr> (raw)
In-Reply-To: <YwYZZWu3gOBIPJeI@mail.local>
Le 24/08/2022 à 14:28, Alexandre Belloni a écrit :
>
> BTW, I thought you actually tested your changes on the other patch I
> took, not that you were doing a blanket conversion of the subsystem.
> This is the kind of info that must appear in the commit log. I would
> definitively not have taken the patch.
>
Ok, noted for future contribution.
In fact I first sent only one patch to see if it got some interest for
such transformation.
I only sent some other after your Ack.
Nothing is never trivial, but such patches looks fine to me.
It saves some LoC, reduce the size of the .o and slightly saves some
runtime memory.
And unless, I missed something, the order of operation remains the same,
both when resources are allocated and freed.
Why wouldn't you have taken such a patch?
(just for my understanding and in order to avoid spamming others with
useless/risky stuff)
CJ
next prev parent reply other threads:[~2022-08-24 13:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 8:18 Christophe JAILLET
2022-08-24 9:58 ` Conor.Dooley
2022-08-24 10:53 ` Alexandre Belloni
2022-08-24 12:27 ` Conor.Dooley
2022-08-24 11:27 ` Christophe JAILLET
2022-08-24 11:46 ` Conor.Dooley
2022-08-24 12:28 ` Alexandre Belloni
2022-08-24 13:25 ` Christophe JAILLET [this message]
2022-10-13 21:32 ` Alexandre Belloni
2022-10-13 21:34 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14607d5-337c-3e75-2b95-720553f40282@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=Conor.Dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®