mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jie Deng <Jie.Deng1@synopsys.com>
To: Arnd Bergmann <arnd@arndb.de>, Jie Deng <Jie.Deng1@synopsys.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license
Date: Tue, 21 Mar 2017 10:34:05 +0800	[thread overview]
Message-ID: <c146aa97-3c33-e457-7a1d-435a6efeaeaf@synopsys.com> (raw)
In-Reply-To: <20170320085123.1032301-2-arnd@arndb.de>

On 2017/3/20 16:51, Arnd Bergmann wrote:
> When building the driver as a module, we get a warning about the
> lack of a license:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o
> see include/linux/module.h for more information
>
> Curiously the text in the .c files only mentions GPLv2+, while the license
> tag in the PCI driver contains both GPL and BSD. I picked the license text
> as the more definite reference here and put a GPL tag in there.
>
> Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/ethernet/synopsys/dwc-xlgmac-common.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> index 726d78ac4907..b72196ab647f 100644
> --- a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> +++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> @@ -25,6 +25,7 @@
>  
>  static int debug = -1;
>  module_param(debug, int, 0644);
> +MODULE_LICENSE("GPL");
>  MODULE_PARM_DESC(debug, "DWC ethernet debug level (0=none,...,16=all)");
>  static const u32 default_msg_level = (NETIF_MSG_LINK | NETIF_MSG_IFDOWN |
>  				      NETIF_MSG_IFUP);
This driver uses dual license. I will update the headers to include BSD. Thanks!

  reply	other threads:[~2017-03-21  2:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20  8:51 [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Arnd Bergmann
2017-03-20  8:51 ` [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Arnd Bergmann
2017-03-21  2:34   ` Jie Deng [this message]
2017-03-22 17:53   ` David Miller
2017-03-21  2:22 ` [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Jie Deng
2017-03-22 17:53 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c146aa97-3c33-e457-7a1d-435a6efeaeaf@synopsys.com \
    --to=jie.deng1@synopsys.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome