From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FD6EE49AD for ; Sat, 19 Aug 2023 14:26:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233435AbjHSO0U (ORCPT ); Sat, 19 Aug 2023 10:26:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233378AbjHSO0T (ORCPT ); Sat, 19 Aug 2023 10:26:19 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D89713D4F for ; Sat, 19 Aug 2023 07:26:16 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-99bcc0adab4so230936666b.2 for ; Sat, 19 Aug 2023 07:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692455175; x=1693059975; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cbpjVMNTkdRcuIw5rXUTxCd8hco58fdsRPI7jXTvCz4=; b=uSI/SKZKEaP/YyftU6PFB4YI8wLW387G/ZraE5IJRsolM1vPqyS/63teOQKNpVLGoR M9r3IC8igP7NZWNBkUek2lgneN4n4hN7WNCrZGIGFu7wqebYOAzM15zMNxmVxBXKjCKQ cehpORCPBykKNEdqtD5tmcvnHMuyOXgQdrQDkoWqIDJPsSFuNzkumjWTNDGGEv0UCnRh GidIbzvI9J5JhyVsf2OrBlGoZww2gTlmG6BEfvUbP7r6FLwP5oWShRlWxcMD6WHKPxLP 5/CRzMoeTY4rnlYOmlvLLphlqtwroGeYhi10KN4g/NpJ1mbVFbn1ms2rxGiofHuCrkf1 RuFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692455175; x=1693059975; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cbpjVMNTkdRcuIw5rXUTxCd8hco58fdsRPI7jXTvCz4=; b=J0AP0s85akPIVfK5dkha5e0CtEiGGansgP3874ZFnkE++CwqlyU6j3Af3Xh1qddD5b nz8PqjdDe+2zq6jWt9m8lm29Dhj4vVhlikc8xhLiAtFqWhWLieecv+41+YZzn95scfGw hXdnLDZtFSp/qkKAGHnON23xYkQSo+xxX2LuvNUWYj8XSVkq71+n5bRnwjxLjGoZK2x/ vxtk+IjSM10yZE3tJJf8G21PWhFAVo5jHv6/gDB6WPg8u/Qi50M5RazhFakQAs52RSyZ d0jJw9qcwpBbgGteM78w8Vwkkik57L7p+OnvxmFmM6kh5YP6WihGKLTtL0SdoxL/h39f TYhg== X-Gm-Message-State: AOJu0YztGZV6DDpsEdJt9bgxiZGGH8vGqv7I1V7RL/8uGQlxrF+hS/59 foM0ocveQxEzhEX8iZOeWnj4nA== X-Google-Smtp-Source: AGHT+IG0knWJWrIMrXZddpta476bz0tcU0vmlzwCjL5GzABDGovZzi0nI+14ge9GCXDYQtqXUdut3w== X-Received: by 2002:a17:906:220f:b0:994:554b:7f27 with SMTP id s15-20020a170906220f00b00994554b7f27mr1690881ejs.2.1692455175010; Sat, 19 Aug 2023 07:26:15 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id k11-20020a17090666cb00b009926928d486sm2785608ejp.35.2023.08.19.07.26.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Aug 2023 07:26:14 -0700 (PDT) Message-ID: Date: Sat, 19 Aug 2023 16:26:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 2/4] dt-bindings: net: Add Loongson-1 DWMAC glue layer Content-Language: en-US To: Keguang Zhang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Bogendoerfer , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Serge Semin References: <20230816111310.1656224-1-keguang.zhang@gmail.com> <20230816111310.1656224-3-keguang.zhang@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230816111310.1656224-3-keguang.zhang@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/08/2023 13:13, Keguang Zhang wrote: > Add devicetree binding document for Loongson-1 DWMAC glue layer. > > Signed-off-by: Keguang Zhang > --- > V1 -> V2: Fix "clock-names" and "interrupt-names" property > Rename the syscon property to "loongson,dwmac-syscon" > Drop "phy-handle" and "phy-mode" requirement > Revert adding loongson,ls1b-dwmac/loongson,ls1c-dwmac > to snps,dwmac.yaml > > .../bindings/net/loongson,ls1x-dwmac.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml > > diff --git a/Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml b/Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml > new file mode 100644 > index 000000000000..cf5477450e29 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/loongson,ls1x-dwmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson-1 DWMAC glue layer Please implement Serge's comments about title and description. Rest looks good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof