From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBFFF335BA for ; Thu, 27 Nov 2025 15:32:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764257526; cv=none; b=H9UyhUb46XwivziLkfPjEJEbfhanx3oOlcEAaqADXoszd5ff7aYfn13VKXRcDtfCLjBLcE326wo7BLOCo1emBbWD7gpDSZVy9TOSqcucVjx6oRSEyHfd7AY/+f3xPdoOs/KGp9dKoapfcyfy2SikqZ5u0Vt3Nn3f3T8SXdU+/jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764257526; c=relaxed/simple; bh=msSHSGXp3D+r4I+P0AjK3CWDZIQ8kBRUoWWzV5LiEPY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Eg6pFsXKskTc94tomCz/709tuGk37eDn9o6QiaA8gcJCzhQL5wOv8yKKLNor2pbQ63R2T/Z4gEHeIfMdSo8+H8jwSpEWaa0YVksS7CdqzKZ23S9LZ2bDPFwjdiqcg0hw41EKpx/NEAIUaevlF2YdDlRPYrMvmJkGLRk9s0HrLUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=GxMPXrqH; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="GxMPXrqH" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 16D66C16A1A; Thu, 27 Nov 2025 15:31:39 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D55DA6068C; Thu, 27 Nov 2025 15:32:01 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id F3F42102F218C; Thu, 27 Nov 2025 16:31:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1764257520; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=z7kzfN+4IxIUJeJ9Y0UHWxqVlHfeGyKEeyN9o3GqdiI=; b=GxMPXrqHi724S3YP2geSWgKAplg4FeCODlTaR9T3NHBGGNNkmtjkDOUmGzEfurMVfjCa3e b1uSM9PWFwXpK6j9zzBhKgiQEorqV1y9aZpTp9j4TmNq1kzjcXlUbi9oDJc9oGGJIJFtvu legmP0ntO52XJVJB2r5vmSjEhAah6aPuqAj/xKTz7dWuh6x7rn8Ggwr7mXrYcFIwjeMu4R dWzxToUA5EPtmLGjKqLs24NB/0g6vIf04bI8KmMuyfRgH9SYU56SEMVuFvxvl1lmpdA2RP 3v/ph7NnvgRzaEHUwnsFW3zjafgDqHF8hLzeQxTMpANvTishuhYmqEwJPPUnLQ== Message-ID: Date: Thu, 27 Nov 2025 16:31:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v8 1/1] Documentation: net: add flow control guide and document ethtool API To: Andrew Lunn , Oleksij Rempel Cc: Jakub Kicinski , Vladimir Oltean , Alexei Starovoitov , Russell King , Eric Dumazet , Rob Herring , Florian Fainelli , Donald Hunter , Daniel Borkmann , Jonathan Corbet , John Fastabend , Lukasz Majewski , Stanislav Fomichev , Paolo Abeni , Jiri Pirko , Jesper Dangaard Brouer , Divya.Koppera@microchip.com, Kory Maincent , Vadim Fedorenko , netdev@vger.kernel.org, Sabrina Dubroca , linux-kernel@vger.kernel.org, kernel@pengutronix.de, Krzysztof Kozlowski , "David S. Miller" , Heiner Kallweit References: <20251119140318.2035340-1-o.rempel@pengutronix.de> <20251125181957.5b61bdb3@kernel.org> <20251126144225.3a91b8cc@kernel.org> <7a5a9201-4c26-42f8-94f2-02763f26e8c1@lunn.ch> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <7a5a9201-4c26-42f8-94f2-02763f26e8c1@lunn.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Andrew I am sorry, I have a bit of sidetracking... >> State Persistence and Toggling When toggling autoneg (e.g., autoneg on -> off >> -> on), should the kernel or driver cache the previous advertisement? > > This has been discussed in the past, and i _think_ phylink does. > > But before we go too far into edge causes, my review experience is > that MAC drivers get the basics wrong. What we really want to do here > is: > > 1) Push driver developers towards phylink Is it something we should insist on in the review process ? Can we make it a hard requirement that _new_ MAC drivers need to use phylink, if the driver plans to interact with a PHY ? phylink has long outgrown the original use-case of supporting SFPs by abstracting away the MAc to [PHY/SFP] interactions, it's now used as a an abstraction layer that avoids MAC drivers making the same mistakes over and over again on a lot of cases that don't have anything to do with SFP. I think we can no longer really say "If your driver is simple enough, you can stick to using phylib directly", at least not for new drivers, as phylink now simplifies EEE, WoL, Pause, etc. > 2) For those who don't use phylink give clear documentation of the > basics. > > We can look at edge cases, but i would only do it in the context of > phylink. Its one central implementation means we can add complexity > there and not overload developers who get the basics wrong. > > Andrew Maxime