From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Diogo Jahchan Koike <djahchankoike@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
syzbot+ec369e6d58e210135f71@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch net-next v2] net: ethtool: fix unheld rtnl lock
Date: Mon, 26 Aug 2024 19:23:00 +0200 [thread overview]
Message-ID: <c14bc7fa-5692-4952-ac83-ed14c65ed821@csgroup.eu> (raw)
In-Reply-To: <20240826170105.5544-1-djahchankoike@gmail.com>
Hi Diogo,
Le 26/08/2024 à 19:00, Diogo Jahchan Koike a écrit :
> [Vous ne recevez pas souvent de courriers de djahchankoike@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> Hi Maxime
>
> Thanks for the clarification, I missed that. Should I resend my first patch
> or should I release the lock before every return (tbh, I feel like that may
> lead to a lot of repeated code) and send a new patch?
>
Do not duplicate release lock before every return.
See
https://docs.kernel.org/process/coding-style.html#centralized-exiting-of-functions
Christophe
next prev parent reply other threads:[~2024-08-26 17:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 13:06 [PATCH] " Diogo Jahchan Koike
2024-08-26 13:30 ` Przemek Kitszel
2024-08-26 14:06 ` [patch net-next v2] " Diogo Jahchan Koike
2024-08-26 16:09 ` Maxime Chevallier
2024-08-26 17:00 ` Diogo Jahchan Koike
2024-08-26 17:23 ` Christophe Leroy [this message]
2024-08-26 17:30 ` Diogo Jahchan Koike
2024-08-26 17:38 ` [patch net-next v3] " Diogo Jahchan Koike
2024-08-26 17:44 ` Eric Dumazet
2024-08-27 7:23 ` Maxime Chevallier
2024-08-27 19:46 ` Jakub Kicinski
2024-08-28 6:37 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14bc7fa-5692-4952-ac83-ed14c65ed821@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=djahchankoike@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+ec369e6d58e210135f71@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®