From: Logan Gunthorpe <logang@deltatee.com>
To: Xiao Ni <xni@redhat.com>
Cc: open list <linux-kernel@vger.kernel.org>,
linux-raid <linux-raid@vger.kernel.org>,
Song Liu <song@kernel.org>, Christoph Hellwig <hch@infradead.org>,
Guoqing Jiang <guoqing.jiang@linux.dev>,
Stephen Bates <sbates@raithlin.com>,
Martin Oliveira <Martin.Oliveira@eideticom.com>,
David Sloan <David.Sloan@eideticom.com>
Subject: Re: [PATCH v2 00/12] Improve Raid5 Lock Contention
Date: Thu, 21 Apr 2022 10:02:33 -0600 [thread overview]
Message-ID: <c14c0103-9cbd-7d0f-486b-344dd33725ab@deltatee.com> (raw)
In-Reply-To: <CALTww28fwNpm0O_jc7-2Xr0JSX9i6F1kgoUQ8m_k6ZgPa1XxXw@mail.gmail.com>
On 2022-04-21 02:45, Xiao Ni wrote:
> Could you share the commands to get the test result (lock contention
> and performance)?
Sure. The performance we were focused on was large block writes. So we
setup raid5 instances with varying number of disks and ran the following
fio script directly on the drive.
[simple]
filename=/dev/md0
ioengine=libaio
rw=write
direct=1
size=8G
blocksize=2m
iodepth=16
runtime=30s
time_based=1
offset_increment=8G
numjobs=12

(We also played around with tuning this but didn't find substantial
changes once the bottleneck was hit)
We tuned md with parameters like:
echo 4 > /sys/block/md0/md/group_thread_cnt
echo 8192 > /sys/block/md0/md/stripe_cache_size
For lock contention stats, we just used lockstat[1]; roughly like:
echo 1 > /proc/sys/kernel/lock_stat
fio test.fio
echo 0 > /proc/sys/kernel/lock_stat
cat /proc/lock_stat
And compared the before and after.
Logan
[1] https://www.kernel.org/doc/html/latest/locking/lockstat.html
next prev parent reply other threads:[~2022-04-21 16:02 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 19:54 Logan Gunthorpe
2022-04-20 19:54 ` [PATCH v2 01/12] md/raid5: Factor out ahead_of_reshape() function Logan Gunthorpe
2022-04-21 6:07 ` Christoph Hellwig
2022-04-21 9:17 ` Paul Menzel
2022-04-21 16:05 ` Logan Gunthorpe
2022-04-21 23:33 ` Wol
2022-04-27 1:28 ` Guoqing Jiang
2022-04-27 16:07 ` Logan Gunthorpe
2022-04-28 1:49 ` Guoqing Jiang
2022-04-28 15:44 ` Logan Gunthorpe
2022-04-29 0:24 ` Guoqing Jiang
2022-04-20 19:54 ` [PATCH v2 02/12] md/raid5: Refactor raid5_make_request loop Logan Gunthorpe
2022-04-21 6:08 ` Christoph Hellwig
2022-04-27 1:32 ` Guoqing Jiang
2022-04-27 16:08 ` Logan Gunthorpe
2022-04-28 1:16 ` Guoqing Jiang
2022-04-20 19:54 ` [PATCH v2 03/12] md/raid5: Move stripe_add_to_batch_list() call out of add_stripe_bio() Logan Gunthorpe
2022-04-27 1:33 ` Guoqing Jiang
2022-04-20 19:54 ` [PATCH v2 04/12] md/raid5: Move common stripe count increment code into __find_stripe() Logan Gunthorpe
2022-04-21 6:10 ` Christoph Hellwig
2022-04-27 1:33 ` Guoqing Jiang
2022-04-20 19:54 ` [PATCH v2 05/12] md/raid5: Factor out helper from raid5_make_request() loop Logan Gunthorpe
2022-04-21 6:14 ` Christoph Hellwig
2022-04-20 19:54 ` [PATCH v2 06/12] md/raid5: Drop the do_prepare flag in raid5_make_request() Logan Gunthorpe
2022-04-21 6:15 ` Christoph Hellwig
2022-04-27 2:11 ` Guoqing Jiang
2022-04-20 19:54 ` [PATCH v2 07/12] md/raid5: Move read_seqcount_begin() into make_stripe_request() Logan Gunthorpe
2022-04-21 6:15 ` Christoph Hellwig
2022-04-27 2:13 ` Guoqing Jiang
2022-04-20 19:54 ` [PATCH v2 08/12] md/raid5: Refactor for loop in raid5_make_request() into while loop Logan Gunthorpe
2022-04-21 6:16 ` Christoph Hellwig
2022-04-20 19:54 ` [PATCH v2 09/12] md/raid5: Keep a reference to last stripe_head for batch Logan Gunthorpe
2022-04-21 6:17 ` Christoph Hellwig
2022-04-27 1:36 ` Guoqing Jiang
2022-04-27 23:27 ` Logan Gunthorpe
2022-04-20 19:54 ` [PATCH v2 10/12] md/raid5: Refactor add_stripe_bio() Logan Gunthorpe
2022-04-21 6:18 ` Christoph Hellwig
2022-04-20 19:54 ` [PATCH v2 11/12] md/raid5: Check all disks in a stripe_head for reshape progress Logan Gunthorpe
2022-04-21 6:18 ` Christoph Hellwig
2022-04-27 1:53 ` Guoqing Jiang
2022-04-27 16:11 ` Logan Gunthorpe
2022-04-20 19:54 ` [PATCH v2 12/12] md/raid5: Pivot raid5_make_request() Logan Gunthorpe
2022-04-21 6:43 ` Christoph Hellwig
2022-04-21 15:54 ` Logan Gunthorpe
2022-04-27 2:06 ` Guoqing Jiang
2022-04-27 16:18 ` Logan Gunthorpe
2022-04-28 1:32 ` Guoqing Jiang
2022-04-21 8:45 ` [PATCH v2 00/12] Improve Raid5 Lock Contention Xiao Ni
2022-04-21 16:02 ` Logan Gunthorpe [this message]
2022-04-24 8:00 ` Guoqing Jiang
2022-04-25 15:39 ` Logan Gunthorpe
2022-04-25 16:12 ` Xiao Ni
2022-04-28 21:22 ` Logan Gunthorpe
2022-04-29 0:49 ` Guoqing Jiang
2022-04-29 16:01 ` Logan Gunthorpe
2022-04-30 1:44 ` Guoqing Jiang
2022-04-24 7:53 ` Guoqing Jiang
2022-04-25 15:37 ` Logan Gunthorpe
2022-04-25 23:07 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14c0103-9cbd-7d0f-486b-344dd33725ab@deltatee.com \
--to=logang@deltatee.com \
--cc=David.Sloan@eideticom.com \
--cc=Martin.Oliveira@eideticom.com \
--cc=guoqing.jiang@linux.dev \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=sbates@raithlin.com \
--cc=song@kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®