From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A684CD37BD for ; Fri, 15 Sep 2023 20:49:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237714AbjIOUtm (ORCPT ); Fri, 15 Sep 2023 16:49:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237690AbjIOUtT (ORCPT ); Fri, 15 Sep 2023 16:49:19 -0400 Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 456482D64 for ; Fri, 15 Sep 2023 13:48:50 -0700 (PDT) Received: from eig-obgw-6009a.ext.cloudfilter.net ([10.0.30.184]) by cmsmtp with ESMTP id hAJfqOjXEWU1chFk9qTgtB; Fri, 15 Sep 2023 20:48:50 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id hFk9q2C9JOCehhFk9qYGTK; Fri, 15 Sep 2023 20:48:49 +0000 X-Authority-Analysis: v=2.4 cv=feK+dmcF c=1 sm=1 tr=0 ts=6504c331 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=BY5PBP3jAAAA:8 a=P-IC7800AAAA:8 a=sozttTNsAAAA:8 a=KKAkSRfTAAAA:8 a=IpJZQVW2AAAA:8 a=mK_AVkanAAAA:8 a=JfrnYn6hAAAA:8 a=cm27Pg_UAAAA:8 a=VwQbUJbxAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=gQW0MTutLl7eKD3OLfcZ:22 a=d3PnA9EDa4IxuAV0gXij:22 a=aeg5Gbbo78KNqacMgKqU:22 a=cvBusfyB2V15izCimMoJ:22 a=IawgGOuG5U0WyFbmm1f5:22 a=3gWm3jAn84ENXaBijsEo:22 a=1CNFftbPRP8L7MoqJWF3:22 a=xmb-EsYY8bH0VWELuYED:22 a=AjGcO6oz07-iQ99wixmX:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZgsrTB4ijVLhsjuka7LCf1vP3KJ69ueZYWGwWisaVKA=; b=IRvyZEZ58BWzjvA37uFDtVeDu0 SHv9y9Zi52SBnAa4kZgCra9Z/4HYBKrsMNBm7VLU2OyJEHU41Jiz2vVG2PPQ2nqsAh/tqH4viMF8C Ec+u1ZOZ4aOY7EorR/njLUer57jGZnKtX9KxL6bPHFqdQp/EsZwBpcQ5IdfmkydkuvOB0SRNgBIDl A4h0E1njPsuqwyVjtFYY8LzwymRIunN3p4U142i0dphwDdYEDWLCITWTi8BA2EuQ5qVvvuDJnjfKg IWhsaXB6XxFjyuX5zPoUpkyxZS1QLkOKEEZhmSAHWCXYRh+2AC1SEwLZZvYkXLkB95YXZ4ARrRyVA CSPDe6qw==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:50288 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qhFk6-002dt3-1t; Fri, 15 Sep 2023 15:48:46 -0500 Message-ID: Date: Fri, 15 Sep 2023 14:49:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mtd: rawnand: meson: Annotate struct meson_nfc_nand_chip with __counted_by Content-Language: en-US To: Kees Cook , Liang Yang Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230915201249.never.509-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230915201249.never.509-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qhFk6-002dt3-1t X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:50288 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 363 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNeofF+u0/ZpxYlSi2ggcHuf7zKHFu0RBYAUaZ0NVJ0yLVVLCmdY9DwAtAkb6vj4Ba1+CdIY7wgUdoG635jwn51FSM5lUQO7btIs0yxrbfWPYBN985pg QzQf+zCUiuiTke75Y+IBFkPzL0JFc6AMxvNq0AU4srg+zSxEhGob4QFjkWDD6HoKxiQ7gzxp4S07tdlQxugftPhZf8ljHaSXznJJu0ygR2/gfnHWLihHL39r Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/15/23 14:12, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct meson_nfc_nand_chip. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Liang Yang > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: Jerome Brunet > Cc: Martin Blumenstingl > Cc: linux-mtd@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/mtd/nand/raw/meson_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index 25e3c1cb605e..378f28ce6a74 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -128,7 +128,7 @@ struct meson_nfc_nand_chip { > u8 *data_buf; > __le64 *info_buf; > u32 nsels; > - u8 sels[]; > + u8 sels[] __counted_by(nsels); > }; > > struct meson_nand_ecc {