From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1BE130FF29 for ; Mon, 1 Dec 2025 13:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764594221; cv=none; b=bqTe5GBEVOCslIcuDRSHYjfKg4I8DrF4r99t2qTpFMVxdx/MNvrrwwZ0ltGxundyeRE9qtC/tMghDuQJ44BFNHWDZvIYWv8aml6FGV9SMsYCcYqbuTZPQkhHv0x1qu+u2WWXubTqi+LFN4sSnm3tW4BcgguY/BdH/1F0sFnocA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764594221; c=relaxed/simple; bh=mQiRzhVPiTBI5fhfG5QlYmYGwxQKVPYJzIQfa/KT8TY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ch6I0J+avuhYeOfrOefdhCX3HIbHqMUnN/PFUsBOBHyB2z9fjzBVwh361+RVNmloCWENVDi00dcu66qHSTYTEHH67ruUGPxlTG2shq8z1D93B5Pizkr2ah+N6aqMWqKMVEPvBvTXjXNROILnAAtJFX3y0UZWXG+wOdgZtS47JiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KDGZCW8g; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WE9/hG1l; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KDGZCW8g"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WE9/hG1l" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B18OTvh4060778 for ; Mon, 1 Dec 2025 13:03:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ctg+o1lzozlYykOwrPvWfRQts5DzAQREjfwDpCaJEFg=; b=KDGZCW8gOwA5z+dU 7p+aW47KzL7MlgizscFE3966je9YM+dpKsgar8MEH4sqByEgwL1+J9jrLXceq7eq TJyhdYKf6ye20fCWdgnOBcNlFGwctx3HiccJhjUkRyJt+KIm0lCS7wAIvbHeP6bh /Pa7jVeOs06DEfVzCkrsO13MIyQFBguVgVdkliy/098XcPRVkPHHAYxFmE/B6GVM t13lR+epDg0uX8tjgzql64RjdN73HxOp8jPvCw4sa1f9pM3hytFoT5xKqAHdLfGQ bTasuVEGwpElWGthBheU5BKFllo6tc1TJmeflm2de/0jH1KQQvlO1Sx/9h5qYmlb BBOhCg== Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4as7fwrsrp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Dec 2025 13:03:35 +0000 (GMT) Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-640e308c7ceso663544d50.2 for ; Mon, 01 Dec 2025 05:03:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764594215; x=1765199015; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ctg+o1lzozlYykOwrPvWfRQts5DzAQREjfwDpCaJEFg=; b=WE9/hG1l8o1rVTSvsMTs+LqD5jLoS2EOO8y7/gz03w6xBH1W6VVVhxfjfCcdzZYeyj Ua6EhknfVA9o5dZ5USSeqitz7VUgp268rw0E3j+kXs6sc8Bn9h/blDv3WzUy4CtC9WRh HMmd8kXVoUj+gxzF8uSJvO3D9XKiTvfIcScVKiuliS3YZ0T85QWUWB3er6B7pF2zLPwJ Wll3ZJtNogLWBd53SbwD57q/vgv90W4dXZRVfuzU5U71wVkyX+dyQcCtGfKNCamzksyh eVDe3de6TKZFYkwU1agaAlWgwHcEP8DszR+KNcye5AhENjBIN2rqrgCF8nFO6JSAvm6S bVhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764594215; x=1765199015; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ctg+o1lzozlYykOwrPvWfRQts5DzAQREjfwDpCaJEFg=; b=ga/7qPpzj/tzExaU6kDQiPnw4Vb5+Sm9vdegQMsC729OAoPWpSlG3tg2ilkVfZ1QNt GnLd7+nQVfEgjZ04/Pk10/fyvg9nhqb/aDULo7aDeidtLtuymKWlDiCzBvjrzR8cmQVD 2N3hN4NUIgFnHJgSSUI4Mx761QeQ7tT33B54FueiuXvY7LTE0vcRiuRQXmaduf2AducF 6DOLEjVUnaGueO+12/cr/oRx3ZK5DpfewIu8WI58uWUrZ9R+GHN+IDgGGK1HQMLxMD6g BQC/HuyuvOWGuxR8R+FfOBtujNeor/DcaNFDBWfRq7oUHUwDlCzfAWQQ1vC7lQt907Kc lT6w== X-Forwarded-Encrypted: i=1; AJvYcCVIPeinKFvnKz9ZEW7xkiTGgn0UHoDHpXmeAFFySOnyzkpMwCxhbaCEMnxDhNbBNPijXOC+BEO3ar2TIp8=@vger.kernel.org X-Gm-Message-State: AOJu0YxvuAFsYc1WgNqFig0ZezAj7+HS13Bc9iJix80TE2A8R+SblZD/ AVzfmtO5qts55YpdcFmawCeTfwjpMzGkYa34qy76vgL0rU/9LaCZM+DlVniLQm93+UvGO2ruQ/I eKxf3Js1hUe2oxp0hwY15yw4mg4JVxCIWD9kBc0/gG5De/NWT86Rm83d8IhexgGBvJeM= X-Gm-Gg: ASbGncvu0p2Bwf0QVSFVzx9ldnf+gdxR6ugQTDJ+CEdQWX9daudutpYM2j+359UtNJ3 DmYV1XcYy8xyYw50kZEzJwwY9rMMHQVhaI/gaMM6rJAW+EtA7PuWgYjnJrKphl7kNFjtTsbzx4p aMZPi3nM212IUo0e59XiyvPhsUUcUxGhWZDkcyotxcTknIesguhXqFc9eyMGpkk2d3NgYyIaxVA F7X+UyY0im11oymUFFLTG9imlp5DNCmze4tZacqQjyXX2c9KVuKmBJusaIumXqvtV3hmbSnXzEk FjM9vrN7LHOcOD1XVpMgt4Pk84PWatagxgEcLIsJINV7U9uxig+XCNa6gq41NK99hG6wz9n/cIS q0dBGL1nAQ7z0gCZcJZBeZZRCbCZ6oVVO6nF2xbgNWyd2aHFEqs4VHMItFXcRVDGp3dI= X-Received: by 2002:a05:690e:154d:10b0:640:d0e9:1d7f with SMTP id 956f58d0204a3-64302b44480mr18940972d50.3.1764594215412; Mon, 01 Dec 2025 05:03:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqMXMDUrIWgkKWxZqcL0dH0seGl1iVMJGPq0rXLF1jLMt1txAJQwrRO9ii3mNBnFaFb49pNg== X-Received: by 2002:a05:690e:154d:10b0:640:d0e9:1d7f with SMTP id 956f58d0204a3-64302b44480mr18940933d50.3.1764594214730; Mon, 01 Dec 2025 05:03:34 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64751062709sm12436798a12.35.2025.12.01.05.03.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 05:03:33 -0800 (PST) Message-ID: Date: Mon, 1 Dec 2025 14:03:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 10/11] crypto: qce - Add support for BAM locking To: Bartosz Golaszewski , Vinod Koul , Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Daniel Perez-Zoghbi , Md Sadre Alam , Dmitry Baryshkov Cc: dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, Bartosz Golaszewski References: <20251128-qcom-qce-cmd-descr-v9-0-9a5f72b89722@linaro.org> <20251128-qcom-qce-cmd-descr-v9-10-9a5f72b89722@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251128-qcom-qce-cmd-descr-v9-10-9a5f72b89722@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAxMDEwNiBTYWx0ZWRfX2R6Kj1q9MNBW 2scidq4snssrL7TO3tr5cJbG4wlXOLa8dm50MBrcsuBGh1dt74iNCFuD/arKYYwQNoA7mTD9vz0 jC2rChhd+MJyRMVwbC+ngVYiLZrJgLVcakV0R05DOsYx7IN/uN/ATVe1XP7Ij0Cx2sLO/HzmdSG S8N/N0qPeMGkL8+kYNAGl0ygsVSIcioxZRwH/aRoxskaDHENhwfpdOLTDztnqHFOUC5CSjYG/B6 aXO7MG4gRSHhxzGK7fZMqWrAbfhbfvXQQVFtkXCjwDj7j9scux7YMKWzIZbC/wjEKGceDrwq9Wr dObktgrH77aXLgZbCcf95KcrUqbcQ1zdd+tiNVMjnRwxjByuJeiG/wS+DKr/nVs9/jjZnJ7YRp4 O+djpvuA3lyhohAAp6lFBR8PN5u1HA== X-Authority-Analysis: v=2.4 cv=TbabdBQh c=1 sm=1 tr=0 ts=692d9228 cx=c_pps a=VEzVgl358Dq0xwHDEbsOzA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=SbnQZzZDCDfwX-qd_CgA:9 a=QEXdDO2ut3YA:10 a=uujmmnXaIg8lM0-o0HFK:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: gLj4RsiVg4Cwel3qJ8Uy7F6D82tBY-2g X-Proofpoint-GUID: gLj4RsiVg4Cwel3qJ8Uy7F6D82tBY-2g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512010106 On 11/28/25 12:44 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Implement the infrastructure for using the new DMA controller lock/unlock > feature of the BAM driver. No functional change for now. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/crypto/qce/common.c | 18 ++++++++++++++++++ > drivers/crypto/qce/dma.c | 39 ++++++++++++++++++++++++++++++++++----- > drivers/crypto/qce/dma.h | 4 ++++ > 3 files changed, 56 insertions(+), 5 deletions(-) > > diff --git a/drivers/crypto/qce/common.c b/drivers/crypto/qce/common.c > index 04253a8d33409a2a51db527435d09ae85a7880af..74756c222fed6d0298eb6c957ed15b8b7083b72f 100644 > --- a/drivers/crypto/qce/common.c > +++ b/drivers/crypto/qce/common.c > @@ -593,3 +593,21 @@ void qce_get_version(struct qce_device *qce, u32 *major, u32 *minor, u32 *step) > *minor = (val & CORE_MINOR_REV_MASK) >> CORE_MINOR_REV_SHIFT; > *step = (val & CORE_STEP_REV_MASK) >> CORE_STEP_REV_SHIFT; > } > + > +int qce_bam_lock(struct qce_device *qce) > +{ > + qce_clear_bam_transaction(qce); > + /* Dummy write to acquire the lock on the BAM pipe. */ > + qce_write(qce, REG_AUTH_SEG_CFG, 0); This works because qce_bam_lock() isn't used in a place where the state of this register matters which isn't obvious.. but I'm not sure there's a much better one to use in its place Wonder if we could use the VERSION one (base+0x0) - although it's supposed to be read-only, but at the same time I don't think that matters much for the BAM engine Konrad