From: Sibi Sankar <quic_sibis@quicinc.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <dietmar.eggemann@arm.com>, <marcan@marcan.st>,
<sven@svenpeter.dev>, <alyssa@rosenzweig.io>, <rafael@kernel.org>,
<xuwei5@hisilicon.com>, <zhanjie9@hisilicon.com>,
<sudeep.holla@arm.com>, <cristian.marussi@arm.com>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<quic_rgottimu@quicinc.com>,
<linux-arm-kernel@lists.infradead.org>, <asahi@lists.linux.dev>,
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH 0/2] Fix per-policy boost behavior
Date: Wed, 28 Feb 2024 10:44:46 +0530 [thread overview]
Message-ID: <c165dd32-1e51-2fac-38ae-dd7300d36372@quicinc.com> (raw)
In-Reply-To: <20240228050703.lixqywrtxravegc6@vireshk-i7>
On 2/28/24 10:37, Viresh Kumar wrote:
> On 27-02-24, 22:23, Sibi Sankar wrote:
>> Fix per-policy boost behavior by incorporating per-policy boost flag
>> in the policy->max calculation and setting the correct per-policy
>> boost_enabled value on devices that use cpufreq_enable_boost_support().
>
> I don't see the problem explained anywhere and the patches look
> incorrect too. The drivers aren't supposed to update the
> policy->boose_enabled value.
Hey Viresh,
Thanks for taking time to review the series.
In the existing code, per-policy flags doesn't have any impact i.e.
if cpufreq_driver boost is enabled and one or more of the per-policy
boost is disabled, the cpufreq driver will behave as if boost is
enabled. I had to update the policy->boost_enabled value because we seem
to allow enabling cpufreq_driver.boost_enabled from the driver, but I
can drop that because it was just for book keeping. I didn't want
to include redundant info from another mail thread that I referenced in
the cover letter, but will add more info in the re-spin.
-Sibi
>
next prev parent reply other threads:[~2024-02-28 5:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 16:53 Sibi Sankar
2024-02-27 16:53 ` [PATCH 1/2] cpufreq: Fix per-policy boost behavior on SoCs using cpufreq_boost_set_sw Sibi Sankar
2024-02-27 16:53 ` [PATCH 2/2] cpufreq: apple-soc: Align per-policy and global boost flags Sibi Sankar
2024-02-28 2:06 ` [PATCH 0/2] Fix per-policy boost behavior Jie Zhan
2024-02-28 5:07 ` Sibi Sankar
2024-02-28 5:07 ` Viresh Kumar
2024-02-28 5:14 ` Sibi Sankar [this message]
2024-02-28 6:35 ` Viresh Kumar
2024-02-28 10:09 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c165dd32-1e51-2fac-38ae-dd7300d36372@quicinc.com \
--to=quic_sibis@quicinc.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=cristian.marussi@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=quic_rgottimu@quicinc.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=sven@svenpeter.dev \
--cc=viresh.kumar@linaro.org \
--cc=xuwei5@hisilicon.com \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®