From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A59D3446C6 for ; Mon, 25 May 2026 05:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779687622; cv=none; b=Sv04jcO1Mk/5okjMUHIZIhrLeU4APQY5sEiIb9nLH4DJmvb++Ul/ZcooKNl+51pPtp8ClRCKpwZjFEbMSADGpelGLhGNJbss1PpMBve6S9pPeqLbi/Xid2vWTtgVnv9wNBuk3HY8WAsSGtJWRF1R/KdMdfji1gxQxzN2p6Nq+zw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779687622; c=relaxed/simple; bh=322HUqGm2V5uAHAY4HVPW2OCLrCgUfPAfmZK7el/h3c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e7h21U6p3r3Ws+OlExVBAU5yp/dc+7ZJ8Z3xb0LodqndDLwLUiS0xdfiHUnbdDS9QGKRIta/LOpKmqsasz7Rm+ljXFu6X6v7WYd4UH2/rf0wCqp8IT7If/7r/GDxEbIzy3nTU8nZE+NRY/ejPyaokrhubP35jl1boDoFonPkvYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MPh+cISr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VnVjeZCo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MPh+cISr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VnVjeZCo" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64OFA5Pm1211066 for ; Mon, 25 May 2026 05:40:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NXyCF+63V5r+f0I4sStSinPp8hUa1E+pxAtR+monLhk=; b=MPh+cISra0DFqIEr QcC/HI0lzz1WvVFDuFENE8MS5/xxDzHsAaLuV+JDloXFrR+KDvAxTqb9zYpp76Ov PnyGa4WkI35XD1ziGV4VK01i+xwodBQVz6VIjavYvjTiOmnIloUV2GR24ClYehuw MrJS3ZND7BgIKyCSv7bNjkCmybfLOB8ekZjzRaL3+oCOh44orgEHlANVC20i4b+X ENWqetDAkqeTg4KufCTFMcgSfNG3N4WWBgRPyfLv+TvIZINQ342mEbuTUxFHFiF0 cWHvv30QV/fTpsgSnPsDw+kuXEpFZwViz9DPvbFMIsYaFvaajaqd+IX51KjFfOow RMuBDA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eb4m7n2f7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 25 May 2026 05:40:20 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b9a3c3c4eeso91129335ad.3 for ; Sun, 24 May 2026 22:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779687619; x=1780292419; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NXyCF+63V5r+f0I4sStSinPp8hUa1E+pxAtR+monLhk=; b=VnVjeZCoXrGmN6s1HwPZA/nf2rHHK/NYV31JVwXbbZxoF76CPyGE/2C62mttw0ctos CvarpvQDBD8GjkaaZqIKcViMdb3cNh341YFbiRdm3CVK6PryNJjkXCIDl57YWM3iB5D0 569W2cyl1BhIZvmuVsYJZ6ZTuTmSvx+6Gik6+MZ9TzP6pu9Z4YUNXPieI5hqZlcI4ZMw ktzgj+ouew3ApnLdiWfMei4mOT5PBmv9XPA5VJC2uh6ZNArcTKfsXZ/sUTJonZgrOCOJ HNhjnW8CywTax8w/MYsyyvdNsV5aVtnEY+CEfyUG4tF572Amh45bciuP0Ol9IF6OHNVb huUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779687619; x=1780292419; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NXyCF+63V5r+f0I4sStSinPp8hUa1E+pxAtR+monLhk=; b=Yu/EdFF0AlKdf7BOr4XQBjuG0tYCkZyL/PxkdbIc9aBqwSsJaOrIsbfFpSFEpqpla+ yuBbxXqwdFDrGJr0GPeQ48bkJ6WH1zau2JggKKQ7z5m4zI/DCX/jLDffNA+TOEZ+TH7c wzk+ibWHZxBH56/AZCPYjY0pkh5VrnNPmbd4l7tU4zNI+BsvkXRQIiV0Pfzd72SgAw+v sWJckZY5egggh3cGPrk0iLvzj39kLJUv3bd9tGko3PdDS0ZOvX8JmD+yamQoDriK2bUM pMqClSgyiBccsw91w4Di5U3QUNQ1qJH1sdSSYecwot46Yc130vVA6kBPiDZaV0Cw4z1v YD3A== X-Forwarded-Encrypted: i=1; AFNElJ8Yo5OwE/yhzIKlxqFkfLdqZd5phYXgMa7WvAVQ1NHICmc7W2i0+I9fNnSS4eCP9Y2WX1alYaTE37ej1bg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywgu2zKC3G+BxIMHwDUFj01GP5AiC77sJgAFWQf8y7BeXsaP9G6 EmKHstIm2xSAVgiNZ6Tra98RPve/PsH7Md1rFMw8Sdt7QRxqJP1II7vpadfWj31z1ltZ94m/5+r u6ZXzHMD2/CniJnkUyer7CEtdD27m8B4ilh0Ij5l9JEXIoYSgLAw+nV9u12N+A122v90= X-Gm-Gg: Acq92OFhPx7VRiXq5TFPdPX8jmj14qLCS7bT28s+0YwpDhKJ2qsI59dq1sxaYWzc8tQ gJ4c2dyYI1tIT98GsDNnM0NPIhNZ//17cB6tRb0XxsxRZJkFP54e0YjQoZ4/7/y3BJr6yVE8Tmx jkLSf75z450995QLX6VkwWq0u8TEYVGgVjj2ibLBylTcjW78l5sOrlhqW0SX0cejuoPSIsGOFgK +SCagLuP/88CJtoL8gkgZGZ8zltf8Z0kMsw/kxvJ20o0XbFO3OsBaRHPnNW4P5oNrLiThSXdGda TMXrlQMJBs0WqMyLTSzXBwNG2K2+uU0L7Gv6d2r+IjFCaEfkNBhJlcXPEgphI4vkry4+DurDaRP PwlE6Op6hQlvJJXvJ9bI28t1Op0txSjgpJ0XSOJDhYbAX70Ur+xnf X-Received: by 2002:a17:903:3508:b0:2bd:9a28:7189 with SMTP id d9443c01a7336-2beb05a2183mr142763125ad.7.1779687619320; Sun, 24 May 2026 22:40:19 -0700 (PDT) X-Received: by 2002:a17:903:3508:b0:2bd:9a28:7189 with SMTP id d9443c01a7336-2beb05a2183mr142762835ad.7.1779687618798; Sun, 24 May 2026 22:40:18 -0700 (PDT) Received: from [10.217.223.47] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb56ce4easm78073875ad.30.2026.05.24.22.40.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 May 2026 22:40:18 -0700 (PDT) Message-ID: Date: Mon, 25 May 2026 11:10:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Add support for qcrypto on shikra To: Eric Biggers Cc: Thara Gopinath , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Frank Li , Andy Gross , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Bartosz Golaszewski , Bartosz Golaszewski , Gaurav Kashyap , Neeraj Soni References: <20260515-shikra_qcrypto-v1-0-80f07b345c29@oss.qualcomm.com> <20260514194735.GA1939213@google.com> <20260522024912.GC5937@quark> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <20260522024912.GC5937@quark> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 5kR02zjTplUS3sp3yNDuiOsmb7zdUi1a X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI1MDA1MyBTYWx0ZWRfX0OXWB1Az3Z4c SZxbRGqndGw8FOb3ohGTCbwbF5Ue2txc7Ud0WoXBqvHm7bQ5f9iUZ4NDxgsdytt3+VcgZCeccwU PJ0fkYjJWURRxqhJENo4m1Vf3auTj0Pm6U1FHAW4ljkZ8nHIb91jJi9ZLMMe3Di5QpDVGF3oemr bSB600D8MH7pSJ8kBEqs6Ttc8XqJ4ies9AQOPnO9yd7wYeBYYj5Q3qk1lI3MGLndKJjZblxVnTW PnGv7/X3bZufq7R08a01CcP2pU9C6G2oI4eEoI8Vy8OM+faoYhlLArYHI+kY7yoWhGijvOkZ4Vc 7abzX+BT/SGa9J1FWXxqMmXLrSioFHFDG6PHXO1r1OV4pgeeE+heVeXnmjoQF9FdF68ivNizfC9 60jf2xkW6h4UYO32w8KP4iKoHLSz+4g5vb732bEr3+bgcZJzSXGX1sXJ6MfXoJQrJsEC2vypdgv dW8lPdy8VaPoCtgSdSw== X-Authority-Analysis: v=2.4 cv=MrJiLWae c=1 sm=1 tr=0 ts=6a13e0c4 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=B3VgOHK6KqkFhVQj6DQA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: 5kR02zjTplUS3sp3yNDuiOsmb7zdUi1a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-25_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605250053 > It sounds like you don't actually have an answer to my questions, then. > > Performance tests (e.g. > https://lore.kernel.org/r/20250615031807.GA81869@sol/) have clearly > shown that this driver is an order of magnitude slower than the CPU. > > This driver has historically been quite harmful. People were using it > accidentally and encountering very bad performance, as well as bugs such > as crashes and filesystem hangs. We fixed that by lowering its > cra_priority. But for the same reason, even when enabled on a platform, > it's not actually used. Linux would be better without this driver. > +Bartosz, Gaurav, Neeraj Hi Eric, GPCE is relevant in terms of providing hardware security. There are multiple usecases coming up for example to handle DRM/secure buffer usecases to improve overall throughput for secure content. Regarding performance, it's currently slower compared to arm CE but provides an edge by giving hardware security which is considered more secure. Btw, there's been performance improvement with new targets and we are expecting to achieve far more better performance with new SoCs family. Pakala: GPCE - 550MBps, ARMv8 - 8GBps Kaanapali: GPCE - 3GBps, ARMv8 - 10GBps Please note, there's almost 5x improvement in kaanapali compared to pakala. Though overall is still slower compared to arm but as mentioned, expecting better performance with hardware improvements as we progress. Also, currently qce driver exhibit stability issues and that's what we are putting effort in stabilizing the software on immediate basis. There's parallel effort ongoing by Bartosz to introduce baseline for secure buffer usecases. https://lore.kernel.org/lkml/20260522-qcom-qce-cmd-descr-v18-0-99103926bafc@oss.qualcomm.com/ There's active development ongoing and i believe lowering cra_priority for qce is fine as of now and can scale values once qce becomes performance efficient. Please share your thoughts. Thanks! -- Regards Kuldeep