From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D77F339386 for ; Wed, 22 Jul 2026 10:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784717438; cv=none; b=qBgQZCv+MPVl8oj7lDmgTwTkC6GZ9mblRf4p9ZFjIT4FgIIAcTQWwW+PZ3UTxJPRn7hg01cI49PMLJLavBUSY65FTZRSfiLtRv0y2DZOura5G1rkKjujwQqXwzoTSP2Qc8hZhx2CLtfBsPK/OwDvnCY4A/RVfpJKaFOQKhN/sTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784717438; c=relaxed/simple; bh=cT26bkOTYpm3jtpcO4eFItyZdPCZz1fdM1MVN1Hdaxw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gJDctBct8/CIIMDFmc7jExtTN6nCYgEXpqRyOtdgTsJd7n5WqTRnWurWMYWyOtJ63lGXnMxvYN0rrqDMh2mcuuw1w2QMJgufrHUNF0M5O5ALlwejMDbCp04dL6oiziBAoi5WgNJ0P1qXqdSZtQ/XcvZ7tS7+EU2RoEbbTULQ4HQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=W+VYNuCk; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="W+VYNuCk" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4954afac04bso46831825e9.0 for ; Wed, 22 Jul 2026 03:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784717435; x=1785322235; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=zXZVyY5wvEWXnofFGkPYwR4wB5dvlpWTyOutOPfcI/8=; b=W+VYNuCkPhKtgOwgyPKrePXcvlgs3AKC4Pq+LNKCaOcQC4U/N+NdUBoZzzssTS9Rgn VgMNWiYVxDj+XtaOLNMn4IyGkZtK30p1c/WwOJ3EA/2MT9+m0L2Wp+ZYyW7IjkPpI7vX DFdnS0k2kGXNf+gn+r+wU6WcdRt9jTvzlldTDLOSrOgQNjF+3nTTvDOcqK/uTz+Lq4tl mGHJFwAAtbxyhv2ieYLXm4QGYsXYOxw4V6COO4yYS9QvxzRJvfGTEzzAUF5HKl3yCDDr rSiGuWbc2UESJOKXVido0X4ACWKdDYNot+XrqhN+Q3+2ddGRWBRq5vv7LjNxM3IR7XDs G2gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784717435; x=1785322235; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=zXZVyY5wvEWXnofFGkPYwR4wB5dvlpWTyOutOPfcI/8=; b=DsWmiYPLJC6x8OTPX53vW7C47b8J+Hx+cixWhL0WqGY1IwsDSDbCXAAPQ4NK8MnjXU wR6L18CuoE1661jmxjIe3M7SCMNssWGYcdY4TmX8fJvr43ueNK6JEBNmmrAPMR4SIKZd cDCifGEGkUzrrLVG+RGE/dMNLiXlnAeslExFSuxQEQo/CjhQ1LNbypRE1gew1FVkh1VH nWP/P0anWAhQ3Ish/WfpXgkiTQmYxX9MWteZ562WXSRCdEUNLpcZerDk0SfGWJvcnvR/ yDeTw/5fQCm6M8rSbSmcChXfZV6C0e49WVoMJHI6d7Gg6BFrqgtDh5JmI6PRsPxXYuuJ fDkg== X-Forwarded-Encrypted: i=1; AHgh+RrMpFTS8Xfi1e05tbbviIo13t8h2gNnVGk5wP3/2Ua0+f6P77chaBPNctN/+z4WhAD7YmwKUg7PdeybkBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyxgyV/pFCMqfyHA8UwWUpx2iZXYIRTog84h4T1BKWkk5Jbrvvn HAeNZETehZNg6B0TEmXWD5bbbbvzoTikKDJVw5FIlyRGOGsC2pgSVLZbRQPdhIT3Das= X-Gm-Gg: AR+sD1309aGU2ZoNnevnD1GQMylkTeeiL6+obJ6jgT95MrEVbCRBYiUirA1QBWiI+11 XzKbOWKCFISbwqSLzMpSm99GztxToHjdV1nX40Bu2DnkqgYPh7tiEA5OKFN7OYyrIBitjPenOdW 1FTIitsRXgjwCsFgH++zfPS0pwH45G/okiR0p/dK+3vAhDUylgnm3fIpzNElrmjIq7kFrPykSAe DuAmr5SaSht62CLamBEcfN/ZAR5d6gGxKi1DGBh+KxqLqDXQUYUBGcY9AxeBuTM9LSQzrr6a6jO Bxn9QFAmZG1vLaLR0VMpmWRvy1QM/ucir0r1ib+K3jB6vGwOM1FvmKUUIeRknmUXdkZTTikhXsQ KkfxJJbAfXF0nUYSS6yNWkPgAGX0elQgEMuzRNwPiqgtdEbXBvW+WrUA1qtI4IoL1WYrhoqZ3/l 3shhFehvIfh3ph50c= X-Received: by 2002:a05:600c:4584:b0:493:f5bf:4da4 with SMTP id 5b1f17b1804b1-4954a50e970mr252767515e9.28.1784717434661; Wed, 22 Jul 2026 03:50:34 -0700 (PDT) Received: from [10.20.4.146] ([149.62.206.101]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956537c7desm198765855e9.7.2026.07.22.03.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2026 03:50:34 -0700 (PDT) Message-ID: Date: Wed, 22 Jul 2026 13:50:31 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 07/11] x86/tdx: Add APIs to support Dynamic PAMT ops from KVM's fault path To: Rick Edgecombe , bp@alien8.de, dave.hansen@intel.com, hpa@zytor.com, kas@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, pbonzini@redhat.com, seanjc@google.com, tglx@kernel.org, vannapurve@google.com, x86@kernel.org, chao.gao@intel.com, yan.y.zhao@intel.com, kai.huang@intel.com, tony.lindgren@linux.intel.com, binbin.wu@intel.com Cc: Binbin Wu References: <20260718014500.2231262-1-rick.p.edgecombe@intel.com> <20260718014500.2231262-8-rick.p.edgecombe@intel.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20260718014500.2231262-8-rick.p.edgecombe@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/18/26 04:44, Rick Edgecombe wrote: > When handling an EPT violation, KVM holds a spinlock while manipulating > the EPT. Before entering the spinlock it doesn't know how many EPT page > tables will need to be installed or whether a huge page will be used. For > this reason it allocates a worst case number of page tables that it might > need as part of servicing the EPT violation. > > Under Dynamic PAMT these pre-allocated pages will potentially need to have > Dynamic PAMT backing pages installed for them. KVM already has helpers to > manage topping up page caches before taking the MMU lock, but they cannot > be passed from KVM to arch/x86 code. > > The problem of how and when to install the Dynamic PAMT backing pages for > the pages given to the TDX module during the fault path has had a lot of > design attempts. > - Extracting KVM's MMU caches requires too much inlined code added to > headers. > - A few varieties of installing Dynamic PAMT backing when allocating the > S-EPT page tables. (see links) > - Using mempool_t to transfer the pages between KVM and arch/x86 doesn't > work because the component is designed more around maintaining a pool > of pages, rather than topping up a continually drained cache. > > So don't do these as they all had various problems. Instead just create a > small simple data structure to use for handing a pre-allocated list of > pages between KVM and arch/x86 code. Model this on KVM's existing MMU > memory caches. > > Add a tdx_pamt_cache arg to tdx_pamt_get() so it can draw pages from a > cache when needed. Not all Dynamic PAMT page installations will happen > under spinlock, for example TD and vCPU scoped control pages. So have > tdx_pamt_get() maintain the existing behavior of allocating from the page > allocator when NULL is passed for the struct tdx_pamt_cache arg. This > prevents excess allocations for cases where it can be avoided. > > Export the new helpers for KVM. > > AI was used under supervision to review code and workshop logs. > > Co-developed-by: Sean Christopherson > Signed-off-by: Sean Christopherson > Signed-off-by: Rick Edgecombe > Reviewed-by: Kiryl Shutsemau (Meta) > Reviewed-by: Binbin Wu > Reviewed-by: Chao Gao > Reviewed-by: Yan Zhao > Reviewed-by: Tony Lindgren > Link: https://lore.kernel.org/kvm/aXENNKjAKTM9UJNH@google.com/ > Link: https://lore.kernel.org/kvm/20260129011517.3545883-20-seanjc@google.com/ > Link: https://lore.kernel.org/kvm/aYW5CbUvZrLogsWF@yzhao56-desk.sh.intel.com/ > --- Reviewed-by: Nikolay Borisov