Re: [PATCH v3 10/18] xen/pvcalls: implement listen command

[Juergen Gross <jgross@suse.com>]

On 02/06/17 21:31, Stefano Stabellini wrote:
> Call inet_listen to implement the listen command.
> 
> Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
> CC: boris.ostrovsky@oracle.com
> CC: jgross@suse.com
> ---
>  drivers/xen/pvcalls-back.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index 4a0cfa3..a75586e 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -355,7 +355,26 @@ static int pvcalls_back_bind(struct xenbus_device *dev,
>  static int pvcalls_back_listen(struct xenbus_device *dev,
>  			       struct xen_pvcalls_request *req)
>  {
> -	return 0;
> +	struct pvcalls_fedata *priv;
> +	int ret = -EINVAL;
> +	struct sockpass_mapping *map;
> +	struct xen_pvcalls_response *rsp;
> +
> +	priv = dev_get_drvdata(&dev->dev);
> +
> +	map = radix_tree_lookup(&priv->socketpass_mappings, req->u.listen.id);
> +	if (map == NULL)
> +		goto out;
> +
> +	ret = inet_listen(map->sock, req->u.listen.backlog);
> +
> +out:
> +	rsp = RING_GET_RESPONSE(&priv->ring, priv->ring.rsp_prod_pvt++);
> +	rsp->req_id = req->req_id;
> +	rsp->cmd = req->cmd;
> +	rsp->u.listen.id = req->u.listen.id;
> +	rsp->ret = ret;
> +	return ret;

return 0?


Juergen

>  }
>  
>  static int pvcalls_back_accept(struct xenbus_device *dev,
>