From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 943E527F19F for ; Thu, 16 Jul 2026 04:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784175518; cv=none; b=m5bDPCvcD50Def9eQOWHYkS9E5OOQTBuotxT45Z+6sDMuj7sOysV7kvRqACjeVRYtJcX4gDHZGbHaq12ptvFM6dRJeFgyDOmYeuFa9N0yLrv9Wv2a1PhmBn9vRW3xC3g0rL4fo0bYLez2uMz4NGjNAuY7HRHCQrD12dKe5J8JXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784175518; c=relaxed/simple; bh=//71yfLLfv0vuOQCvO3scu9aysrVv2ms+d6MiXiCmis=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bLfkRrSyT5GHXZ5BzVqfZr01vnNLsyzlRv9ypo4BrlUXxfD6MwYHwBx2M3S+lQjHmdK52kQTZ2GOOsDQ53Tr7ZtrfY2SLXdrhtbyUDTuRAZH4R03m1XjRDGKZMHU4SVStHDL/QIX+dCjGkTeshnt6Bb2AHrSgLQvnypmPoTxuyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UP3y0uRc; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IH1vg3DJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UP3y0uRc"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IH1vg3DJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784175515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=23PuyIqq3RXSlqltwOOMMD0f0XDGivtBy1U05nnBGDY=; b=UP3y0uRcuRtBDAPwqIQx/VYPxgEEXqciCX5r7bYTLwqJfdSYiLxiCBlAUxMxMvXWLfUJ/+ TH5OalDtYDoZwkJdNHNHZz9TtB1xcYBJV7xhq83XZiPC6DdzEinT1i8+7hP6UptXMAnwLL q96YUgv6cDFFZLCu1GqOPLXfKNH3wJs= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-UFhHI0U0M62NG7WYtMT6Qg-1; Thu, 16 Jul 2026 00:18:33 -0400 X-MC-Unique: UFhHI0U0M62NG7WYtMT6Qg-1 X-Mimecast-MFC-AGG-ID: UFhHI0U0M62NG7WYtMT6Qg_1784175513 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-381ed6616f7so9673029a91.1 for ; Wed, 15 Jul 2026 21:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784175513; x=1784780313; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=23PuyIqq3RXSlqltwOOMMD0f0XDGivtBy1U05nnBGDY=; b=IH1vg3DJb9sIdauvxZ8PMG1TB5YE/g0HW1apn+f2DUrlmeMF1Jjlei5WQl5EzCLlWF MnZWTM81c7gRMNtnUdeO88Gk4ERs2T86A4PWWzfek4UWwkAOFmuCclwOm3bdbhzQsm8G Vc2YARjRbZGc8qVvG9xpaXCOSWip/3D4Mvq3qLin7kvrYSGjU7UEj4WOYdpH7WEX8s+o NZMuXEfvIju8+WywFh0HAv143mSaOAKSJC6WD4+IvDOzX0UXj8Smgop85DylJ5t9I7h6 UJQw8QCL27mupNEiJE97tbxqgPqY7AsQlHGo6PBNvf6iuMrAthk+ZI5aC1FvuFp6R/lt ikAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784175513; x=1784780313; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=23PuyIqq3RXSlqltwOOMMD0f0XDGivtBy1U05nnBGDY=; b=SWrYokwiRk9uR5eoqqbkAqI0Z/rsRKWupUsdULKl1p0olmFJmXkrlV2ebrfNrTSedy ezW+14JCvvNgd14x12PpRQ1fNrq+nabGvoyk+NmkzPGG4XhO/s+TgjSEb2fWhlnEW5cS Agoo8x3JST9ZwUstmWFynaltzXGo2DqkcZ2ue3OGEC2SbkILJpWJYKXGEujVdJM57TMw kdzfVxmkWKG9tOdhG4pOSaUORF2JAxZMVwPUaB4yMDTzJ2OYiVSqs+vTWeYgZNg1tZxG 34jyM+vR64HgHtOk8Rjnd43qY5Duo7x7dYJ/Os2l//KGw8GSAdcRHBiXQGuj/du1z6DG Z7Bw== X-Forwarded-Encrypted: i=1; AHgh+RpfStCIlX4+DCzoZBMKLF1oUaNBxyvV21LoHHRpYDl0lcapkXwxNY2LxluPD9zgT8fk2Qb5QkNGKMXNWm4=@vger.kernel.org X-Gm-Message-State: AOJu0YzS6QiNsXCBSl1qIjUV7C2anZmb7UpmAfbTSKvXpcBTZ/gW5Uz0 2yGwvjTTAK7xLA0B7n47m4Ogy/PA98VrnNqt//p4l4Yrok4nlA74H+9GVO1aie8PRmq7XNCV6cN yb2fY3CDQB1+oySd2wr2fLX2JwcHDn/VEyzkEqgi5NKxKLBMhkUylFraZcwbGn0yIpA== X-Gm-Gg: AfdE7cmnaSQyypEci8rCoJMD4t5sbJgJQmOwDcQg0l5Mw01C1Rp/hV8G6WBQv7fJAM3 WAPIVaMtCgv2rSlnCy5nwYVls6SG7oPg6JZXyvXZKd0qZO+48uqXbPXpw9vU4SSTQ2uN4Bw0pOB lfB3qDqYT2BqbEaDZ2bpJTQVi+rjQe7ueDmohNZae8I57KuJhz47Pfe//nKCbFyEU+e0CBWepWP VnMC+FbY4QwABIkSE7KT6rsiHFySSF2fVlEEEVdkIcP4moR77qfcBSYF2ZzGW0VSNRFn3gfLYrS YY4v3tl5BdMjoZ0uGBat/dynfbu+xuWNG53X8b6U8PezmP2MzPiMCs6jOxtLmPdQMC1vgTOAoN7 wjBNqU+/TAk/xv8nJZ4Bw+TSmXWnQcjlVlrOnG7hNhho= X-Received: by 2002:a17:90b:4e8d:b0:381:cef1:11b0 with SMTP id 98e67ed59e1d1-38e2a04e907mr5333850a91.33.1784175512656; Wed, 15 Jul 2026 21:18:32 -0700 (PDT) X-Received: by 2002:a17:90b:4e8d:b0:381:cef1:11b0 with SMTP id 98e67ed59e1d1-38e2a04e907mr5333821a91.33.1784175512073; Wed, 15 Jul 2026 21:18:32 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3140e6e9edfsm6509039eec.28.2026.07.15.21.18.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2026 21:18:31 -0700 (PDT) Message-ID: Date: Thu, 16 Jul 2026 14:18:25 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 03/11] arm_mpam: Set mpam_feat_msmon_mbwu_31counter when there are bandwidth counters To: Ben Horgan Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com References: <20260710115546.29644-1-ben.horgan@arm.com> <20260710115546.29644-4-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260710115546.29644-4-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/10/26 9:55 PM, Ben Horgan wrote: > If there are memory bandwidth counters then there are 31 bit counters even > if there are also 44 bit counters or 63 bit counters. > > Set the 31 bit bandwidth counter feature bit whenever there are bandwidth > counters. > > Fixes: fdc29a141d63 ("arm_mpam: Probe for long/lwd mbwu counters") > Signed-off-by: Ben Horgan > --- > drivers/resctrl/mpam_devices.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > It might be worthwhile to put some context in the commit log helping readers to correlate to the specification. What I found is something like below in section 8.2.1.2 Long MBWU counter and capture of ARM IHI 0099A.a: In MSMON_MBWU, the VALUE field is always 31 bits. If MSMON_MBWU_L is implemented, the length of the VALUE field is either 63 or 44 bits as set by MPAMF_MBWUMON_IDR.LWD. > diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c > index acfa9a4dc2fc..11b10c3bc334 100644 > --- a/drivers/resctrl/mpam_devices.c > +++ b/drivers/resctrl/mpam_devices.c > @@ -930,9 +930,9 @@ static void mpam_ris_hw_probe(struct mpam_msc_ris *ris) > mpam_set_feature(mpam_feat_msmon_mbwu_63counter, props); > else > mpam_set_feature(mpam_feat_msmon_mbwu_44counter, props); > - } else { > - mpam_set_feature(mpam_feat_msmon_mbwu_31counter, props); > } > + > + mpam_set_feature(mpam_feat_msmon_mbwu_31counter, props); > } > } > } Thanks, Gavin