From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161024AbcG1QBA (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jul 2016 12:01:00 -0400
Received: from mout.web.de ([212.227.15.4]:61833 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757245AbcG1QAv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jul 2016 12:00:51 -0400
Subject: Re: staging: wilc1000: Reduce scope for a few variables in
 mac_ioctl()
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
References: <1c4cac35-dded-ea88-45aa-3f8ac098289d@gmx.de>
 <d8d9729c-6d65-a901-1b29-c0b031e143d2@users.sourceforge.net>
 <trinity-308db848-f204-4ebe-9336-484347ffbf37-1469706334519@3capp-gmx-bs72>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Steve Caldwell <Steve.Caldwell@microchip.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <c178cb06-a4b2-0a43-1de1-61bd67816deb@users.sourceforge.net>
Date: Thu, 28 Jul 2016 18:00:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <trinity-308db848-f204-4ebe-9336-484347ffbf37-1469706334519@3capp-gmx-bs72>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:vYEBMi8kvQ83+dPOIErrqsSuiEoUYsxNYrQbZODhNJHliIclG/7
 0lib7EeFvP+YlzGOAg5Uo+A8cgy2ysvwfdt8T2rUAC3BhokoYFfZjH1QsyNQm1kw8UpPejq
 SUFN1Og6fZZeBE0H5V6J6uvS0JgsMloZD+/jh737qkaC5CxGB4yEvRYmK2ZYwoiPXX/JhSW
 Px1XXNWuLo2fk18HCayDA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:aUHH2Wgc36U=:BoEtbypOloUIq4smLLOfDI
 abSpcT4Ys8G6urYff6dC/rgCp1cso2iwe2TkRlNeJwEeMnaP77pu4ByQeLYnEf00FYTMFkd1A
 K+n7u0wcbw+vlX/QbOW1nb/dwQIL9zWsRdHs/xhBurTR0hSMPyX0sH4SuME4ypNikXv37fSXf
 zc7jwt7wN47SByyIWBWbN3CtbrfyVUwYHYTvXrG8oDcAnGKPg5J8ufBHTFPRCOPk0Pp+t3Np1
 XA3pffv0F7XO6GsYXUtEDPoIEvpO+7w5ADwp9/NnxUVn89X1CmW0dm9q59tK4vJKB3MVsvgqi
 rp/ami8IhsuTRJVlg3xDq/vivarqy+MD95Ghzrlt6KlUtwp4Ho6+FQ4qrrDoy8uvAVG7rOxcu
 gMF6ncid4+/i26LmHCcKPYXwSeDidsA72HWZkf5bP7Wdy95iWGjjhgt7WtxkNmDcgB1p9FxAx
 1oRCiwXUJLbtvDt4RU9nH7wSsm9F5CkFJgq4LsBvruu5qXkRTVpPUrO87bca79vmoLc/MbC6H
 SWXwfIVVsedlQNQJpSmdQ8V+p16uEd3X2nqDmRoYoapWqSl83VPcEuRM7Y5PddY7aEC8yMiRj
 M6I6J4C79Cdgr4XMZviqCmI6+S12gwlIkuz60t9hMPAvsT3ndXZ3CTfKQpZMWel8q/OfZ6xOo
 SZ+at44Ke9PQRk7uiCtjrDDNB6SS9SNNg0Ne5FnfvEszPK9IWoJTKd3yCeHFIaa/bFUWIF4AZ
 rj7U53c3PLNgd6PNDCMEVijqQWr6EOXkmDFphvKA5/nV2j9M6HA3eVvZYwKYVR5RN//XyhjwI
 ylyJ89K
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Which circumstances do "not any sense at all" imply? 

Should the expression 'strlen("RSSI")' be passed for the parameter 'length' instead?


> I suggest to fix this since it is indeed a bug,

We can agree that this function implementation was broken for a while there.


> instead of doing "micro optimizations" - which is the last thing that code in the staging area 
> needs (as IIRC you have already been told by others, including the staging maintainer).

The acceptance might grow a bit more for such software fine-tuning
(like refactoring around variable usage).

Regards,
Markus