From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8661B3E3D80 for ; Mon, 27 Apr 2026 17:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777312012; cv=none; b=fxa3ZPKOmkwRY+KRKiMEQ9y+t02IwLEJJEE24Da+hgiVDo7GVr4xMqWtALAdlM9Q+g6QDOYNiQFQwlHtcR63O/hTRL2pxet49blZkbh8sIkbsKuvEtsNcleoz+3xebBNw7FLfxjEyMu29DSnq4yRNLxG6s1HSXYmT74mQOs4gT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777312012; c=relaxed/simple; bh=e5HjhuVcIZm6djIJ10bLTcfPxKhnYmXhabkxmU9/cyo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BTohRcikx/hnLUhNHsEEtjM93zLU5DF5NLF6FCUPWEa9zZLRlPOdCKzhD5qmpsjBLZGudv7SYH75OeXGzRvVyPL5LPscRWfkvbISeQ7TkOCzau8oT5kobc6xWOI5UDaQ0HdtBASkoPUhIouvZ3F2jw878ukp2rxdZ3LocsPMmnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YDfocJGp; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YDfocJGp" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-12ddbe104ccso697412c88.0 for ; Mon, 27 Apr 2026 10:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1777312009; x=1777916809; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7XYyRpT3Px+QXPGB9xxIGkvs+bq3B849MvDwIxQIdqI=; b=YDfocJGpkfGlw/ddwbBpOBbwdD8iTe//TVtdyw34EW8xvOUHAldWtq7ExhaIuV8Swv pMmLjT6AIX9tIsjlWojjSj0ASOASV5KQ4F5BhlNQuSMv/eM9OWg6MCTup1gVQmR1qH1z 8rS0bcizzFAAcSnh3zYfm2RJ74EKVqHNTUZfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777312009; x=1777916809; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7XYyRpT3Px+QXPGB9xxIGkvs+bq3B849MvDwIxQIdqI=; b=AlX6njJ3FVOfdGaFafisfeKuZQeOkeNHTt8bw5coyc7r8oPFXfJCC1Rhs0sb3riB8S QNXYH8E/jHDTSYVC4QKpdN5P7ysLsOrulJ5FeV9/smhf2nuKSs9GiZddqDQLLaIAhXp0 HcLVpkSBc99qZrcyNgvwK4XtdM9iKo6si3CX14P9l+JLil6vTxDs8b0PM1cVnjZiYArb rphC1C9rmyyfWf+oshNvTZW5uQB0jzZu+btPOZUhKfl2iZzpmSFXLuwFPzviF1lLHSow mURw7PgSolJVSGZn55/gzoctiQ5GAq/llwEc5A0t3NZvumhYZxs6TofeJIIhezCmISMC bSCw== X-Forwarded-Encrypted: i=1; AFNElJ9svIuahlmG5DRN66hbyOWf+marTqL1Ih0IKW/EY+SStfyu5diGxwjdzNqh9SBAmh6Nfb84t0bkU2HS4pM=@vger.kernel.org X-Gm-Message-State: AOJu0YwWHkhGG1l3mUrfN+bov4EnFqzTiHjyxriZDjeAVX28UHHGDnL5 UMws4j0sefiWdnpRWvBRttf22HdYdpxD0HVgJRq1To+wS4FwTo3HR+FYFW80eZh0wkQ= X-Gm-Gg: AeBDieuQYw++eefJcD6tmNo18leP3h7UV57bAhhZoVAiyHVTn0ELWaGVjKmiUltUqa5 V2TkzLwTWrXeT7JIJVZZPgteQNjvctyL6ienISpKD9368VhWUcNR2UyePBjxw6TJFmOpPTyZDlI QYcWuBvwkmeOJUliRKiXC3EjzI3DYO9lK9DqozpW6kYcoEwDMRRG3cAuwu+wAqR2EQCHibBGUEs IhnURhNzk0FO/oQ6iygbRvrv7/0vz+bIG8FN5Odi8f5ZUI70WQ6y/771YfZQqMWzRlOmSu9zfJR 1Cj6n9PzTIjj8tMQLl+QdlRQXGwnNKxmgzwnLX7YMxcI88P7AsIKTNAKfoom7aRdjTxVExSieEG +RbdWAqaSu0MiOEFLRv3feVG+sI4GQ0FxlJx75giNKFNuun7LV7FfV3hnzn0EPuWZjJvrR3Hgy2 /pQj1HEpmE2u2ipIUC8c97CYFt25IqMUimCcrTmR94sU/kx2uO9IYPW+0= X-Received: by 2002:a05:7022:e28:b0:12c:8e70:c338 with SMTP id a92af1059eb24-12ddd4db90emr131910c88.2.1777312009022; Mon, 27 Apr 2026 10:46:49 -0700 (PDT) Received: from [172.30.76.185] ([50.224.25.13]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ccce0f5sm44032479eec.17.2026.04.27.10.46.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 10:46:48 -0700 (PDT) Message-ID: Date: Mon, 27 Apr 2026 11:46:46 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests: harness: Restore order of test functions To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Kees Cook , Andy Lutomirski , Will Drewry , Shuah Khan , Sun Jian , Jakub Kicinski Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20260422-kselftests-harness-order-v2-1-93ea980ea3ac@linutronix.de> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260422-kselftests-harness-order-v2-1-93ea980ea3ac@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/22/26 06:32, Thomas Weißschuh wrote: > The recent addition of explicit constructor orders for fixture tests > broke the ordering of those relative to non-fixture tests and the > reverse-constructor-order detection. > > Restore the ordering of the test functions relative to each other by > using the same explicit test order for all test registrations and > __constructor_order_first(). > > Rename the constant, as it is not specific to TEST_F() anymore. > > Fixes: 6be268151426 ("selftests/harness: order TEST_F and XFAIL_ADD constructors") > Signed-off-by: Thomas Weißschuh > Reviewed-by: Kees Cook > --- > Changes in v2: > - Pick up review tag from Kees. > - Add missing closing brace in FIXTURE_VARIANT_ADD(). > - Link to v1: https://patch.msgid.link/20260420-kselftests-harness-order-v1-1-b3c603782ce8@linutronix.de > --- Applied to linux-kselftest fixes for Linux 7.1-rc2 thanks, -- Shuah