From: shuah <shuah@kernel.org>
To: Colin Ian King <colin.king@canonical.com>,
linux-kselftest@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah <shuah@kernel.org>
Subject: Re: [PATCH][V2] selftests: cpu-hotplug: fix case where CPUs offline > CPUs present
Date: Wed, 23 Jan 2019 08:07:53 -0700 [thread overview]
Message-ID: <c18c3293-631d-2deb-794d-b7057ea2c50d@kernel.org> (raw)
In-Reply-To: <abb5a36f-e513-e3ba-3286-4cc2026ef580@canonical.com>
On 1/23/19 6:25 AM, Colin Ian King wrote:
> ping?
>
> On 10/01/2019 12:38, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The cpu-hotplug test assumes that we can offline the maximum CPU as
>> described by /sys/devices/system/cpu/offline. However, in the case
>> where the number of CPUs exceeds like kernel configuration then
>> the offline count can be greater than the present count and we end
>> up trying to test the offlining of a CPU that is not available to
>> offline. Fix this by testing the maximum present CPU instead.
>>
>> Also, the test currently offlines the CPU and does not online it,
>> so fix this by onlining the CPU after the test.
>>
>> Fixes: d89dffa976bc ("fault-injection: add selftests for cpu and memory hotplug")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>> ---
>>
>> V2: remove some debug and an empty line
Sorry for the delay. I will take this for 5.0-rc5
thanks,
-- Shuah
prev parent reply other threads:[~2019-01-23 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 12:38 Colin King
2019-01-23 13:25 ` Colin Ian King
2019-01-23 15:07 ` shuah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c18c3293-631d-2deb-794d-b7057ea2c50d@kernel.org \
--to=shuah@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome