From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759340AbcHYOWw (ORCPT ); Thu, 25 Aug 2016 10:22:52 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:39663 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758882AbcHYOVW (ORCPT ); Thu, 25 Aug 2016 10:21:22 -0400 Subject: Re: [PATCH] nvme: Fix nvme_get/set_features() with a NULL result pointer To: Andy Lutomirski , Christoph Hellwig References: <20160825073810.GA18622@lst.de> CC: Andy Lutomirski , Keith Busch , , "linux-kernel@vger.kernel.org" , stable From: Jens Axboe Message-ID: Date: Thu, 25 Aug 2016 08:20:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CO1PR15CA0015.namprd15.prod.outlook.com (10.166.26.153) To DM5PR15MB1196.namprd15.prod.outlook.com (10.173.209.14) X-MS-Office365-Filtering-Correlation-Id: b5d1ee00-a1d7-4861-28ba-08d3ccf2f859 X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1196;2:fzXpPAbnSTIkST1m8KOlOpVaY2Pnpq/wAF0YDlm+PWBchlpMXiiFf7xWj7b/vKG1NH+Zy/ip3uraDItGBlG/7Jp0CMEvtx8Mu2c3FFCRVx5RUF6pYVCQU28JVpMU9nhW4pS9Du2vwiwfm7OgwKzwmKXn+a85TN0WgXsOZJtprhNpZUXF/rwa7JHkds0AMTI2;3:BewNvLSWXmVju+GctSGncpkMbJ6yNVrSKGZs30PzQplLWqa2jYn3ese6zhMZh+10W0uehwuSZiQ54CLNd6VKHabIlg29ktukiW+LDN81xFv8WjFA9WwlQyNBq9XKJaHw;25:jf8qYSiXgEQyfAYxMbzdTp4PyIAFGwXAxWGJ5/GO40W8wd9731/4hPYCo05jmtws9SygPaYWEt1CcdChoa/r7c0SbHKZBAQiOd/P430fZ+xhZHkbiFKXZCiLexG/mDoiPCKI38P7EuzVDq4JRjtFueN7Uin1uElyfU/Cvf9A5aM8v+nQvpiQeajACi0Y5s3u4Pe9oLH+S2Xw86QiISkXd0Waq+bfHDcpNSUVJ4cOjdrxbI3C0baIrREbraAnrWBS9tvRB7paoirrKJFSAjcpUo0I2RpxUYEomGWcuad+f2VrvZ14ZNCBp89WPKHOscX6KPFvLZq63IY5/O2X+211J6+r0F2PuwTclQp8bJQMPEzbswM8CJbn73MKXcZF56s3byKikf7UQ5lZY3VyesSNk/m0WDsYxaInzK1PLG7g9Ic= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1196; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1196;31:spBIDMOM8CwQuImZuhUVcG6pGsU0sSOPCPSK++FWhFSdilFle7o3kDajjk7dqjU9F9QpOgLb0lLBjZr62Jfu0719Nykj/H3ffmMHrvU732Shjz6GeaBvd7s/9CHavLklIxllT2lsoFRn0YTmsh3Hi747QRfKVX3VFh6puxSrKsRSMla7MsEAkUTxPJ+0t3TKt9jH/jLhGLh0TTyGcwfsy9Iit59uwsyojNNjzJtA/18=;20:5Il4vX3UpJPjUAp9zOeVLEIg8zoLiaUSrOtDgTck3UgVmpJTIEsXfCIcGNQZNDl2BO4jyCzzun39qfAmWzRHI8C6F3flCZM24n/1u2FgA+Zi4WvYqmTRE48LF1Ar2kV1kLISWBPKhOcAZbAfYCAYpM6fybvhoTwkF+tNbug7+fA=;4:mZl0NGBiiEGw79EoFPay3jOcJ3d+B5l6fhUOgbXmSlI/rWKrpByCWNKs1EI6ZkEy+6/GPOdaQbftf7FuA+FWk4/ofrZmdCSzSc0IR/AllX8/Up5DGnH2O7MfA/r5+mfw36PqQn5t8Zu2toA5Npd5ild2CbqmEJCtamcyBoHS38RTPvmlj9SHkYKxImPeyJwGg2AeGXwyKkcsIONEx4f3QJAj0zytw/FKH8zlejCwLmn8vZDJdS0RWkiLm6TLYw9kMrVX5Gkp6pgpQwx/Qq79Jc2v14JqZmhPb3acHgq7dORO3x26qyMPZ+kFWuSBh/TcYFDETzUaoZXP2GGSt6WuYv0frJANd6fxKFMZGUZYtX/SAUdGud1HsCVIecBWck8/CMUmWpHHXDnn3xBNZIubpg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:DM5PR15MB1196;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1196; X-Forefront-PRVS: 0045236D47 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(377454003)(24454002)(189002)(92566002)(81156014)(47776003)(66066001)(81166006)(64126003)(65956001)(86362001)(54356999)(19580395003)(68736007)(106356001)(7846002)(65806001)(101416001)(117156001)(305945005)(4001350100001)(5001770100001)(83506001)(97736004)(31696002)(19580405001)(189998001)(230700001)(50986999)(2950100001)(76176999)(7736002)(4326007)(8676002)(77096005)(3846002)(586003)(36756003)(50466002)(2906002)(6116002)(105586002)(42186005)(31686004)(23746002)(33646002)(5660300001)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1196;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR15MB1196;23:jiQssn+wQ9KJDTSioaFwmo4tHiYEqAVqdOipi?= =?Windows-1252?Q?dD/dE0v8RyAj3D6eFVMYGdE+G3pIjOc34DTTBfroIMXVhldJ8V+lQ8SL?= =?Windows-1252?Q?+DqTudM9bUIf4L+XOttBdwYiDlwrGZdF1u11ePWVit+koMOZk4mU6E37?= =?Windows-1252?Q?SLtutD4vBve2TmtSkKuyQ2TCr5lkdCsgcLW2XPJKs7ocFxI9R5neRagm?= =?Windows-1252?Q?HCWu1tO6yO005U/GRbdpdP0zY23Yq3r8neoAAxn90Sb5DRDY3jMMkQnb?= =?Windows-1252?Q?xa35nu6iZgZsQklPueL09kWd3chRguWCZtVYHyRbBQosrg8issQCQaaO?= =?Windows-1252?Q?8CgizbpgckgtsxJ1K8bQCyNl5mHgJG35g0dCMuyKqYmS5o+Gzxav4308?= =?Windows-1252?Q?I3lwZpfJfY9cpA2X/1KNLfpzjl2P1ceWefrAMbkBV4hVDsDTc/iL6s2f?= =?Windows-1252?Q?J8uz8L0oBxE8gR83etMV3xNzmKEkkEHpooFPv0qMDFQhIvQ0bWxBTVtl?= =?Windows-1252?Q?HQv8fOCGj0o13wfJsSSmBqPLeFOoyk+uMP6CB1ThdORlIA+QWKiWORpR?= =?Windows-1252?Q?nZJ4436IYv/1MNLqvGatCt63IA0Vv+E43gmmlbtinXYleAjSeXlOIeIH?= =?Windows-1252?Q?ZHAWooXE5FxdTWI1VhX4NrAgt7tWZBoxrLL8OCjw1C/SF++kBM0EPGi+?= =?Windows-1252?Q?Fq1LoY8eakV/ok0hBcw73rRwBL9a8YsghS/b9nxD4eanwOpxPBbCiINX?= =?Windows-1252?Q?E9B7qVU62L+3j4VFnSlKH5y0LyqsEEDVi6JEcKlye/rfl0gphVt768O6?= =?Windows-1252?Q?LlZA0tvZd//ACqaLu5WszHwfYdRiE6AbFJeL6EDYjhC4pI2bpPRKt2Ve?= =?Windows-1252?Q?aw08q273jd/EweIb8Dk2u92nN2e+aCgzgxJAj7zkF/DHH6vz+AAD6jJ4?= =?Windows-1252?Q?WI170X5WI02zgBtiPMFMBMmQnvXQwWr1Dlucnwap9+XIGBbXnGV2gcML?= =?Windows-1252?Q?5eeaqaVTUf286bgleFJtzSiYV0zqFdWTPc0JnJQfpWXFaBkSzMLk4/8P?= =?Windows-1252?Q?dMw1Er8NzoEv3FfogHXMvg5kZUSQYPTiA1KcoyqY9Phowsd3zyx7VaeI?= =?Windows-1252?Q?iSwhgNkWvVtixvThryE7f86cbTeBd9sw+9mPgv5OXt4/QzETUxr/Qbdw?= =?Windows-1252?Q?A7e4fqxsyA2Zonq6pEiBkkdlfdECA6x+MiZRQKZg+0hJqubtjXhrnmh9?= =?Windows-1252?Q?vHm4Gmy3Gsp03LK4FLvpwW0YzEnoVQQvcrH7VIji7bRqSdXlp1JVk7yO?= =?Windows-1252?Q?Q/f8ubKpPj6Pr7Cb3CRcmZhVJ1E9c81NiPIWbRe/ehWuJ9lUz8HJcjsX?= =?Windows-1252?Q?AiPCXjEkq6gQXWdIBZbA9/n13P1TQxXUPG8UZGl8qkOsQ0FJg5hUL4?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1196;6:y0hW1oobWY19kicZatgGM0B/nR3JfwG0gS2Zvea4hBlXRn2HnfE62zPc3vMH7w4xG89bSo4xDU0mX4WvXQ3ItAcMFkKIqmEZ9d7lCkoc6wURzLpWsJc5fVbKAKgJwhCu3gvLUW5AZMqi7d7Edf/XlQeSB8+G67SdiEtLvBaqGMrYijXYhFkU6N7ctiWyVrkEBV4Ls8oIssYauE+WQhgzrhend67izFL3HBKuUoFz6AvdThZDr0vXVKtiIzz9Z/m7AQEovIzTK71b4M1QmPeP/PayZXeMGef65qmB9RhUUoc=;5:yuayDQjguCfTQ2t2jHLrWq6ypSF0X+9V/ymGg13nsqfH6/TVHtrlquqy0nRZY0alldRiUQtu3bpn1cUH9YnGdfcxBYgl8j2RXN7LDkmJWqWdkvXmgZW4+KNGzObyDPLoJO0Oj4dnpwwPQImbCgTD1w==;24:hVS/kY2OWkO9YgT3K/VZMIQUwmZ0weH4qNcQg3KNhg5yE3g3bwNrxy6IHgz0juoOqlQ+JlcQNGpMpxxVsZq1AD84pbCYghMBojmTumCufvE=;7:TB3hRJkqlIovaGNeiJx3SMHRaQ8RBoeAKIaR+KbNPVhJXz6Zh4drENvv/vJ7ZvvwI74K8imHpNNw2GiM7sXIYBs+qTgGt8ySVcR/h26LtY/GVnRK27SC58mpuvM4wxPs8zz1gxNTKn5TpbKVVEV8ylls6vAdejl4z7aKdpoXloWYJZWQAKu7xNlmHyvi5rSMSxXopGYwPPPHIPVv9cKgwNj4Thy2e/Ze3qGDBlhtiKv+d2/PrshiHfcSC9VPQpli SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1196;20:IC04cL6o6o6CNO4EpDt2hNSuPwHOw7qIlNt56ZmkEcX7fdzNIy+AvRBuPgqO5+LGzN+0OqdWwQzyOAK5IaTta70nwUTymBogxDXInCDc582JgYH1/raX5Ej4mKwjuB6cCdzpMyhtcPL9QjCfCOdsEXeMji7znHz/Q12uKSx2NQc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2016 14:20:30.2450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1196 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-25_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/25/2016 01:54 AM, Andy Lutomirski wrote: > On Thu, Aug 25, 2016 at 12:38 AM, Christoph Hellwig wrote: >> Ooops, yes. >> >> Are you looking into new nvme_set_features users? Another thing >> we need to tackle is either replacing dma_addr argument with a >> a real kernel pointer (or just kill it until users show up) > > I am, and I have a patch to do the former (and to add a length > argument). But that's not -stable material. > > While I have your attention: the new use is to enable APST (power > saving). In theory, it seems like I should integrate with dev_pm_qos > so that the standard interface for setting a latency limit will work, > but, on brief inspection, there are literally no drivers in the entire > tree that do this. Am I missing something? My current draft patch > just adds a sysfs attribute. (It saves a *lot* of power on my laptop, > so supporting APST is worth doing.) Care to send out what you have? I'd be interested in seeing how much I can save on my laptop, haven't played with APST yet. -- Jens Axboe