From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932238AbdCILwX (ORCPT ); Thu, 9 Mar 2017 06:52:23 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:33532 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754630AbdCILvx (ORCPT ); Thu, 9 Mar 2017 06:51:53 -0500 Subject: Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue To: wharms@bfs.de, Hans Verkuil References: <20170307143047.30082-1-colin.king@canonical.com> <5dc9d025-31d5-b129-09df-5de19758e886@microchip.com> <58C14136.8060703@bfs.de> Cc: "Wu, Songjun" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: Date: Thu, 9 Mar 2017 11:50:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <58C14136.8060703@bfs.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/03/17 11:49, walter harms wrote: > > > Am 09.03.2017 11:57, schrieb Hans Verkuil: >> Hi Songjun, >> >> On 08/03/17 03:25, Wu, Songjun wrote: >>> Hi Colin, >>> >>> Thank you for your comment. >>> It is a bug, will be fixed in the next patch. >> >> Do you mean that you will provide a new patch for this? Is there anything >> wrong with this patch? It seems reasonable to me. >> >> Regards, >> >> Hans >> > > > > perhaps he will make it a bit more readable, like: > > *hist_count += i * (*hist_entry++); > > *hist_count += hist_entry[i]*i; As long as it gets fixed somehow, then I'm happy. Colin > > > re, > wh >>> >>> On 3/7/2017 22:30, Colin King wrote: >>>> From: Colin Ian King >>>> >>>> The are only HIST_ENTRIES worth of entries in hist_entry however the >>>> for-loop is iterating one too many times leasing to a read access off >>>> the end off the array ctrls->hist_entry. Fix this by iterating by >>>> the correct number of times. >>>> >>>> Detected by CoverityScan, CID#1415279 ("Out-of-bounds read") >>>> >>>> Signed-off-by: Colin Ian King >>>> --- >>>> drivers/media/platform/atmel/atmel-isc.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c >>>> index b380a7d..7dacf8c 100644 >>>> --- a/drivers/media/platform/atmel/atmel-isc.c >>>> +++ b/drivers/media/platform/atmel/atmel-isc.c >>>> @@ -1298,7 +1298,7 @@ static void isc_hist_count(struct isc_device *isc) >>>> regmap_bulk_read(regmap, ISC_HIS_ENTRY, hist_entry, HIST_ENTRIES); >>>> >>>> *hist_count = 0; >>>> - for (i = 0; i <= HIST_ENTRIES; i++) >>>> + for (i = 0; i < HIST_ENTRIES; i++) >>>> *hist_count += i * (*hist_entry++); >>>> } >>>> >>>> >> > > > > >> -- >> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >>