From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751002AbdAXXXa (ORCPT ); Tue, 24 Jan 2017 18:23:30 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39184 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdAXXX3 (ORCPT ); Tue, 24 Jan 2017 18:23:29 -0500 Subject: Re: [PATCH] cxl: drop unused header asm/pnv-pci.h To: Michael Ellerman , Greg Kurz , linuxppc-dev@lists.ozlabs.org References: <148482301037.30441.14177888563610790803.stgit@bahia> <87k29kaih9.fsf@concordia.ellerman.id.au> Cc: linux-kernel@vger.kernel.org, Frederic Barrat , Ian Munsie From: Andrew Donnellan Date: Wed, 25 Jan 2017 10:22:30 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <87k29kaih9.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17012423-0040-0000-0000-000002E83BED X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17012423-0041-0000-0000-00000C216A56 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-24_18:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701240134 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/01/17 20:57, Michael Ellerman wrote: > Greg Kurz writes: > >> The kernel API does not use anything from this header file. > > That's actually hard to prove in general, because pnv-pci.h includes > linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and > asm/opal-api.h. At least four of which aren't included directly by > api.c. > > But I'll take you word for it :) I did compile test it before giving my Reviewed-by. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited