From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CABE02207A; Tue, 2 Jul 2024 02:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719888669; cv=none; b=JqLiCh3sUbA94EvHejrlqAUE6nIJvax7N6Igp4//aSEiXMgo3RzapSCBXrZnseYw5y0Wf+7w2zwgaIcVpE6wzM2coMGaUFXHItwiBJyj8Gcqei2N2VKunWCLvufSiv8xu8qawXSzAci2MJzn5yzQfH+Cq9BdA0RkhpTnwLfm1jY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719888669; c=relaxed/simple; bh=wHHM/3hFJk0xCUITZ+9cXJAtDu8zCLg/ZftvX5BhNdI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CvlXRJSrZiXO4TJ6DWliQeCumTwzHTcBFW5hwuNLkCeR+dptGC9d7tkol3GKShnTVV5PWBLPSQFTYtmjiwlznBbb5876bhhIUaKI2qR1e2xgEDVE+dfNj57dc/mxrNBx3J6DJUqswNWZjglyli9KwajHT9UGS23HNXVgFOX3ZJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=XwGpluBs; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="XwGpluBs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=2EdzcyCiTpCY8iry1aJzJ8RLMwWeHoycdhOFxh0w+qQ=; b=XwGpluBsDBP1THxJhgLrEyeRSF FI1lctu81qLJV8a3yqupPYS1M5e00cqiwm9vCIHgzhyLlLo2H1hdrJnnHnTWZJEZBqtZ603gSjlBw SKYA2qsNbrstgrWWtQl6pivSX9P1d+n1MhkDXXsUKDclUPt6oRKIMf9THMksd7la9eIQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sOTbQ-001b3S-V1; Tue, 02 Jul 2024 04:50:44 +0200 Date: Tue, 2 Jul 2024 04:50:44 +0200 From: Andrew Lunn To: Chris Packham Cc: Luiz Angelo Daros de Luca , Linus Walleij , "alsi@bang-olufsen.dk" , Florian Fainelli , "olteanv@gmail.com" , Marek =?iso-8859-1?Q?Beh=FAn?= , "ericwouds@gmail.com" , David Miller , Eric Dumazet , "kuba@kernel.org" , Paolo Abeni , "justinstitt@google.com" , "rmk+kernel@armlinux.org.uk" , netdev , "linux-kernel@vger.kernel.org" , "sander@svanheule.net" Subject: Re: net: dsa: Realtek switch drivers Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > What would I be loosing if I don't use the DSA infrastructure? I got kind of > hung up at the point where it really wanted a CPU port and I just couldn't > provide a nice discrete NIC. DSA gives you a wrapper which handles some common stuff, which you will end up implementing if you do a pure switchdev driver. Mostly translating netdev to port index. The tagging part of DSA does not apply if you have DMA per user port, so you don't loose anything there. I guess you cannot cascade multiple switches, so the D in DSA also does not apply. You do lose out on tcpdump support, since you don't have a conduit interface which all traffic goes through. But you should not try to impose DSA if it does not fit. There are 'simple' pure switchdev drivers, you don't need to try to understand the mellanox code. Look at the microchip drivers for something to copy. Andrew