From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1429774AbdDYRia (ORCPT ); Tue, 25 Apr 2017 13:38:30 -0400 Received: from mga03.intel.com ([134.134.136.65]:36869 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1432456AbdDYRiU (ORCPT ); Tue, 25 Apr 2017 13:38:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,250,1488873600"; d="scan'208";a="80746074" Reply-To: sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v7 1/6] platform/x86: intel_pmc_ipc: fix gcr offset References: To: Andy Shevchenko Cc: Andy Shevchenko , Zha Qipeng , "dvhart@infradead.org" , Guenter Roeck , Wim Van Sebroeck , Sathyanarayanan Kuppuswamy Natarajan , David Box , Rajneesh Bhardwaj , Platform Driver , "linux-kernel@vger.kernel.org" , linux-watchdog@vger.kernel.org From: sathyanarayanan kuppuswamy Organization: Intel Message-ID: Date: Tue, 25 Apr 2017 10:34:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/25/2017 06:29 AM, Andy Shevchenko wrote: > On Mon, Apr 10, 2017 at 1:00 AM, Kuppuswamy Sathyanarayanan > wrote: >> According to Broxton APL spec, PMC MIMO resources for Global Control >> Registers(GCR) are located at 4K(0x1000) offset from IPC base address. >> In this driver, PLAT_RESOURCE_GCR_OFFSET macro defines the offset of GCR >> region base address from IPC base address and its current value of >> 0x1008 is incorrect because it points to location for PMC_CFG register >> and not the GCR base address itself. >> >> GCR Base = IPC1 Base + 0x1000. >> >> This patch fixes this offset issue. > The whole series has been pushed to testing, thanks. Thanks Andy. > >> Signed-off-by: Kuppuswamy Sathyanarayanan >> --- >> drivers/platform/x86/intel_pmc_ipc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Changes since v6: >> * Updated commit message >> >> Changes since v5: >> * None >> >> Changes since v4: >> * None >> >> Changes since v3: >> * Updated the commit history >> >> diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c >> index 0651d47..0a33592 100644 >> --- a/drivers/platform/x86/intel_pmc_ipc.c >> +++ b/drivers/platform/x86/intel_pmc_ipc.c >> @@ -82,7 +82,7 @@ >> /* exported resources from IFWI */ >> #define PLAT_RESOURCE_IPC_INDEX 0 >> #define PLAT_RESOURCE_IPC_SIZE 0x1000 >> -#define PLAT_RESOURCE_GCR_OFFSET 0x1008 >> +#define PLAT_RESOURCE_GCR_OFFSET 0x1000 >> #define PLAT_RESOURCE_GCR_SIZE 0x1000 >> #define PLAT_RESOURCE_BIOS_DATA_INDEX 1 >> #define PLAT_RESOURCE_BIOS_IFACE_INDEX 2 >> -- >> 2.7.4 >> > > -- Sathyanarayanan Kuppuswamy Android kernel developer