From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 255343DBD47 for ; Tue, 31 Mar 2026 20:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774990446; cv=none; b=AhlzMksGiF5ZASshUVW77tp/SRcp8yP9kKBhdWXgdzekQUNMlI51Qr7vyU5gKcEocSR3ktPEGkyFt5/jddkMFf76fYZ0j5JT4PqQBClJpIjS6UMyjYa6gEeIH3jrLXXJ6YjYIWMVVEsocivrcA0zdI9eOS5Fnb+2ICx9Gv7p8pI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774990446; c=relaxed/simple; bh=xzZNSyXLHafrytf3VN4xGFqU7adjtRPPfSXD0Gs3mLE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hIulE4FRxEoB+ZfkgQgCyaHPw/aNcxmVreNsDHwmrT2KRXnxwRdi+vrbJCptJUYKpc8vdi5Y2DqNlCqwjZMj3Suy5QVKGZ6QGpEKeuJ4x60rTl5/00Jl+12QzFAQUnrvdOCK7WzYxXHpzbDap43mL1E/yB5EsWeaUmyELMJ0zkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=biARpTj9; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="biARpTj9" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2c66eafc1easo4470671eec.1 for ; Tue, 31 Mar 2026 13:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774990444; x=1775595244; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZspNX5rs+mbfHqezyzp4ll5OJtm1yyo5L/3asPtSr14=; b=biARpTj9/QQwG/GWm2OaLc850ThcmromQWq0S6hENjGaLFnobmwzqhbIFFXNEonXtb oMZwypR6wkjVmzlTNTB58fS8ojw4OP6LfEvhyynI5zWCKLbE1qB5Ky402qp0Dxww/CmC r6pEDLb2JXGMEbQmLht7W6v/mFSQns1ymG8eAP7RXt6BQqYD2GlKU0xBmBJs29S2DKba 719pCPPqmrDJLNPT96IGGo4yeZK6R4Dx7FpShMXuG9fXB/KP5U03cwq0XHZS0auqNZHy y/3maR/eD7DK0jm4ETq2uoj+PVX9HtTrUHOKmOd1GRcHki/Fkn6CILpTg4HbEYNoztli bm8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774990444; x=1775595244; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZspNX5rs+mbfHqezyzp4ll5OJtm1yyo5L/3asPtSr14=; b=gXL5V0bEq+q5ybB9nCAVoDzaJR01aPY9q0ybiZSDb/ZpJdtnFbhuoBXnZHaiYj78BR qxnOqsfIwvWDdrP7QHBwXn7bG7sSrjn2m6En7FCIfrOXq+o8tPZSwJ3tFO0yCwJT4jW1 U0aBLsQiMj5c7puieOCSZlnuCrvw6hVc9u/NUw+jub1pE/SB4nC+VGXU26IhNj+X4e/u hr2amM286c92lcXMeue3cpgSgIDyh18kfBp2B8gueXXlJG+50spXaefg9nlpyOaYbcq5 RF9JxJrFyABjQxk687nYXmWO9EjF92H2H+/SltjOLS+ZDKiq/3iLA6xCTFmKUY+JfRky 73rQ== X-Forwarded-Encrypted: i=1; AJvYcCXlA3TZhTnfcmt1EyPu/dcZg1bpmBzESPPkGGixfOMLR6XfSI5OJnBpDB91jpoUKNczEpRxduU3lGaC2gU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5IkKp6uxdZrGIsoPrcoW3fP4/r4cil7X92f9mo1LbBgv2TQfU ejF46P7yPpt7ghAoRpdqSKzwkjVYxqAn7P5brPS3/GydU17dmij4+/jp X-Gm-Gg: ATEYQzyCMCleVGrHX6VFgLt+QHKWcw/Yr3+qdJF3hiBuzxk9jUC17G8YblYcRhimVBN 6DDL6CR3pNfAbAajSGgyCo0owYwmNg+Yg/n3ANu+bfu+oOBXay+PPG2pXwNV0wPPTRMvQH51bVW FLJEpgfnxzkLK7lk2G71Mlv7u/pAqYZHEi3Y5JKMyBJ7GG25M5HHuwS1typsyhf7mAtCukqSqvg o8GpvWV1NoQlVKvd7Sehff9R9bju77wvohyZWJSxduajyiaLhS14D7zhh+fH62081/WvfTXNrV2 UhiuSK0oRAQtfvHsDjEOli5tp1qldn35TSO+TS6u6/NDsLKrKQl07NxWP9eaxbrfqtgtxWx0WvQ 7oQdFLSs26C0p9sq4A+b0T0C2m3ouN1o08cT6oSqN+m2y6SM61AVKPbR9iFxOUXNHKSy3RCL9Mi XKZ78DnwuvV8bGyseWUtO/LTQ3HgAftK9CfFHbc1rILFxSL7Y1gD52DcYB6w3wWU1tpDyYZJUni 2o= X-Received: by 2002:a05:7300:fb8e:b0:2c7:11f2:d072 with SMTP id 5a478bee46e88-2c9323b8c8cmr558693eec.16.1774990443987; Tue, 31 Mar 2026 13:54:03 -0700 (PDT) Received: from [192.168.1.8] (177-4-161-218.user3p.v-tal.net.br. [177.4.161.218]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c41c1513sm11457738eec.8.2026.03.31.13.54.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 13:54:03 -0700 (PDT) Message-ID: Date: Tue, 31 Mar 2026 17:53:59 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ALSA: aoa: i2sbus: clear stale prepared state To: Takashi Iwai , Jaroslav Kysela , Johannes Berg Cc: oe-kbuild-all@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel test robot References: <20260330-aoa-i2sbus-clear-stale-active-v1-1-47a6c0a3ac9e@gmail.com> <202604010125.AvkWBYKI-lkp@intel.com> From: =?UTF-8?Q?C=C3=A1ssio_Gabriel_Monteiro_Pires?= Content-Language: en-US In-Reply-To: <202604010125.AvkWBYKI-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/31/26 14:10, kernel test robot wrote: > Hi Cássio, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on 46a6512f4a74dd7b18d9a455669c226843fc49ce] > > url: https://github.com/intel-lab-lkp/linux/commits/C-ssio-Gabriel/ALSA-aoa-i2sbus-clear-stale-prepared-state/20260331-113724 > base: 46a6512f4a74dd7b18d9a455669c226843fc49ce > patch link: https://lore.kernel.org/r/20260330-aoa-i2sbus-clear-stale-active-v1-1-47a6c0a3ac9e%40gmail.com > patch subject: [PATCH] ALSA: aoa: i2sbus: clear stale prepared state > config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20260401/202604010125.AvkWBYKI-lkp@intel.com/config) > compiler: powerpc64-linux-gcc (GCC) 15.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260401/202604010125.AvkWBYKI-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202604010125.AvkWBYKI-lkp@intel.com/ > > All errors (new ones prefixed by >>): > >>> sound/aoa/soundbus/i2sbus/pcm.c:760:25: error: initialization of 'int (*)(struct snd_pcm_substream *, struct snd_pcm_hw_params *)' from incompatible pointer type 'int (*)(struct snd_pcm_substream *)' [-Wincompatible-pointer-types] > 760 | .hw_params = i2sbus_playback_hw_params, > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > sound/aoa/soundbus/i2sbus/pcm.c:760:25: note: (near initialization for 'i2sbus_playback_ops.hw_params') > sound/aoa/soundbus/i2sbus/pcm.c:313:12: note: 'i2sbus_playback_hw_params' declared here > 313 | static int i2sbus_playback_hw_params(struct snd_pcm_substream *substream) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > sound/aoa/soundbus/i2sbus/pcm.c:829:25: error: initialization of 'int (*)(struct snd_pcm_substream *, struct snd_pcm_hw_params *)' from incompatible pointer type 'int (*)(struct snd_pcm_substream *)' [-Wincompatible-pointer-types] > 829 | .hw_params = i2sbus_record_hw_params, > | ^~~~~~~~~~~~~~~~~~~~~~~ > sound/aoa/soundbus/i2sbus/pcm.c:829:25: note: (near initialization for 'i2sbus_record_ops.hw_params') > sound/aoa/soundbus/i2sbus/pcm.c:323:12: note: 'i2sbus_record_hw_params' declared here > 323 | static int i2sbus_record_hw_params(struct snd_pcm_substream *substream) > | ^~~~~~~~~~~~~~~~~~~~~~~ > > > vim +760 sound/aoa/soundbus/i2sbus/pcm.c > > 756 > 757 static const struct snd_pcm_ops i2sbus_playback_ops = { > 758 .open = i2sbus_playback_open, > 759 .close = i2sbus_playback_close, > > 760 .hw_params = i2sbus_playback_hw_params, > 761 .hw_free = i2sbus_playback_hw_free, > 762 .prepare = i2sbus_playback_prepare, > 763 .trigger = i2sbus_playback_trigger, > 764 .pointer = i2sbus_playback_pointer, > 765 }; > 766 > Oops my bad! I had added i2sbus_playback_hw_params(), i2sbus_record_hw_params(), and the helper they use without the struct snd_pcm_hw_params *params argument expected by struct snd_pcm_ops.hw_params, which caused the compilation error. After fixing the callback signatures to match the ALSA API, the file builds cleanly. I will send a v2 patch with the proposed fixes. -- Thanks, Cássio