From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3050CC0015E for ; Thu, 27 Jul 2023 03:21:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbjG0DVy (ORCPT ); Wed, 26 Jul 2023 23:21:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbjG0DVu (ORCPT ); Wed, 26 Jul 2023 23:21:50 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 576481FC9 for ; Wed, 26 Jul 2023 20:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690428109; x=1721964109; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nPB2w9dSjqlHnzGsCdfKxPajMcJwjwbcBaw3wQ2gZzQ=; b=Q+gsYxlJfaqAbVmDFoRO++jO2Ccd5J1+MwUuLHU1RYNgWezQ03/VAvAb JiX3FjnmKNqqLbD/Q+0CXcDVejkedPNL9ZG1Efw54ifwvajKbrYR4aLMp 72skElIp8sdKKs+9YnvmwK5Cv36+R1Kjl4yXVUJ/1DtR5Xxk+IiPsQpUp s1p8oE4BSse8XeMR7a6IGUCUYi95xaj+CEyP54nOs74hiuxiLPHYmeTpJ +JO71oFZJKCAIiDyfEB7wgpSYX3ulEotthTyOD90H0j6pc/E6imdGUSaM AXh9kMx6HoVqZ970g+z75IMwzbbU+oTCe3FoFZ++ZO6mqDqQZDhcJpYV6 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="353091844" X-IronPort-AV: E=Sophos;i="6.01,233,1684825200"; d="scan'208";a="353091844" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 20:21:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="900697655" X-IronPort-AV: E=Sophos;i="6.01,233,1684825200"; d="scan'208";a="900697655" Received: from yungchua-mobl2.ccr.corp.intel.com (HELO [10.92.2.114]) ([10.92.2.114]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 20:21:45 -0700 Message-ID: Date: Thu, 27 Jul 2023 11:21:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from ACPI To: "Lu, Brent" , "alsa-devel@alsa-project.org" Cc: "Rojewski, Cezary" , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Jaroslav Kysela , Takashi Iwai , "linux-kernel@vger.kernel.org" , "Zhi, Yong" , Ajye Huang , "Bhat, Uday M" , Terry Cheong , "Chiang, Mac" , "R, Dharageswari" , Kuninori Morimoto References: <20230720092628.758834-1-brent.lu@intel.com> <20230720092628.758834-2-brent.lu@intel.com> Content-Language: en-US From: "Liao, Bard" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/2023 10:14 AM, Lu, Brent wrote: >> >> max_98390_components[] and max_98390_4spk_components[] are still used >> >> by sof_rt5682.c, we should remove them in the same patch. >> >> Maybe combine the 2 patches together? >> >> > I've got your point but these two patches are doing two things: one is refactor the > code and add a detection feature, the other one is removing the quirk. Not sure if > it's proper to merge them. The point is that if you remove them and they are still used somewhere, you will break the build. i.e. Kernel will not compile if we apply the first patch only. > Regards, > Brent