From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBF5B3F44F7 for ; Fri, 26 Jun 2026 12:10:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782475810; cv=none; b=TN4jievYLbnGh+CvqO2QYCWHpYqv30klrH6yoSmCa9PCCDWBIkoFNJV+syvsKhCGI539qX4RqkdBGIlJ74CM82OifIFZ1S6tUCb8d+lpWZ53ZYwkSSr81D9lZB8sHB1ns8J7uA7QH6avuGSmM2T0nvz/qH+HyUN/kaFa8kCEiDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782475810; c=relaxed/simple; bh=CeYszsRvzpbKpefVJb4GjzWRZN48ZGCQ5z1m7K2/2dI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F2kqutXKJrKQkesoEDWLDrJaHicN9ebCZZ02LhzlSIRfXhBB6W38//amSctN3g04ljZPPW5Xb2I0f+y8HBzbSbJ/PQCWswRWw0vKoIahK+YRVIQjJ+KWbutwDz6/s42znOcYBrx/gZ6+QzSJw5goHy/GNslOcUMcEfDL5R0R9dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f5p5xX+X; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bK4GYlN+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f5p5xX+X"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bK4GYlN+" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65QAeCC8500680 for ; Fri, 26 Jun 2026 12:10:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iSiaVRVWFJVBQaB5XydkF7gUNK0imSHXFahJpoXMMt8=; b=f5p5xX+X6/f6fpdR K26gIX/+aXlqDiIERDcNT708mo921FaqNWz5VlJtoyNUgeHMZC0i6zE1dyucfOta 7nkQIlRLOgiRHyWTWUD5k0icuPL6+Q88hpMnfaNiCvGozZ0f2X+SnovCks0Bu/9b 6d8Hw45iulsDrcK8r/1bkeGImDEP4p83QKzpCDV2FpqdcbyQKbRKTxepPuHO0UTA ToqAUMH2SQtlXCUCzPGtydCpRaGNJtOrn9Jf+GbhCI1kEZ11EPWOY7S5Kimr85MZ GrplTelwJbDAkG6QVasDQ5zEOMGjDr2lUWkI3gdO7Ai6Nq9hDTnpfV35VBL9mxa9 KgJoKw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f1j1nht1s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 26 Jun 2026 12:10:06 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c8018f11fbso9058725ad.3 for ; Fri, 26 Jun 2026 05:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782475806; x=1783080606; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iSiaVRVWFJVBQaB5XydkF7gUNK0imSHXFahJpoXMMt8=; b=bK4GYlN+4eIl/Yt1SluCaeTydD+qYZnItKlvkgpL88yjpC1y5RDDVWy5qFuDAzGvXw NwTXfT/KCgcbAA5MnsN+QN3+NTBj11duL71AURk3KxF2ufCx1uihn7iuKuWblldlkqGy LFPHkBunja7h18pnzSa61C1wqRZCq8vRS3lUDFmVdBg4BEdJiXUdn6tLRoynI5HjALUd Ld/zQPrJ9L66YBsOs3fBb0eeYVKdM6PT0zQufUk7nsPmSeCW0oScQM4g3iS7IquPNyiD 4VIUO0P1Eln4v5Lg8yip8lKwT5pJj9ZgsCvxLGl3KDkA9aemKsgivFKbpv0MtMsV+vqb HkMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782475806; x=1783080606; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iSiaVRVWFJVBQaB5XydkF7gUNK0imSHXFahJpoXMMt8=; b=OZnMjR995R1K8fnBd1aziQMpq+vn23Oh7ctDUg1AWGo1zwYSPnpkx8Gj5rt4zGpabf NOE6jTSzjxLp0C8I7bssEWTzEKOH14c/t2Gnw1upY+5/fc8Fd6zkRgaaRRerLoJdioMB n7mKwBMLFq3K+YCz6cAXucdr9I0YNaTqIdF5W1FxSYqM9HdV/ymCDlXzWglTIyoMTfce BZ7RxGMDhcnzuDz409wi8L4gYNGTVg1VjB0gU2/qCFYVGIISAzxlQimjAtzwN0BNKv5A PGIEUVEi7OdddCq4YJcpI+bCgiWwq3cIJo1SjSBV5Bt2rYNaGSXx3bG9UqHhUZzBD0he g5ZA== X-Forwarded-Encrypted: i=1; AHgh+RrVpf4KyWMMV20/1IU6jvfP3k/PhSunCp/ohyzdZIqZG1yp0/2TjYLhFXLj1a41A5CPVcAPQ8AddW27pGY=@vger.kernel.org X-Gm-Message-State: AOJu0YwWhtdsYNNvYgKRq3gWiVwZvdujxjWXskEDVI/CmlLCigqLnBJK NE4WtTMBpgTWt689gawfyYMZcBTtMga0a489Zg+CkBmuixciGXfmARh/Si+peV/LxP1R6N1Aq18 TDed42q+TnFH3da0CJ8qGZmGj5qmDToROfImvXB3PXIOwJokrTNRlPiLtvgoWp9wPRXMvbM3TzX 3pGw== X-Gm-Gg: AfdE7clAddCIomY5hxeTokKqiwO0xE4y8tKOHWc6+FfwQFjI6wtAlvN56lJpXy/WzFD kf0V6gGN3rSJPm7e4vggYCWZSCkfaolWGp3cltsAachxZkXSYHCjrhT+4qjMWRm6whK7xHpqirt KC9q08elTk+tqvQgEQ7+f0iMIWvgger87JDdBuxDyJVFPlWXfLuQSzG93GInUHt/eGaIlmiNYAL o+U3CnCOb+3UJ3OVE0fivkF40/3QXjF9N0Amn19nS6O+vrUQYojPrhIqE9c/lYpNt9SOx5W8viz OCzpxl781tFWUW5tH+GBm+QdaZgfTSvBOWouclh0M7YrYHUco/FxkTyi3B6Ltq2b0bISvbH3jew K1aog4ODnhHLnoMXg9aNr9eI2uC77B4DYD8wrnkuFh5aTViSSw1KTGqjigD380UZYE5TCwaymNA g= X-Received: by 2002:a17:902:c40d:b0:2c0:e2ea:6b0c with SMTP id d9443c01a7336-2c7fca15745mr69578395ad.21.1782475806150; Fri, 26 Jun 2026 05:10:06 -0700 (PDT) X-Received: by 2002:a17:902:c40d:b0:2c0:e2ea:6b0c with SMTP id d9443c01a7336-2c7fca15745mr69577975ad.21.1782475805623; Fri, 26 Jun 2026 05:10:05 -0700 (PDT) Received: from [10.133.33.96] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7f5ae5ecfsm38353295ad.21.2026.06.26.05.09.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jun 2026 05:10:05 -0700 (PDT) Message-ID: Date: Fri, 26 Jun 2026 20:09:58 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: kaanapali: fix traceNoC probe issue To: Leo Yan Cc: Suzuki K Poulose , Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Mike Leach , James Clark , Yuanfang Zhang , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20260624-fix-tracenoc-probe-issue-v2-0-786520f62f21@oss.qualcomm.com> <20260624-fix-tracenoc-probe-issue-v2-2-786520f62f21@oss.qualcomm.com> <471d7a92-3629-4274-a303-8906d3626037@arm.com> <25d7d3a1-58e0-4f25-a73a-59a978130c47@oss.qualcomm.com> <20260624151610.GC575984@e132581.arm.com> <20260625085643.GD575984@e132581.arm.com> <065853f5-b11b-4316-814e-202f07acb6ea@oss.qualcomm.com> <20260626103015.GE575984@e132581.arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260626103015.GE575984@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: KrHDL368rp0anwUwzJnat4d_SCMphYcR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI2MDA5OSBTYWx0ZWRfX3vJDguwMx4HT lvaw1gEFgM7HmL3KWJqKzmd7p7ptEeucvTSj69p26ibyOthmssF6BS4+FxCpq1gZPhNGx3TWhJY SZL6WwJHp2bjy3gwy3PytZJLSwQZMwJKue6AqUEZDuKz13Aa8n9nSztpc5gUuRds03AOvrN7TCz qdSxkmc9XGNKrybNeZ2XQ7dPqIvdCE9sLd25WXGbF7pa2FcuRcxmYjE7z4EfgT22DbZ9HSbI8rY rp8EYGkj6n4pFpxh55Y06o37t7xDL02Bktl1l9FqTlfg9MLP7Izf6fXvfm+i8m0mPRFZgLOlRsZ Muj2y2i97bUjTlsk9Ysgh5FFsOcd+21X9qsRxAJhreJ8qfhCiqsLfV/hAkLZ5uTowYd8Dosr+ts pN4xDc+G1ZghVUpqy+XrY2go0OnHyKhBYXvMKTiDCAYERrl9fewD195HhrGwhdNtal89BPMZK2R W4ATLjkh8ovB62WcJOw== X-Authority-Analysis: v=2.4 cv=W+cIkxWk c=1 sm=1 tr=0 ts=6a3e6c1e cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=7eVLfvEy65BM8Fiv0Z4A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI2MDA5OSBTYWx0ZWRfX4T8iGZrlS2tr opG8WpxjSouyE5FRFtyuGfrrBFsHguzpaadt1Ots3ucJJ2Fxtmz0e0XVb6fNCV23zXs2+48Z4hI xg0DSVEqqeKcNOYzBhxyqMG9ert1FcY= X-Proofpoint-ORIG-GUID: KrHDL368rp0anwUwzJnat4d_SCMphYcR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-26_03,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606260099 Hi Leo, On 6/26/2026 6:30 PM, Leo Yan wrote: > Hi Jie, > > On Fri, Jun 26, 2026 at 10:03:41AM +0800, Jie Gan wrote: > > [...] > >> Hi Leo, >> >> To be honest, I would prefer not to modify the interconnect platform driver. >> On some Qualcomm platforms, multiple itnoc devices reside within small >> blocks(one or more than one for each block) and are connected to a dummy >> source. In such cases, two ATIDs are allocated for a path (the dummy source >> and the itnoc), which is inefficient. This is why the itnoc platform driver >> created to avoid this waste. >> >> The TraceNoC (called as AG TraceNoC) is a generic TraceNoC device which >> connected to multiple source and link devices, aggregating data from all >> source devices into a single output path. > > As I said, it may be fragile to couple a specific device property (ATID) > to the AMBA driver. > > You're now facing a case where a device cannot be registered as an AMBA > device, so it cannot use ATID. Likewise, I can imagine in future where a > device is registered as an AMBA device, but you don't want ATID. > Agree. That's possible. >> This device is implemented as an AMBA device but lacks proper hardware >> configuration. As a result, it must be handled in the driver as a >> workaround, which unfortunately breaks the original design intent. > > Seems to me, it is not reasonable to pretend an AMBA device but AMBA > ID registers are absent. > > How about add a new DT property ("qcom,tnoc-enable-atid") to force > enabling ATID? That's a good proposal. I have another proposal: what if we allocate the ATID in trace_noc_id() when the device does not already have a valid ATID? Possible scenarios: If the itnoc device is connected to a TPDM device (which has no ATID), trace_noc_id() will be invoked via coresight_path_assign_trace_id(), and a valid ATID can be allocated for the path. If the itnoc device is connected to sources other than TPDM, trace_noc_id() will never be invoked, and therefore no ATID will be allocated for the device, saving resources. Thanks, Jie > > Thanks, > Leo