From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kanak Shilledar <kanakshilledar@gmail.com>
Cc: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vladimir Zapolskiy <vz@mleia.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dt-bindings: i2c: nxp,lpc1788-i2c: convert to dt schema
Date: Mon, 24 Jun 2024 10:47:58 +0200 [thread overview]
Message-ID: <c1ae6b88-78bc-4139-8046-5eecf5dbe6d6@kernel.org> (raw)
In-Reply-To: <CAGLn_=t+GyhGvtfXO=VmXB6iC3XAsAexOpqGt6AWdMNW15Lf8g@mail.gmail.com>
On 24/06/2024 09:09, Kanak Shilledar wrote:
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - interrupts
>>> + - clocks
>>> + - "#address-cells"
>>> + - "#size-cells"
>>
>> These should not be required, because you can have an enabled I2C
>> controller without children in DT.
>
> You suggest removing the address cells and size cells from the
> required properties?
Yes.
> I saw a few i2c dt-bindings and these had the address cells and size
> cells in the required
> property.
Could be.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-06-24 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 5:40 Kanak Shilledar
2024-06-20 10:57 ` Krzysztof Kozlowski
2024-06-24 7:09 ` Kanak Shilledar
2024-06-24 8:47 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1ae6b88-78bc-4139-8046-5eecf5dbe6d6@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kanakshilledar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®