From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45DD3411F9E for ; Mon, 27 Jul 2026 13:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785157757; cv=none; b=l1e3nes/58Ec56a/k8k4CjyCA/u3caPqNcoeduk0lrNPPvYjMkiFG4n1qqTeuBxGvr1lqrmNTjzyJpab/a2tpXOREJX7AuUSsGH5pyb731oIJdh6/xwNO777czZ4I+Nw8k01XUpakJyDhHHSGAUTriEC8Dt248Coi1i+qgQLQwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785157757; c=relaxed/simple; bh=53fBBoP9fU3/ThO7t/yfHoDhErj1mOeWD0CuYuQXwE4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ik6YiS6T74auGQJX79LhgVOGZBw0hSvHchr9VwS0Ho6s4G2YKdsci073XOsc6ZBULsKteA+BK67YMAPFobXghGpkVqycU0DCeP6O4cHtbj17gHZJ1n5T396K4GQmrKn+qHHu0RV4VCprjhOZceY9WUS5tYUyQUgIwqEE0L9whA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kJOk9iVg; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kJOk9iVg" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4955aa106b1so26987555e9.0 for ; Mon, 27 Jul 2026 06:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785157754; x=1785762554; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QUiq0u2Pnu448nBUShPNb5VIb4r8mjI4I6DVC3KHKDo=; b=kJOk9iVgsVxUHaBqq6o8jUeOwa1qdPyRmLxngtXWi+VfzhPMPdE7CUnDGgL8SyRgu/ Xg/Eo5eKeYMzaj6DIIxJiS9xoYh8mA70TXhwu51JEDlGbe/8SKEN151VF+LfWBwEfB4e bU0l4G58kTUrCLU8l7F84kLBOGpW/r42AxwL15zS7DxOuqEIotiULTeIIxNxgwdT9HCU 96HcbQabfk2j9inpoaCDVvEfQ2fJURzd6ycB+nFPHqdvxJDvIqdvQrKUAw6Ru3RcTsIq M5k7Uhv9AMovnZsb6lMPS2CZRzIKUgFkUEIh8bLTcZrwcJo83liKehG9okFbc53eGtKL zXNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785157754; x=1785762554; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QUiq0u2Pnu448nBUShPNb5VIb4r8mjI4I6DVC3KHKDo=; b=kP9G/YKCR0zBGzFQe4eAdFdTqcQvJVPKZH26Qzx5J4YrjNmU8xVj8lNY5Uh+ebNOw2 K1et9Iu96mH9BNxXHjiKEIUEMba58uetpPAn5KjPT/K2AF433mbWkmIu53xKaBQfczON Xf5bWRMfrqFVO3s/SsjidLumtKqfd9UF4zjq12H0m0ZP58WkgdGq6N4cgOr72i8llTdW vu8m1+rbaQxYN3z/3rztZjKLxPLg/J3NA4IM0A3tzhSQeCd1VjD0KwPLByeW/o1EnaXO OTf+EWnAikJaPvEhag6Xho3kTKpf5UgCVIecya2VkeS+VRxSHxFsIuRF4T0HYgWU0JSE SVDw== X-Forwarded-Encrypted: i=1; AHgh+RrHAmT4FgkGlwmu8JPPpaU/y7T9Y5nDcnNSrP5GspzsjWAI+IiavzeOADCjfYTulDN7VJkvL2JSNKwUzGo=@vger.kernel.org X-Gm-Message-State: AOJu0YxONzsJUGyrRJpnzAp/+DoSzNtzPJqDC+41YSC51ilvzToSq7UK OwO4bv4FmdUR3lKKKedAb3UBLOx6/3+GLy7s1diVM3eiA7DrLZExPlqz X-Gm-Gg: AR+sD11LgohGyO2i5rYVeK7s1GzwZVz5HXHIy+mfUlWTP0q1Zq7uucD2PmVf2Tv/s5F SdE+p1kHsPk0DbqhX3smmMZL0Pl35PrnPFoEZZP0izVsDZX8j0uAV/jQ9N3UxLwxQhHY426Kq+e L32nthS5qlLEHab160OLaNAqxskyjM6MjmsVgnJC/AeU/8Ofa2f7ZG+DXeHDoPxq8o2wHwc0fcI gzk8kIhDWvII7mXTzdHhK72T70uxtz8pE/ExcFpV70f/qiX6JRdypVcYlTnxcq5Fiy6KYS3c7FX Wgk5RTPwFSSp0I0eeuq0Xk6bD9ZPnFdHxOLipCf6fE0PC/QKxHA69SVEnau6FvWF1xKD+WDHAo9 IWuoQJDGpR0qSZnklGG4zm073LsvyotacT8ls4xSQRU+2VIR6kqt/OaPWxBw+HRvCuPwhWuRWiT 32xuL/JjuYtCNl4+Y183E2fPqlQfcWWqd8hNTfrc+5uwGhJabs X-Received: by 2002:a05:600c:3596:b0:496:c379:b2a1 with SMTP id 5b1f17b1804b1-496c379b2a7mr11459335e9.2.1785157754172; Mon, 27 Jul 2026 06:09:14 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:c208:9e32:8612:3f5f? ([2620:10d:c092:500::4:a69]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957b5ed646sm232662345e9.0.2026.07.27.06.09.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2026 06:09:13 -0700 (PDT) Message-ID: Date: Mon, 27 Jul 2026 14:09:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next] bpf: Add __bpfcall attribute to bpf_task_work_callback() To: Heiko Carstens , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi Cc: Mykyta Yatsenko , bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260727093834.2178900-1-hca@linux.ibm.com> Content-Language: en-US From: Mykyta Yatsenko In-Reply-To: <20260727093834.2178900-1-hca@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/27/26 10:38 AM, Heiko Carstens wrote: > BPF kCFI support is optional for architectures which support kCFI. > If an architecture provides bpf kCFI support it must override the > default __bpfcall define (which translates to __nocfi). > > Add the missing __bpfcall attribute to bpf_task_work_callback() which > calls bpf programs indirectly to avoid CFI checks for such cases. > > Fixes: 38aa7003e369 ("bpf: task work scheduling kfuncs") > Signed-off-by: Heiko Carstens > --- > kernel/bpf/helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c > index 88b38db47de9..9bf82c9ea1da 100644 > --- a/kernel/bpf/helpers.c > +++ b/kernel/bpf/helpers.c > @@ -4447,7 +4447,7 @@ static void bpf_task_work_cancel(struct bpf_task_work_ctx *ctx) > bpf_task_work_ctx_put(ctx); > } > > -static void bpf_task_work_callback(struct callback_head *cb) > +static __bpfcall void bpf_task_work_callback(struct callback_head *cb) Thanks for the patch, I've already sent another fix: https://lore.kernel.org/all/20260724-task_work_cfi-v1-1-2616691781ed@meta.com/ Is __bpfcall still needed? > { > struct bpf_task_work_ctx *ctx = container_of(cb, struct bpf_task_work_ctx, work); > enum bpf_task_work_state state;